Skip to content

Commit 1bd722b

Browse files
author
TanyaEf
committed
1. Organized imports in JasperserverRestClientTest
2. Polished SettingsServiceTest
1 parent 6989554 commit 1bd722b

File tree

2 files changed

+6
-29
lines changed

2 files changed

+6
-29
lines changed

src/test/java/com/jaspersoft/jasperserver/jaxrs/client/apiadapters/settings/SettingsServiceTest.java

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,43 +2,20 @@
22

33
import com.jaspersoft.jasperserver.jaxrs.client.core.JerseyRequest;
44
import com.jaspersoft.jasperserver.jaxrs.client.core.SessionStorage;
5-
import com.jaspersoft.jasperserver.jaxrs.client.core.exceptions.handling.DefaultErrorHandler;
6-
import com.jaspersoft.jasperserver.jaxrs.client.core.operationresult.OperationResult;
7-
import com.jaspersoft.jasperserver.jaxrs.client.dto.settings.*;
8-
import org.mockito.Mock;
9-
import org.powermock.api.mockito.PowerMockito;
105
import org.powermock.core.classloader.annotations.PrepareForTest;
116
import org.powermock.modules.testng.PowerMockTestCase;
12-
import org.testng.annotations.BeforeMethod;
137
import org.testng.annotations.Test;
148

15-
import javax.ws.rs.core.GenericType;
16-
import java.util.List;
17-
import java.util.Map;
18-
19-
import static org.mockito.Matchers.any;
20-
import static org.mockito.Matchers.eq;
21-
import static org.mockito.Mockito.times;
22-
import static org.mockito.MockitoAnnotations.initMocks;
23-
import static org.powermock.api.mockito.PowerMockito.verifyStatic;
9+
import static org.mockito.Mockito.mock;
2410
import static org.testng.Assert.assertNotNull;
25-
import static org.testng.Assert.assertSame;
2611

2712
/**
2813
* @author Tetiana Iefimenko
2914
*/
3015
@PrepareForTest({JerseyRequest.class})
3116
public class SettingsServiceTest extends PowerMockTestCase {
3217

33-
@Mock
34-
private SessionStorage sessionStorageMock;
35-
private SettingsService service;
36-
37-
@BeforeMethod
38-
public void before() {
39-
initMocks(this);
40-
service = new SettingsService(sessionStorageMock);
41-
}
18+
private SettingsService service = new SettingsService(mock(SessionStorage.class));
4219

4320
@Test
4421
public void should_return_proper_settings_adapter() throws Exception {

src/test/java/com/jaspersoft/jasperserver/jaxrs/client/core/JasperserverRestClientTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
package com.jaspersoft.jasperserver.jaxrs.client.core;
22

3+
import java.lang.reflect.Field;
34
import org.mockito.Mock;
45
import org.powermock.core.classloader.annotations.PrepareForTest;
56
import org.powermock.modules.testng.PowerMockTestCase;
67
import org.testng.annotations.AfterMethod;
78
import org.testng.annotations.BeforeMethod;
89
import org.testng.annotations.Test;
910

10-
import java.lang.reflect.Field;
11-
12-
import static org.mockito.Mockito.*;
11+
import static org.mockito.Mockito.doNothing;
12+
import static org.mockito.Mockito.reset;
13+
import static org.mockito.Mockito.spy;
1314
import static org.mockito.MockitoAnnotations.initMocks;
1415
import static org.powermock.api.mockito.PowerMockito.whenNew;
1516
import static org.powermock.api.support.membermodification.MemberMatcher.field;
1617
import static org.powermock.api.support.membermodification.MemberMatcher.method;
1718
import static org.powermock.api.support.membermodification.MemberModifier.suppress;
1819
import static org.testng.Assert.assertEquals;
19-
import static org.testng.Assert.assertNotNull;
2020

2121
/**
2222
* Unit tests for {@link JasperserverRestClient}

0 commit comments

Comments
 (0)