Resolved #204 DTO: Setters of Scheduler job dto package return void

Author: TanyaEf

src/main/java/com/jaspersoft/jasperserver/jaxrs/client/dto/common/DeepCloneable.java

@@ -0,0 +1,13 @@
+package com.jaspersoft.jasperserver.jaxrs.client.dto.common;
+
+/**
+ * <p/>
+ * <p/>
+ *
+ * @author tetiana.iefimenko
+ * @version $Id$
+ * @see
+ */
+public interface DeepCloneable<T> {
+    T deepClone();
+}

src/main/java/com/jaspersoft/jasperserver/jaxrs/client/dto/jobs/CalendarTrigger.java

@@ -24,6 +24,8 @@
 import com.jaspersoft.jasperserver.jaxrs.client.dto.jobs.jaxb.adapters.DaysByteXmlAdapter;
 import com.jaspersoft.jasperserver.jaxrs.client.dto.jobs.jaxb.adapters.MonthsByteXmlAdapter;
 
+import java.util.Iterator;
+import java.util.TreeSet;
 import javax.xml.bind.annotation.XmlRootElement;
 import javax.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
 import java.util.SortedSet;
@@ -38,54 +40,82 @@ public class CalendarTrigger extends JobTrigger {
     private String monthDays;
     private SortedSet<Byte> months;
 
+    public CalendarTrigger() {
+        super();
+    }
+
+    public CalendarTrigger(CalendarTrigger other) {
+        super(other);
+        this.minutes = other.minutes;
+        this.hours = other.hours;
+        this.daysType = other.daysType;
+        this.weekDays = new TreeSet<Byte>();
+        Iterator<Byte> iterator = other.weekDays.iterator();
+        while (iterator.hasNext()) {
+            this.weekDays.add(iterator.next());
+        }
+        this.monthDays = other.monthDays;
+        this.months = new TreeSet<Byte>();
+        Iterator<Byte> monthItertor = other.months.iterator();
+        while (monthItertor.hasNext()) {
+            this.months.add(iterator.next());
+        }
+    }
+
     public String getMinutes() {
         return minutes;
     }
 
-    public void setMinutes(String minutes) {
+    public CalendarTrigger setMinutes(String minutes) {
         this.minutes = minutes;
+        return this;
     }
 
     public String getHours() {
         return hours;
     }
 
-    public void setHours(String hours) {
+    public CalendarTrigger setHours(String hours) {
         this.hours = hours;
+        return this;
     }
 
     public String getMonthDays() {
         return monthDays;
     }
 
-    public void setMonthDays(String monthDays) {
+    public CalendarTrigger setMonthDays(String monthDays) {
         this.monthDays = monthDays;
+        return this;
     }
 
     public CalendarDaysType getDaysType() {
         return daysType;
     }
 
-    public void setDaysType(CalendarDaysType daysType) {
+    public CalendarTrigger setDaysType(CalendarDaysType daysType) {
         this.daysType = daysType;
+        return this;
     }
 
     @XmlJavaTypeAdapter(DaysByteXmlAdapter.class)
     public SortedSet<Byte> getWeekDays() {
         return weekDays;
     }
 
-    public void setWeekDays(SortedSet<Byte> weekDays) {
+    public CalendarTrigger setWeekDays(SortedSet<Byte> weekDays) {
         this.weekDays = weekDays;
+        return this;
     }
 
     @XmlJavaTypeAdapter(MonthsByteXmlAdapter.class)
     public SortedSet<Byte> getMonths() {
         return months;
     }
 
-    public void setMonths(SortedSet<Byte> months) {
+    public CalendarTrigger setMonths(SortedSet<Byte> months) {
         this.months = months;
+        return this;
     }
 
     @Override

src/main/java/com/jaspersoft/jasperserver/jaxrs/client/dto/jobs/FtpInfo.java

@@ -22,111 +22,146 @@
 package com.jaspersoft.jasperserver.jaxrs.client.dto.jobs;
 
 
+import java.util.LinkedHashMap;
 import javax.xml.bind.annotation.XmlRootElement;
 import java.util.Map;
 
 @XmlRootElement(name = "outputFTPInfo")
 public class FtpInfo {
 
-    private String userName;
-    private String password;
-    private String folderPath;
-    private String serverName;
-    private FtpType type;
-    private String protocol;
-    private Integer port;
-    private Boolean implicit;
-    private Long pbsz;
-    private String prot;
-    private Map<String, String> propertiesMap;
-
+    protected String userName;
+    protected String password;
+    protected String folderPath;
+    protected String serverName;
+    protected FtpType type;
+    protected String protocol;
+    protected Integer port;
+    protected Boolean implicit;
+    protected Long pbsz;
+    protected String prot;
+    protected Map<String, String> propertiesMap;
+
+    public FtpInfo() {
+    }
+
+    public FtpInfo(FtpInfo other) {
+        this.folderPath = other.folderPath;
+        this.implicit = other.implicit;
+        this.password = other.password;
+        this.pbsz = other.pbsz;
+        this.port = other.port;
+        this.propertiesMap = new LinkedHashMap<String, String>();
+        for (Map.Entry<String, String> entry: other.propertiesMap.entrySet()) {
+            this.propertiesMap.put(entry.getKey(), entry.getValue());
+        }
+        this.prot = other.prot;
+        this.protocol = other.protocol;
+        this.serverName = other.serverName;
+        this.type = other.type;
+        this.userName = other.userName;
+    }
 
     public String getUserName() {
         return userName;
     }
 
-    public void setUserName(String userName) {
+    public FtpInfo setUserName(String userName) {
         this.userName = userName;
+        return this;
+    }
+
+    public Boolean getImplicit() {
+        return implicit;
     }
 
     public String getPassword() {
         return password;
     }
 
-    public void setPassword(String password) {
+    public FtpInfo setPassword(String password) {
         this.password = password;
+        return this;
     }
 
     public String getFolderPath() {
         return folderPath;
     }
 
-    public void setFolderPath(String folderPath) {
+    public FtpInfo setFolderPath(String folderPath) {
         this.folderPath = folderPath;
+        return this;
     }
 
     public String getServerName() {
         return serverName;
     }
 
-    public void setServerName(String serverName) {
+    public FtpInfo setServerName(String serverName) {
         this.serverName = serverName;
+        return this;
     }
 
     public FtpType getType() {
         return type;
     }
 
-    public void setType(FtpType type) {
+    public FtpInfo setType(FtpType type) {
         this.type = type;
+        return this;
     }
 
     public String getProtocol() {
         return protocol;
     }
 
-    public void setProtocol(String protocol) {
+    public FtpInfo setProtocol(String protocol) {
         this.protocol = protocol;
+        return this;
     }
 
     public Integer getPort() {
         return port;
     }
 
-    public void setPort(Integer port) {
+    public FtpInfo setPort(Integer port) {
         this.port = port;
+        return this;
     }
 
     public Boolean isImplicit() {
         return implicit;
     }
 
-    public void setImplicit(Boolean implicit) {
+    public FtpInfo setImplicit(Boolean implicit) {
         this.implicit = implicit;
+        return this;
     }
 
     public Long getPbsz() {
         return pbsz;
     }
 
-    public void setPbsz(Long pbsz) {
+    public FtpInfo setPbsz(Long pbsz) {
         this.pbsz = pbsz;
+        return this;
     }
 
     public String getProt() {
         return prot;
     }
 
-    public void setProt(String prot) {
+    public FtpInfo setProt(String prot) {
         this.prot = prot;
+        return this;
     }
 
     public Map<String, String> getPropertiesMap() {
         return propertiesMap;
     }
 
-    public void setPropertiesMap(Map<String, String> propertiesMap) {
+    public FtpInfo setPropertiesMap(Map<String, String> propertiesMap) {
         this.propertiesMap = propertiesMap;
+        return this;
     }
 
     @Override