Skip to content

Commit 7a2082b

Browse files
author
TanyaEf
committed
Renamed methods in BundlesService.class
1 parent 20156ad commit 7a2082b

File tree

3 files changed

+23
-23
lines changed

3 files changed

+23
-23
lines changed

src/integration-test/java/com/jaspersoft/jasperserver/jaxrs/client/apiadapters/bundles/BundlesServiceIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public void should_return_all_bundles_for_default_locale() {
3434
final JSONObject bundles = session
3535
.bundlesService()
3636
.forLocale(null)
37-
.bundles()
37+
.bundle()
3838
.getEntity();
3939

4040
// Then
@@ -49,7 +49,7 @@ public void should_return_all_bundles_for_specified_locale() {
4949
final JSONObject bundles = session
5050
.bundlesService()
5151
.forLocale("de")
52-
.bundles()
52+
.bundle()
5353
.getEntity();
5454

5555
// Then
@@ -64,7 +64,7 @@ public void should_return__bundle_by_name_for_specified_locale() {
6464
final JSONObject bundle = session
6565
.bundlesService()
6666
.forLocale("de")
67-
.bundles("jasperserver_messages")
67+
.bundle("jasperserver_messages")
6868
.getEntity();
6969

7070
// Then
@@ -79,7 +79,7 @@ public void should_return__bundle_by_name_for_default_locale() {
7979
final JSONObject bundle = session
8080
.bundlesService()
8181
.forLocale(null)
82-
.bundles("jasperserver_messages")
82+
.bundle("jasperserver_messages")
8383
.getEntity();
8484

8585
// Then

src/main/java/com/jaspersoft/jasperserver/jaxrs/client/apiadapters/bundles/BundlesService.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,13 @@
2222
package com.jaspersoft.jasperserver.jaxrs.client.apiadapters.bundles;
2323

2424
import com.jaspersoft.jasperserver.jaxrs.client.apiadapters.AbstractAdapter;
25-
import com.jaspersoft.jasperserver.jaxrs.client.apiadapters.settings.SingleSettingsAdapter;
2625
import com.jaspersoft.jasperserver.jaxrs.client.core.JerseyRequest;
2726
import com.jaspersoft.jasperserver.jaxrs.client.core.SessionStorage;
2827
import com.jaspersoft.jasperserver.jaxrs.client.core.exceptions.handling.DefaultErrorHandler;
2928
import com.jaspersoft.jasperserver.jaxrs.client.core.operationresult.OperationResult;
30-
import org.codehaus.jettison.json.JSONObject;
31-
32-
import javax.ws.rs.core.MediaType;
3329
import java.util.Locale;
30+
import javax.ws.rs.core.MediaType;
31+
import org.codehaus.jettison.json.JSONObject;
3432

3533

3634
public class BundlesService extends AbstractAdapter {
@@ -49,11 +47,11 @@ public BundlesService forLocale(String locale) {
4947
return this;
5048
}
5149

52-
public OperationResult<JSONObject> bundles() {
50+
public OperationResult<JSONObject> bundle() {
5351
return buildBundleRequest("/bundles").addParam("expanded", "true").get();
5452
}
5553

56-
public OperationResult<JSONObject> bundles(String name) {
54+
public OperationResult<JSONObject> bundle(String name) {
5755
return buildBundleRequest("/bundles", name).get();
5856
}
5957

src/test/java/com/jaspersoft/jasperserver/jaxrs/client/apiadapters/bundles/BundlesServiceTest.java

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,30 @@
22

33
import com.jaspersoft.jasperserver.jaxrs.client.apiadapters.serverInfo.ServerInfoService;
44
import com.jaspersoft.jasperserver.jaxrs.client.core.JerseyRequest;
5-
import com.jaspersoft.jasperserver.jaxrs.client.core.RequestBuilder;
65
import com.jaspersoft.jasperserver.jaxrs.client.core.SessionStorage;
76
import com.jaspersoft.jasperserver.jaxrs.client.core.exceptions.handling.DefaultErrorHandler;
87
import com.jaspersoft.jasperserver.jaxrs.client.core.operationresult.OperationResult;
8+
import java.util.Locale;
9+
import javax.ws.rs.core.MediaType;
910
import org.codehaus.jettison.json.JSONObject;
1011
import org.mockito.Mock;
1112
import org.mockito.internal.util.reflection.Whitebox;
12-
import org.powermock.api.mockito.PowerMockito;
1313
import org.powermock.core.classloader.annotations.PrepareForTest;
1414
import org.powermock.modules.testng.PowerMockTestCase;
1515
import org.testng.annotations.BeforeMethod;
1616
import org.testng.annotations.Test;
1717

18-
import javax.ws.rs.core.MediaType;
19-
20-
import java.util.Locale;
21-
22-
import static org.mockito.Matchers.*;
23-
import static org.mockito.Mockito.*;
18+
import static org.mockito.Matchers.any;
19+
import static org.mockito.Matchers.anyString;
20+
import static org.mockito.Matchers.eq;
21+
import static org.mockito.Matchers.isA;
22+
import static org.mockito.Mockito.doReturn;
23+
import static org.mockito.Mockito.never;
24+
import static org.mockito.Mockito.times;
25+
import static org.mockito.Mockito.verify;
26+
import static org.mockito.Mockito.when;
2427
import static org.mockito.MockitoAnnotations.initMocks;
2528
import static org.powermock.api.mockito.PowerMockito.mockStatic;
26-
import static org.powermock.api.mockito.PowerMockito.verifyPrivate;
2729
import static org.powermock.api.mockito.PowerMockito.verifyStatic;
2830
import static org.testng.Assert.assertEquals;
2931
import static org.testng.Assert.assertSame;
@@ -60,7 +62,7 @@ public void should_return_proper_bundles_for_default_locale() throws Exception {
6062
doReturn(requestMock).when(requestMock).setAccept(anyString());
6163
doReturn(operationResultMock).when(requestMock).get();
6264
//when
63-
OperationResult<JSONObject> bundles = service.forLocale(null).bundles();
65+
OperationResult<JSONObject> bundles = service.forLocale(null).bundle();
6466
//then
6567
assertSame(bundles, operationResultMock);
6668
verify(requestMock).setAccept(MediaType.APPLICATION_JSON);
@@ -84,7 +86,7 @@ public void should_return_proper_bundles_for_locale() throws Exception {
8486
doReturn(requestMock).when(requestMock).setAccept(anyString());
8587
doReturn(operationResultMock).when(requestMock).get();
8688
//when
87-
OperationResult<JSONObject> bundles = service.forLocale("de").bundles();
89+
OperationResult<JSONObject> bundles = service.forLocale("de").bundle();
8890
//then
8991
assertSame(bundles, operationResultMock);
9092
verify(requestMock).setAccept(MediaType.APPLICATION_JSON);
@@ -106,7 +108,7 @@ public void should_return_proper_bundles_by_name_for_locale() throws Exception {
106108
doReturn(requestMock).when(requestMock).setAccept(anyString());
107109
doReturn(operationResultMock).when(requestMock).get();
108110
//when
109-
OperationResult<JSONObject> bundles = service.forLocale("de").bundles("jasperserver_messages");
111+
OperationResult<JSONObject> bundles = service.forLocale("de").bundle("jasperserver_messages");
110112
//then
111113
assertSame(bundles, operationResultMock);
112114
verify(requestMock).setAccept(MediaType.APPLICATION_JSON);
@@ -126,7 +128,7 @@ public void should_return_proper_bundles_by_name_for_default_locale() throws Exc
126128
doReturn(requestMock).when(requestMock).setAccept(anyString());
127129
doReturn(operationResultMock).when(requestMock).get();
128130
//when
129-
OperationResult<JSONObject> bundles = service.forLocale(null).bundles("jasperserver_messages");
131+
OperationResult<JSONObject> bundles = service.forLocale(null).bundle("jasperserver_messages");
130132
//then
131133
assertSame(bundles, operationResultMock);
132134
verify(requestMock).setAccept(MediaType.APPLICATION_JSON);

0 commit comments

Comments
 (0)