Remove dispose call for Color

According to the Javadoc on Color:

 * Colors do not need to be disposed, however to maintain compatibility
 * with older code, disposing a Color is not an error.

Author: akurtakov

debug/org.eclipse.debug.examples.ui/src/org/eclipse/debug/examples/ui/pda/DebugUIPlugin.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2005, 2018 IBM Corporation and others.
+ * Copyright (c) 2005, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -16,9 +16,7 @@
 
 import java.net.URL;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.Map;
-import java.util.Map.Entry;
 import java.util.MissingResourceException;
 import java.util.ResourceBundle;
 
@@ -118,11 +116,6 @@ public void stop(BundleContext context) throws Exception {
 		super.stop(context);
 		plugin = null;
 		resourceBundle = null;
-		Iterator<Entry<RGB, Color>> colors = fColors.entrySet().iterator();
-		while (colors.hasNext()) {
-			Entry<RGB, Color> entry = colors.next();
-			entry.getValue().dispose();
-		}
 	}
 
 	/**

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/ColorManager.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2013 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -49,11 +49,6 @@ public Color getColor(RGB rgb) {
 		return color;
 	}
 
-	public void dispose() {
-		for (Color color : fColorTable.values()) {
-			color.dispose();
-		}
-	}
 }
 
 

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2019 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -458,8 +458,6 @@ public void stop(BundleContext context) throws Exception {
 				fContextLaunchingManager.shutdown();
 			}
 
-			ColorManager.getDefault().dispose();
-
 			if (fgPresentation != null) {
 				fgPresentation.dispose();
 			}

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/AsynchronousViewer.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2005, 2013 IBM Corporation and others.
+ * Copyright (c) 2005, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -166,9 +166,6 @@ public synchronized void dispose() {
 			font.dispose();
 		}
 		fFontCache.clear();
-		for (Color color : fColorCache.values()) {
-			color.dispose();
-		}
 		fColorCache.clear();
 
 		if (fModel != null) {

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/breadcrumb/BreadcrumbItemDropDown.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2017 IBM Corporation and others.
+ * Copyright (c) 2008, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -96,7 +96,6 @@ protected void drawCompositeImage(int width, int height) {
 				gc.fillPolygon(new int[] {
 						0, 0, ARROW_SIZE, ARROW_SIZE, 0, ARROW_SIZE * 2 });
 				gc.dispose();
-				triangleColor.dispose();
 
 				ImageData imageData = image.getImageData(zoom);
 				image.dispose();

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/viewers/model/TreeModelLabelProvider.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2006, 2018 IBM Corporation and others.
+ * Copyright (c) 2006, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -242,9 +242,6 @@ public void dispose() {
 			font.dispose();
 		}
 		fFontCache.clear();
-		for (Color color : fColorCache.values()) {
-			color.dispose();
-		}
 		fColorCache.clear();
 		super.dispose();
 	}

debug/org.eclipse.unittest.ui/src/org/eclipse/unittest/internal/ui/UnitTestProgressBar.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2010 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -57,11 +57,6 @@ public void controlResized(ControlEvent e) {
 			}
 		});
 		addPaintListener(this::paint);
-		addDisposeListener(event -> {
-			fFailureColor.dispose();
-			fOKColor.dispose();
-			fStoppedColor.dispose();
-		});
 		Display display = parent.getDisplay();
 		fFailureColor = new Color(display, 159, 63, 63);
 		fOKColor = new Color(display, 95, 191, 95);