https://java.net/jira/browse/JAVAMONEY-77

Replaced create() with of() in builders.
Removed exposure of BuildableCurrencyUnit and DefaultExchangeRate in RI by refactoring builder pattern similar to RI.

Author: atsticks

pom.xml

@@ -28,7 +28,7 @@
 
         <moduleDir>.</moduleDir>
 
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.create.sourceEncoding>UTF-8</project.create.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 
         <jdkVersion>1.8</jdkVersion>
@@ -259,7 +259,7 @@
                     <value>true</value>
                 </property>
             </activation>
-            <build>
+            <create>
                 <pluginManagement>
                     <plugins>
                         <plugin>
@@ -317,7 +317,7 @@
                         </executions>
                     </plugin>
                 </plugins>
-            </build>
+            </create>
         </profile>
 
         <profile>
@@ -328,7 +328,7 @@
                     <value>true</value>
                 </property>
             </activation>
-            <build>
+            <create>
                 <pluginManagement>
                     <plugins>
                         <!-- ======================================================= -->
@@ -374,7 +374,7 @@
                         </executions>
                     </plugin>
                 </plugins>
-            </build>
+            </create>
         </profile>
         <profile>
             <id>cloudbees-deployment</id>
@@ -433,7 +433,7 @@
         </dependency -->
     </dependencies>
 
-    <build>
+    <create>
 
         <defaultGoal>install</defaultGoal>
 
@@ -520,7 +520,7 @@
                         <source>${maven.compile.sourceLevel}</source>
                         <target>${maven.compile.targetLevel}</target>
                         <compilerArgument>-g</compilerArgument>
-                        <encoding>${project.build.sourceEncoding}</encoding>
+                        <encoding>${project.create.sourceEncoding}</encoding>
                     </configuration>
                 </plugin>
                 <plugin>
@@ -801,8 +801,8 @@
 
                     <postProcess>
                         <zip
-                                destfile="${project.build.directory}/${project.artifactId}-${project.version}-docs.zip">
-                            <fileset dir="${project.build.directory}/docs"
+                                destfile="${project.of.directory}/${project.artifactId}-${project.version}-docs.zip">
+                            <fileset dir="${project.of.directory}/docs"
                                      includes="**/*.pdf" />
                         </zip>
                     </postProcess -->
@@ -826,7 +826,7 @@
                 </executions>
             </plugin -->
         </plugins>
-    </build>
+    </create>
 
 
     <reporting>
@@ -852,7 +852,7 @@
                             <keywords>true</keywords>
                             <linksource>true</linksource>
                             <!-- overview>${basedir}/overview.html</overview -->
-                            <source>${project.build.sourceCompilerLevel}</source>
+                            <source>${project.create.sourceCompilerLevel}</source>
                             <!-- stylesheetfile>${basedir}/src/site/css/money-jdoc.css</stylesheetfile -->
                             <verbose>true</verbose>
                             <aggregate>true</aggregate>
@@ -893,7 +893,7 @@
                 <version>2.4</version>
                 <configuration>
                     <aggregate>true</aggregate>
-                    <encoding>${project.build.sourceEncoding}</encoding>
+                    <encoding>${project.create.sourceEncoding}</encoding>
                     <tagListOptions>
                         <tagClasses>
                             <tagClass>
@@ -951,7 +951,7 @@
                     <format>xml</format>
                     <linkXRef>true</linkXRef>
                     <aggregate>true</aggregate>
-                    <sourceEncoding>${project.build.sourceEncoding}</sourceEncoding>
+                    <sourceEncoding>${project.create.sourceEncoding}</sourceEncoding>
                 </configuration>
             </plugin>
             <plugin>

src/main/asciidoc/JavaMoneySpecification.adoc

@@ -1071,7 +1071,7 @@ enum MyFlavor{ // only an example, not part of the API
   SLOW. FAST
 }
 
-MonetaryContext ctx = MonetaryContextBuilder.create()
+MonetaryContext ctx = MonetaryContextBuilder.of()
  .setMaxScale(2)
  .setFixedScale(true)
  .setPrecision(12)
@@ -1107,7 +1107,7 @@ MyMoney money = fact.setCurrency("USD").setNumber(10.50).create();
 .Usage Example for reating an Amount, querying for a +MonetaryAmountFactory+
 -------------------------------------------------------------------------------
 MonetaryAmountFactory<?> fact = MonetaryAmounts.getAmountFactory(
-  MonetaryAmountFactoryQueryBuilder.create().setMaxScale(2).setPrecision(10).build());
+  MonetaryAmountFactoryQueryBuilder.of().setMaxScale(2).setPrecision(10).build());
 MonetaryAmount money = fact.setCurrency("USD").setNumber(10.50).create();
 -------------------------------------------------------------------------------
 
@@ -1216,7 +1216,7 @@ Hereby
 -------------------------------------------------------------------------------
 // Note: Enum Region only serves as an example and not part of the API
 Collection<CurrencyUnit> currencies = MonetaryCurrencies.getCurrencies(
-  CurrencyQueryBuilder.create().setProvider("A", "B").set(Region.EMEA).setInt("contractNr", 12345).build()
+  CurrencyQueryBuilder.of().setProvider("A", "B").set(Region.EMEA).setInt("contractNr", 12345).build()
 );
 -------------------------------------------------------------------------------
 
@@ -1228,7 +1228,7 @@ provider would be implemented and registered one could perform the following que
 -------------------------------------------------------------------------------
 // Note: This is just an example: no historic provider is part of the API or RI currently
 Collection<CurrencyUnit> currencies = MonetaryCurrencies.getCurrencies(
-  CurrencyQueryBuilder.create().set(Locale.GERMANY).setTimestamp(LocalDate.of(1930,1,1)).build()
+  CurrencyQueryBuilder.of().set(Locale.GERMANY).setTimestamp(LocalDate.of(1930,1,1)).build()
 );
 -------------------------------------------------------------------------------
 
@@ -1399,11 +1399,11 @@ default currency rounding (e.g. for +CHF/Swiss Francs+), as follows:
 .Example how a cash rounding could be accessed (not part of the API)
 -------------------------------------------------------------------------------
 MonetaryRounding rounding = MonetaryRoundings.getRounding(
-                RoundingQueryBuilder.create()                         <1>
+                RoundingQueryBuilder.of()                             <1>
                 .setRoundingName("cashRounding")                      <2>
                 .setCurrencyUnit("USD")                               <3>
                 .setTimestamp(temporalAccessor)                       <4>
-                .create());                                           <5>
+                .build());                                            <5>
 -------------------------------------------------------------------------------
 <1> Access a rounding by passing a +RoundingQuery+
 <2> Acquire a specific _named_ rounding.
@@ -1652,13 +1652,13 @@ can be passed to parametrize the +<<CurrencyConversion>>+ or +<<ExchangeRateProv
 [source,java]
 .Usage Sample Create for Currency Conversion using Customized Parameters
 --------------------------------------------------------------------------
-ConversionContext ctx = ConversionContextBuilder.create()
+ConversionContext ctx = ConversionContextBuilder.of()
        .setRateType(RateType.DEFERRED).
        .set("customerID", 1234)
        .set("contractID", "213453-GFDT-02")
        .set(FallbackStragey.PROVIDER)
        .set(amount)
-       .create();
+       .build();
 
 // Access a conversion...
 CurrencyConversion conversion = MonetaryConversions.getConversion("CHF", ctx);
@@ -1814,7 +1814,7 @@ for this we could configure an +AmountFormatContext+ that implements this behavi
 [source,java]
 .Usage Example (continued) Formatting a MonetaryAmount
 --------------------------------------------------------------------------
-AmountFormatQuery query = AmountFormatQueryBuilder.create(new Locale("","INR"))
+AmountFormatQuery query = AmountFormatQueryBuilder.of(new Locale("","INR"))
                                 .set("groupSizes", new int[]{3,2]).build();
 MonetaryAmountFormat format = MonetaryAmountFormats.getAmountFormat(query);
 MonetaryAmountFactory<?> f = MonetaryAmounts.getDefaultAmountFactory();
@@ -1922,12 +1922,12 @@ THe code below illustrates a more complex example:
 [source,java]
 .Advanced setup of a AmountFormatContext
 -------------------------------------------------------------------------------
-AmountFormatContext ctx = new AmountFormatContext.Builder("htmlFormat")  <1>
-                          .setText("title", "MyTitle")                   <2>
-                          .setText("negativeStyle", ".negNumber")        <3>
-                          .setText("positiveStyle", ".posNumber+)        <3>
-                          .setText("styleClass", "styledAmount")         <4>
-                          .create();                                     <5>
+AmountFormatContext ctx = new AmountFormatContextBuilder.of("htmlFormat")  <1>
+                          .setText("title", "MyTitle")                     <2>
+                          .setText("negativeStyle", ".negNumber")          <3>
+                          .setText("positiveStyle", ".posNumber+)          <3>
+                          .setText("styleClass", "styledAmount")           <4>
+                          .build();                                        <5>
 -------------------------------------------------------------------------------
 <1> Access a format with name +htmlFormat+
 <2> Sets the format's display name
@@ -2878,7 +2878,7 @@ When accessing +MonetaryAmountFactory+ instances it is possible to configure the
 .Example Configuring a +MonetaryAmountFactory+, using the RI class +Money+ as example.
 -------------------------------------------------------------------
 MonetaryAmountFactory<Money> fact = MonetaryAmounts.getAmountFactory(
-   MonetaryAmountFactoryQueryBuilder.create(Money.class)
+   MonetaryAmountFactoryQueryBuilder.of(Money.class)
      .set(new MathContext(250, RoundingMode.HALF_EVEN)).build()
 );
 // Creates an instance of Money with the given MathContext
@@ -3121,7 +3121,7 @@ conversion, e.g.:
 [source,java]
 -------------------------------------------------------------------
 MonetaryAmount inCHF =...;
-CurrencyConversion conv = MonetaryConversions.getConversion(ConversionQueryBuilder.create()
+CurrencyConversion conv = MonetaryConversions.getConversion(ConversionQueryBuilder.of()
         .setProviders("CS", "EZB", "IMF")
         .setTermCurrency("EUR")
         .set(MonetaryAmount.class, inCHF, MonetaryAmount.class)

src/main/java/javax/money/AbstractContext.java

@@ -22,12 +22,16 @@
  * extensions os specialities.<p>
  * Superclasses of this class must be final, immutable, serializable and thread-safe.
  */
-public abstract class AbstractContext implements Serializable {
+public abstract class AbstractContext implements Serializable{
 
-    /** Key for storing the target providers to be queried */
+    /**
+     * Key for storing the target providers to be queried
+     */
     public static final String KEY_PROVIDER = "provider";
 
-    /** Key name for the timestamp attribute. */
+    /**
+     * Key name for the timestamp attribute.
+     */
     public static final String KEY_TIMESTAMP = "timestamp";
 
     /**
@@ -374,7 +378,7 @@ public String getProvider(){
     }
 
     /**
-     * Get the current target timestamp of the query in UTC milliseconds.  If not set it tries to create an
+     * Get the current target timestamp of the query in UTC milliseconds.  If not set it tries to of an
      * UTC timestamp from #getTimestamp(). This allows to select historical roundings that were valid in the
      * past. Its implementation specific, to what extend historical roundings are available. By default if this
      * property is not set always current {@link  javax.money.MonetaryRounding} instances are provided.
@@ -393,7 +397,7 @@ public Long getTimestampMillis(){
     }
 
     /**
-     * Get the current target timestamp of the query. If not set it tries to create an Instant from
+     * Get the current target timestamp of the query. If not set it tries to of an Instant from
      * #getTimestampMillis(). This allows to select historical roundings that were valid in the
      * past. Its implementation specific, to what extend historical roundings are available. By default if this
      * property is not set always current {@link  javax.money.MonetaryRounding} instances are provided.
@@ -432,6 +436,7 @@ public int hashCode(){
 
     /**
      * Access all the values present.
+     *
      * @param type the type used.
      * @return
      */

src/main/java/javax/money/AbstractContextBuilder.java

@@ -20,7 +20,7 @@
 
 /**
  * This interface defines the common generic parts of a query. Queries are used to pass complex parameters sets
- * to lookup monetary artifacts, e.g. {@link javax.money.MonetaryAmountFactory},
+ * to lookup monetary artifacts, e.g. {@link MonetaryAmountFactory},
  * {@link javax.money.MonetaryRounding},
  * {@link javax.money.CurrencyUnit}, {@link javax.money.convert.ExchangeRateProvider} and {@link javax.money.convert
  * .CurrencyConversion}.
@@ -270,7 +270,7 @@ public B setProvider(String provider){
      */
     public B setTimestampMillis(long timestamp){
         set(AbstractContext.KEY_TIMESTAMP, timestamp);
-        return (B)this;
+        return (B) this;
     }
 
     /**
@@ -283,10 +283,10 @@ public B setTimestampMillis(long timestamp){
      * @return this instance for chaining
      * @see #setTimestampMillis(long)
      */
-	public B setTimestamp(TemporalAccessor timestamp){
+    public B setTimestamp(TemporalAccessor timestamp){
         Objects.requireNonNull(timestamp);
         set(AbstractContext.KEY_TIMESTAMP, timestamp, TemporalAccessor.class);
-        return (B)this;
+        return (B) this;
     }
 
     /**
@@ -340,7 +340,6 @@ public <T> B set(Object key, T value, Class<? extends T> type){
     }
 
 
-
     /**
      * Creates a new {@link AbstractContext} with the data from this Builder
      * instance.
@@ -354,12 +353,12 @@ public <T> B set(Object key, T value, Class<? extends T> type){
      *
      * @see Object#toString()
      */
-    
-	@Override
+
+    @Override
     public String toString(){
         StringBuilder attrsBuilder = new StringBuilder();
         for(Map.Entry<Class,Map<Object,Object>> en : ((Map<Class,Map<Object,Object>>) this.data).entrySet()){
-        	
+
             Map<Object,Object> sortedMap = new TreeMap<>(Comparator.comparing(Object::toString));
             sortedMap.putAll(en.getValue());
             for(Map.Entry<Object,Object> entry : sortedMap.entrySet()){

src/main/java/javax/money/AbstractQuery.java

@@ -71,7 +71,7 @@ public Class<?> getTargetType(){
     }
 
     /**
-     * Get the current timestamp of the context in UTC milliseconds.  If not set it tries to create an
+     * Get the current timestamp of the context in UTC milliseconds.  If not set it tries to of an
      * UTC timestamp from #getTimestamp().
      *
      * @return the timestamp in millis, or null.
@@ -88,7 +88,7 @@ public Long getTimestampMillis(){
     }
 
     /**
-     * Get the current timestamp. If not set it tries to create an Instant from #getTimestampMillis().
+     * Get the current timestamp. If not set it tries to of an Instant from #getTimestampMillis().
      *
      * @return the current timestamp, or null.
      */