Use collection initialization constructor

We have several cases where we use a Collection constructor followed by and .addAll().
This code can be simplified by calling a collection initialization constructor.

This also fixes one of your @SuppressWarnings users.

Author: marschall

src/main/java/javax/money/DefaultMonetaryCurrenciesSingletonSpi.java

@@ -60,8 +60,7 @@ public Set<CurrencyUnit> getCurrencies(CurrencyQuery query) {
      */
     @Override
     public List<String> getDefaultProviderChain() {
-        List<String> list = new ArrayList<>();
-        list.addAll(getProviderNames());
+        List<String> list = new ArrayList<>(getProviderNames());
         Collections.sort(list);
         return list;
     }

src/main/java/javax/money/DefaultMonetaryRoundingsSingletonSpi.java

@@ -124,8 +124,7 @@ public Set<String> getProviderNames() {
      */
     @Override
     public List<String> getDefaultProviderChain() {
-        List<String> result = new ArrayList<>();
-        result.addAll(Monetary.getRoundingProviderNames());
+        List<String> result = new ArrayList<>(Monetary.getRoundingProviderNames());
         Collections.sort(result);
         return result;
     }

src/main/java/javax/money/convert/ProviderContextBuilder.java

@@ -55,8 +55,7 @@ private ProviderContextBuilder(String provider, Collection<RateType> rateTypes)
             throw new IllegalArgumentException("At least one RateType is required.");
         }
         setProviderName(provider);
-        Set<RateType> rts = new HashSet<>();
-        rts.addAll(rateTypes);
+        Set<RateType> rts = new HashSet<>(rateTypes);
         set("rateTypes", rts);
     }
 
@@ -69,8 +68,7 @@ private ProviderContextBuilder(String provider, Collection<RateType> rateTypes)
      */
     private ProviderContextBuilder(ProviderContext context) {
         importContext(context);
-        Set<RateType> rts = new HashSet<>();
-        rts.addAll(context.getRateTypes());
+        Set<RateType> rts = new HashSet<>(context.getRateTypes());
         set(ProviderContext.KEY_RATE_TYPES, rts);
     }
 
@@ -92,14 +90,12 @@ public ProviderContextBuilder setRateTypes(RateType... rateTypes) {
      * @return this, for chaining.
      * @throws IllegalArgumentException when not at least one {@link RateType} is provided.
      */
-    @SuppressWarnings({"unchecked", "rawtypes"})
     public ProviderContextBuilder setRateTypes(Collection<RateType> rateTypes) {
         Objects.requireNonNull(rateTypes);
         if (rateTypes.isEmpty()) {
             throw new IllegalArgumentException("At least one RateType is required.");
         }
-        Set rtSet = new HashSet<>();
-        rtSet.addAll(rateTypes);
+        Set<RateType> rtSet = new HashSet<>(rateTypes);
         set(ProviderContext.KEY_RATE_TYPES, rtSet);
         return this;
     }

src/main/java/javax/money/format/MonetaryFormats.java

@@ -236,8 +236,7 @@ public Set<String> getProviderNames() {
          */
         @Override
         public List<String> getDefaultProviderChain() {
-            List<String> list = new ArrayList<>();
-            list.addAll(getProviderNames());
+            List<String> list = new ArrayList<>(getProviderNames());
             Collections.sort(list);
             return list;
         }

src/test/java/javax/money/format/AmountFormatQueryTest.java

@@ -64,8 +64,7 @@ public void testEquals(){
         List<AmountFormatContext> contexts = new ArrayList<>();
         contexts.add(AmountFormatContextBuilder.of(Locale.ENGLISH).build());
         contexts.add(AmountFormatContextBuilder.of(Locale.GERMAN).build());
-        Set<AmountFormatContext> checkContexts = new HashSet<>();
-        checkContexts.addAll(contexts);
+        Set<AmountFormatContext> checkContexts = new HashSet<>(contexts);
         // Check we have 5 distinct hash codes...
         assertTrue(checkContexts.size() == 2);
     }