Quality fixes, added Javadocs.

Author: atsticks

pom.xml

@@ -220,7 +220,6 @@
                             </docletArtifact>
                             <show>private</show>
                             <additionalparam>
-                                -Xdoclint:none
                                 -inferrel -inferdep -quiet -hide java.*
                                 -collpackages java.util.*
                                 -postfixpackage -nodefontname Tahoma

src/main/java/org/javamoney/moneta/internal/convert/AbstractECBRateProvider.java

@@ -17,7 +17,6 @@
 
 import java.io.InputStream;
 import java.math.MathContext;
-import java.net.MalformedURLException;
 import java.util.Calendar;
 import java.util.GregorianCalendar;
 import java.util.Map;
@@ -66,7 +65,7 @@ abstract class AbstractECBRateProvider extends AbstractRateProvider implements
      */
     private final SAXParserFactory saxParserFactory = SAXParserFactory.newInstance();
 
-    public AbstractECBRateProvider(ProviderContext context) throws MalformedURLException {
+    public AbstractECBRateProvider(ProviderContext context) {
         super(context);
         saxParserFactory.setNamespaceAware(false);
         saxParserFactory.setValidating(false);

src/main/java/org/javamoney/moneta/internal/convert/IMFRateProvider.java

@@ -19,7 +19,6 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
-import java.net.MalformedURLException;
 import java.text.DecimalFormat;
 import java.text.NumberFormat;
 import java.text.ParseException;
@@ -110,7 +109,7 @@ public class IMFRateProvider extends AbstractRateProvider implements LoaderListe
         currenciesByName.put("Bolivar Fuerte", Monetary.getCurrency("VEF"));
     }
 
-    public IMFRateProvider() throws MalformedURLException {
+    public IMFRateProvider() {
         super(CONTEXT);
         LoaderService loader = Bootstrap.getService(LoaderService.class);
         loader.addLoaderListener(this, DATA_ID);

src/main/java/org/javamoney/moneta/internal/convert/IdentityRateProvider.java

@@ -16,7 +16,6 @@
 package org.javamoney.moneta.internal.convert;
 
 import java.math.BigDecimal;
-import java.net.MalformedURLException;
 
 import javax.money.convert.ConversionQuery;
 import javax.money.convert.ExchangeRate;
@@ -44,10 +43,8 @@ public class IdentityRateProvider extends AbstractRateProvider {
 
     /**
      * Constructor, also loads initial data.
-     *
-     * @throws java.net.MalformedURLException
      */
-    public IdentityRateProvider() throws MalformedURLException {
+    public IdentityRateProvider(){
         super(CONTEXT);
     }
 

src/main/java/org/javamoney/moneta/internal/format/DefaultMonetaryAmountFormat.java

@@ -86,7 +86,7 @@ private void initPattern(String pattern, List<FormatToken> tokens,
         if (index > 0) { // currency placement after, between
             String p1 = pattern.substring(0, index);
             String p2 = pattern.substring(index + 1);
-            if (isLiteralPattern(p1, style)) {
+            if (isLiteralPattern(p1)) {
                 tokens.add(new LiteralToken(p1));
                 tokens.add(new CurrencyToken(style.get(CurrencyStyle.class), style.
                         get(Locale.class)));
@@ -95,7 +95,7 @@ private void initPattern(String pattern, List<FormatToken> tokens,
                 tokens.add(new CurrencyToken(style.get(CurrencyStyle.class), style.get(Locale.class)));
             }
             if (!p2.isEmpty()) {
-                if (isLiteralPattern(p2, style)) {
+                if (isLiteralPattern(p2)) {
                     tokens.add(new LiteralToken(p2));
                 } else {
                     tokens.add(new AmountNumberToken(style, p2));
@@ -110,8 +110,7 @@ private void initPattern(String pattern, List<FormatToken> tokens,
         }
     }
 
-    private boolean isLiteralPattern(String pattern, AmountFormatContext style) {
-        // TODO implement better here
+    private boolean isLiteralPattern(String pattern) {
         return !(pattern.contains("#") || pattern.contains("0"));
     }
 

src/main/java/org/javamoney/moneta/internal/loader/LoadableResource.java

@@ -85,11 +85,11 @@ public class LoadableResource {
     /**
      * The required update policy for this resource.
      */
-    private LoaderService.UpdatePolicy updatePolicy;
+    private final LoaderService.UpdatePolicy updatePolicy;
     /**
      * The resource configuration.
      */
-    private Map<String, String> properties;
+    private final Map<String, String> properties;
 
 
     /**
@@ -402,9 +402,8 @@ public void unload() {
      * load counter.
      *
      * @return true on success.
-     * @throws IOException
      */
-    public boolean resetToFallback() throws IOException {
+    public boolean resetToFallback(){
         if (loadFallback()) {
             loadCount.set(0);
             return true;
@@ -426,7 +425,7 @@ public String toString() {
      */
     private final class WrappedInputStream extends InputStream {
 
-        private InputStream wrapped;
+        private final InputStream wrapped;
 
         public WrappedInputStream(InputStream wrapped) {
             this.wrapped = wrapped;