Fixed tests and bugs.

Author: atsticks

src/main/java/org/javamoney/moneta/BuildableCurrencyUnit.java

@@ -31,8 +31,8 @@ final class BuildableCurrencyUnit implements CurrencyUnit, Comparable<CurrencyUn
     /**
      * serialVersionUID.
      */
-	private static final long serialVersionUID = -2389580389919492220L;
-	/**
+    private static final long serialVersionUID = -2389580389919492220L;
+    /**
      * The unique currency code.
      */
     private String currencyCode;
@@ -54,15 +54,15 @@ final class BuildableCurrencyUnit implements CurrencyUnit, Comparable<CurrencyUn
      *
      * @param builder the builder, never null.
      */
-    BuildableCurrencyUnit(CurrencyUnitBuilder builder){
+    BuildableCurrencyUnit(CurrencyUnitBuilder builder) {
         Objects.requireNonNull(builder.currencyCode, "currencyCode required");
-        if(builder.numericCode < -1){
+        if (builder.numericCode < -1) {
             throw new MonetaryException("numericCode must be >= -1");
         }
-        if(builder.defaultFractionDigits < 0){
+        if (builder.defaultFractionDigits < 0) {
             throw new MonetaryException("defaultFractionDigits must be >= 0");
         }
-        if(builder.currencyContext == null){
+        if (builder.currencyContext == null) {
             throw new MonetaryException("currencyContext must be != null");
         }
         this.defaultFractionDigits = builder.defaultFractionDigits;
@@ -72,61 +72,61 @@ final class BuildableCurrencyUnit implements CurrencyUnit, Comparable<CurrencyUn
     }
 
     @Override
-    public String getCurrencyCode(){
+    public String getCurrencyCode() {
         return currencyCode;
     }
 
     @Override
-    public int getNumericCode(){
+    public int getNumericCode() {
         return numericCode;
     }
 
     @Override
-    public int getDefaultFractionDigits(){
+    public int getDefaultFractionDigits() {
         return defaultFractionDigits;
     }
 
     @Override
-    public CurrencyContext getCurrencyContext(){
+    public CurrencyContext getCurrencyContext() {
         return currencyContext;
     }
 
     @Override
-    public int compareTo(CurrencyUnit o){
-    	Objects.requireNonNull(o);
+    public int compareTo(CurrencyUnit o) {
+        Objects.requireNonNull(o);
         return this.currencyCode.compareTo(o.getCurrencyCode());
     }
 
     /* (non-Javadoc)
      * @see java.lang.Object#hashCode()
      */
     @Override
-    public int hashCode(){
+    public int hashCode() {
         return Objects.hashCode(currencyCode);
     }
 
     /* (non-Javadoc)
      * @see java.lang.Object#equals(java.lang.Object)
      */
     @Override
-	public boolean equals(Object obj) {
-    	if (obj == this) {
+    public boolean equals(Object obj) {
+        if (obj == this) {
             return true;
         }
-    	if (obj instanceof BuildableCurrencyUnit) {
-    		 BuildableCurrencyUnit other = (BuildableCurrencyUnit) obj;
-    		 return Objects.equals(currencyCode, other.currencyCode);
-    	}
-    	return false;
+        if (obj instanceof BuildableCurrencyUnit) {
+            BuildableCurrencyUnit other = (BuildableCurrencyUnit) obj;
+            return Objects.equals(currencyCode, other.currencyCode);
+        }
+        return false;
     }
 
     /* (non-Javadoc)
      * @see java.lang.Object#toString()
      */
     @Override
-    public String toString(){
+    public String toString() {
         return "BuildableCurrencyUnit(currencyCode=" + currencyCode + ", numericCode=" + numericCode +
-                ", defaultFractionDigits=" + defaultFractionDigits + ", context="+this.currencyContext+ ')';
+                ", defaultFractionDigits=" + defaultFractionDigits + ", context=" + this.currencyContext + ')';
     }
 
 

src/main/java/org/javamoney/moneta/DefaultExchangeRate.java

@@ -81,7 +81,7 @@
  * href="https://en.wikipedia.org/wiki/Exchange_rate#Quotations">Wikipedia:
  * Exchange Rate (Quotations)</a>
  */
-class DefaultExchangeRate implements ExchangeRate, Serializable, Comparable<ExchangeRate>{
+class DefaultExchangeRate implements ExchangeRate, Serializable, Comparable<ExchangeRate> {
 
     /**
      * serialVersionUID.
@@ -115,7 +115,7 @@ class DefaultExchangeRate implements ExchangeRate, Serializable, Comparable<Exch
      *
      * @param builder The Builder, never {@code null}.
      */
-    DefaultExchangeRate(ExchangeRateBuilder builder){
+    DefaultExchangeRate(ExchangeRateBuilder builder) {
         Objects.requireNonNull(builder.base, "base may not be null.");
         Objects.requireNonNull(builder.term, "term may not be null.");
         Objects.requireNonNull(builder.factor, "factor may not be null.");
@@ -134,13 +134,13 @@ class DefaultExchangeRate implements ExchangeRate, Serializable, Comparable<Exch
      *
      * @param chain the chain to set.
      */
-    private void setExchangeRateChain(List<ExchangeRate> chain){
+    private void setExchangeRateChain(List<ExchangeRate> chain) {
         this.chain.clear();
-        if(Objects.isNull(chain) || chain.isEmpty()){
+        if (Objects.isNull(chain) || chain.isEmpty()) {
             this.chain.add(this);
-        }else{
-            for(ExchangeRate rate : chain){
-                if(Objects.isNull(rate)){
+        } else {
+            for (ExchangeRate rate : chain) {
+                if (Objects.isNull(rate)) {
                     throw new IllegalArgumentException("Rate Chain element can not be null.");
                 }
             }
@@ -153,7 +153,7 @@ private void setExchangeRateChain(List<ExchangeRate> chain){
      *
      * @return the conversion context, never null.
      */
-    public final ConversionContext getConversionContext(){
+    public final ConversionContext getConversionContext() {
         return this.conversionContext;
     }
 
@@ -162,7 +162,7 @@ public final ConversionContext getConversionContext(){
      *
      * @return the base {@link javax.money.CurrencyUnit}.
      */
-    public final CurrencyUnit getBaseCurrency(){
+    public final CurrencyUnit getBaseCurrency() {
         return this.base;
     }
 
@@ -171,7 +171,7 @@ public final CurrencyUnit getBaseCurrency(){
      *
      * @return the term {@link javax.money.CurrencyUnit}.
      */
-    public final CurrencyUnit getCurrency(){
+    public final CurrencyUnit getCurrency() {
         return this.term;
     }
 
@@ -180,7 +180,7 @@ public final CurrencyUnit getCurrency(){
      *
      * @return the bid factor for this exchange rate, or {@code null}.
      */
-    public final NumberValue getFactor(){
+    public final NumberValue getFactor() {
         return this.factor;
     }
 
@@ -191,7 +191,7 @@ public final NumberValue getFactor(){
      * several instances. For a direct exchange rate, this equals to
      * <code>new ExchangeRate[]{this}</code>.
      */
-    public final List<ExchangeRate> getExchangeRateChain(){
+    public final List<ExchangeRate> getExchangeRateChain() {
         return this.chain;
     }
 
@@ -207,7 +207,7 @@ public final List<ExchangeRate> getExchangeRateChain(){
      *
      * @return true, if the exchange rate is derived.
      */
-    public final boolean isDerived(){
+    public final boolean isDerived() {
         return this.chain.size() > 1;
     }
 
@@ -217,13 +217,13 @@ public final boolean isDerived(){
      * @see java.lang.Comparable#compareTo(java.lang.Object)
      */
     @Override
-    public int compareTo(ExchangeRate o){
+    public int compareTo(ExchangeRate o) {
         Objects.requireNonNull(o);
         int compare = this.getBaseCurrency().getCurrencyCode().compareTo(o.getBaseCurrency().getCurrencyCode());
-        if(compare == 0){
+        if (compare == 0) {
             compare = this.getCurrency().getCurrencyCode().compareTo(o.getCurrency().getCurrencyCode());
         }
-        if(compare == 0){
+        if (compare == 0) {
             compare = this.getConversionContext().getProvider().compareTo(o.getConversionContext().getProvider());
         }
         return compare;
@@ -235,7 +235,7 @@ public int compareTo(ExchangeRate o){
      * @see java.lang.Object#toString()
      */
     @Override
-    public String toString(){
+    public String toString() {
         return "ExchangeRate [base=" + base + ", factor=" + factor + ", conversionContext=" + conversionContext + ']';
     }
 
@@ -245,7 +245,7 @@ public String toString(){
      * @see java.lang.Object#hashCode()
      */
     @Override
-    public int hashCode(){
+    public int hashCode() {
         return Objects.hash(base, conversionContext, factor, term, chain);
     }
 
@@ -255,11 +255,11 @@ public int hashCode(){
      * @see java.lang.Object#equals(java.lang.Object)
      */
     @Override
-    public boolean equals(Object obj){
-        if(obj == this){
+    public boolean equals(Object obj) {
+        if (obj == this) {
             return true;
         }
-        if(obj instanceof DefaultExchangeRate){
+        if (obj instanceof DefaultExchangeRate) {
             DefaultExchangeRate other = (DefaultExchangeRate) obj;
             return Objects.equals(base, other.base) && Objects.equals(chain, other.chain) &&
                     Objects.equals(conversionContext, other.conversionContext) &&
@@ -273,7 +273,7 @@ public boolean equals(Object obj){
      *
      * @return a new {@link ExchangeRateBuilder}, never {@code null}.
      */
-    public ExchangeRateBuilder toBuilder(){
+    public ExchangeRateBuilder toBuilder() {
         return new ExchangeRateBuilder(getConversionContext()).setBase(getBaseCurrency()).setTerm(getCurrency())
                 .setFactor(getFactor()).setRateChain(getExchangeRateChain());
     }

src/main/java/org/javamoney/moneta/FastMoney.java

@@ -364,7 +364,7 @@ public FastMoney multiply(Number multiplicand) {
         if (isOne(multiplicand)) {
             return this;
         }
-        return new FastMoney(Math.multiplyExact(this.number, getInternalNumber(multiplicand, false)),
+        return new FastMoney(Math.multiplyExact(this.number, getInternalNumber(multiplicand, false)) / 100000L,
                 getCurrency());
     }