Deprecate support for concurrentBuild in Pipeline jobs

Author: basil

docs/Home.md

@@ -42,6 +42,8 @@ Browse the Jenkins issue tracker to see any [open issues](https://issues.jenkins
     ([JENKINS-51202](https://issues.jenkins-ci.org/browse/JENKINS-51202))
   * Fixed [[Dynamic DSL]] problem
     ([JENKINS-57817](https://issues.jenkins-ci.org/browse/JENKINS-57817))
+  * Deprecated `concurrentBuild` method in `pipelineJob` context, see [Migration](Migration#migrating-to-175)
+    ([JENKINS-53775](https://issues.jenkins-ci.org/browse/JENKINS-53775))
 * 1.74 (May 01 2019)
   * Fixed [Configuration as Code](https://github.com/jenkinsci/configuration-as-code-plugin/) extension
     ([JENKINS-57218](https://issues.jenkins-ci.org/browse/JENKINS-57218))

docs/Migration.md

@@ -24,6 +24,41 @@ multibranchPipelineJob('example') {
 }
 ```
 
+### Pipeline: Job Plugin
+
+The `concurrentBuild` field was deprecated and replaced by
+`DisableConcurrentBuildsJobProperty` in
+[jenkinsci/workflow-job-plugin#8](https://github.com/jenkinsci/workflow-job-plugin/pull/8),
+which was released in Pipeline: Job 2.4. Use of this deprecated field causes
+[JENKINS-53775](https://issues.jenkins-ci.org/browse/JENKINS-53775) and should
+be replaced with the [[Dynamic DSL]].
+
+#### Disabling concurrent Pipeline builds
+
+DSL prior to 1.75
+```groovy
+concurrentBuild false
+```
+
+DSL since 1.75
+```groovy
+properties {
+    disableConcurrentBuilds()
+}
+```
+
+#### Enabling concurrent Pipeline builds
+
+DSL prior to 1.75
+```groovy
+concurrentBuild true
+```
+
+DSL since 1.75
+
+Simply delete any usages of `concurrentBuild true`. Concurrent builds are
+enabled for Pipeline jobs by default.
+
 ## Migrating to 1.72
 
 ### CloudBees Folders Plugin

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Job.groovy

@@ -224,18 +224,6 @@ abstract class Job extends Item {
         }
     }
 
-    /**
-     * Allows Jenkins to schedule and execute multiple builds concurrently.
-     *
-     * @since 1.21
-     */
-    void concurrentBuild(boolean allowConcurrentBuild = true) {
-        configure { Node project ->
-            Node node = methodMissing('concurrentBuild', allowConcurrentBuild)
-            project / node
-        }
-    }
-
     /**
      * Compresses the log file after build completion.
      *

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Project.groovy

@@ -142,6 +142,18 @@ abstract class Project extends Job {
         }
     }
 
+    /**
+     * Allows Jenkins to schedule and execute multiple builds concurrently.
+     *
+     * @since 1.21
+     */
+    void concurrentBuild(boolean allowConcurrentBuild = true) {
+        configure { Node project ->
+            Node node = methodMissing('concurrentBuild', allowConcurrentBuild)
+            project / node
+        }
+    }
+
     /**
      * Adds batch tasks that are not regularly executed to projects, such as releases, integration, archiving.
      * Can be called multiple times to add more batch tasks.

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/WorkflowJob.groovy

@@ -26,4 +26,12 @@ class WorkflowJob extends Job {
             project << context.definitionNode
         }
     }
+
+    @Deprecated
+    void concurrentBuild(boolean allowConcurrentBuild = true) {
+        configure { Node project ->
+            Node node = methodMissing('concurrentBuild', allowConcurrentBuild)
+            project / node
+        }
+    }
 }