Merge pull request #1193 from daspilker/JENKINS-44142

[JENKINS-44142] documentation of pitfalls

Author: daspilker

docs/Home.md

@@ -33,6 +33,8 @@ Browse the Jenkins issue tracker to see any [open issues](https://issues.jenkins
 
 ## Release Notes
 * 1.76 (unreleased)
+  * added documentation for pitfalls when using multiple Job DSL build steps in a single job
+    ([JENKINS-44142](https://issues.jenkins-ci.org/browse/JENKINS-44142))
 * 1.75 (August 12 2019)
   * Added documentation about mandatory identifier in multi-branch Pipeline job branch sources, the identifier will no
     longer be generated and must be set to a constant and unique value, see [Migration](Migration#migrating-to-175)

docs/User-Power-Moves.md

@@ -238,3 +238,8 @@ Options:
 * `sandbox`: optional, defaults to `false`, if `false` the DSL script needs to be approved by an administrator; set to
              `true` to run the DSL scripts in a sandbox with limited abilities (see [[Script Security]]); this option
               will be ignored when script security for Job DSL is disabled on the "Configure Global Security" page
+
+> ⚠ **Note**: when using multiple Job DSL build steps in a single pipeline, set `removedJobAction`, `removedViewAction`
+> or `removedConfigFilesAction` to `DELETE` (or `DISABLE`) only for the last Job DSL build step. Otherwise jobs, views
+> or config files may be deleted and re-created (or disabled and re-enabled) and you may loose the job history of
+> generated jobs. See [JENKINS-44142](https://issues.jenkins-ci.org/browse/JENKINS-44142) for details.

job-dsl-plugin/src/main/resources/javaposse/jobdsl/plugin/ExecuteDslScripts/help-removedConfigFilesAction.html

@@ -0,0 +1,9 @@
+<div>
+    Specifies what to do when previously generated config files are not referenced anymore.
+
+    <p>
+        <b>Note:</b> when using multiple Job DSL build steps in a single job, set this to "Delete" only for the last Job
+        DSL build step. Otherwise config files may be deleted and re-created. See
+        <a href="https://issues.jenkins-ci.org/browse/JENKINS-44142">JENKINS-44142</a> for details.
+    </p>
+</div>

job-dsl-plugin/src/main/resources/javaposse/jobdsl/plugin/ExecuteDslScripts/help-removedJobAction.html

@@ -1,3 +1,10 @@
 <div>
     Specifies what to do when a previously generated job is not referenced anymore.
+
+    <p>
+        <b>Note:</b> when using multiple Job DSL build steps in a single job, set this to "Delete" or "Disable" only for
+        the last Job DSL build step. Otherwise jobs will be deleted and re-created or disabled and re-enabled and you
+        may loose the job history of generated jobs. See
+        <a href="https://issues.jenkins-ci.org/browse/JENKINS-44142">JENKINS-44142</a> for details.
+    </p>
 </div>

job-dsl-plugin/src/main/resources/javaposse/jobdsl/plugin/ExecuteDslScripts/help-removedViewAction.html

@@ -1,3 +1,9 @@
 <div>
     Specifies what to do when a previously generated view is not referenced anymore.
+
+    <p>
+        <b>Note:</b> when using multiple Job DSL build steps in a single job, set this to "Delete" only for the last Job
+        DSL build step. Otherwise views may be deleted and re-created. See
+        <a href="https://issues.jenkins-ci.org/browse/JENKINS-44142">JENKINS-44142</a> for details.
+    </p>
 </div>