removed anything that has been deprecated in 1.26

Author: daspilker

docs/Home.md

@@ -37,6 +37,7 @@ Have a look at the [Jenkins Job DSL Gradle example](https://github.com/sheehan/j
  * The enum argument of `localRepository` for the Maven job and context has changed, see [[Migration]]
  * Support for the older versions of the [Multijob Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Multijob+Plugin) is deprecated, see [[Migration]]
  * The views closure of the nested view type has been changed, see [[Migration]]
+ * Removed anything that has been deprecated in 1.26, see [[Migration#migrating-to-126]]
 * 1.30 (March 08 2015)
  * Added support for [Custom Tools Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Custom+Tools+Plugin)
  * Added support for [Flaky Test Handler Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Flaky+Test+Handler+Plugin)

docs/Migration.md

@@ -188,8 +188,6 @@ job {
 }
 ```
 
-## Migrating to 1.29
-
 ### Build Timeout
 
 The `javaposse.jobdsl.dsl.helpers.wrapper.WrapperContext.Timeout` enum has been [[deprecated|Deprecation-Policy]]

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContext.groovy

@@ -184,24 +184,6 @@ class PublisherContext implements Context {
         }
     }
 
-    void archiveJunit(String glob, boolean retainLongStdout, boolean allowClaimingOfFailedTests = false,
-                     boolean publishTestAttachments = false) {
-        jobManagement.logDeprecationWarning()
-        archiveJunit(glob) {
-            if (retainLongStdout) {
-                delegate.retainLongStdout()
-            }
-            testDataPublishers {
-                if (allowClaimingOfFailedTests) {
-                    delegate.allowClaimingOfFailedTests()
-                }
-                if (publishTestAttachments) {
-                    delegate.publishTestAttachments()
-                }
-            }
-        }
-    }
-
     /**
      * <xunit>
      *     <types>

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/GerritContext.groovy

@@ -3,17 +3,12 @@ package javaposse.jobdsl.dsl.helpers.triggers
 import javaposse.jobdsl.dsl.Context
 import javaposse.jobdsl.dsl.ContextHelper
 import javaposse.jobdsl.dsl.DslContext
-import javaposse.jobdsl.dsl.JobManagement
 
 class GerritContext implements Context {
-    GerritEventContext eventContext
+    GerritEventContext eventContext = new GerritEventContext()
     Closure configureClosure
     List projects = []
 
-    GerritContext(JobManagement jobManagement) {
-        this.eventContext = new GerritEventContext(jobManagement)
-    }
-
     Integer startedCodeReview = null
     Integer startedVerified = null
 

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/GerritEventContext.groovy

@@ -1,16 +1,10 @@
 package javaposse.jobdsl.dsl.helpers.triggers
 
 import javaposse.jobdsl.dsl.Context
-import javaposse.jobdsl.dsl.JobManagement
 
 class GerritEventContext implements Context {
-    private final JobManagement jobManagement
     final List<String> eventShortNames = []
 
-    GerritEventContext(JobManagement jobManagement) {
-        this.jobManagement = jobManagement
-    }
-
     void changeAbandoned() {
         eventShortNames << 'ChangeAbandoned'
     }
@@ -38,9 +32,4 @@ class GerritEventContext implements Context {
     void refUpdated() {
         eventShortNames << 'RefUpdated'
     }
-
-    void propertyMissing(String shortName) {
-        jobManagement.logDeprecationWarning()
-        eventShortNames << shortName
-    }
 }

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/triggers/TriggerContext.groovy

@@ -197,7 +197,7 @@ class TriggerContext implements Context {
      */
     void gerrit(@DslContext(GerritContext) Closure contextClosure = null) {
         // See what they set up in the contextClosure before generating xml
-        GerritContext gerritContext = new GerritContext(jobManagement)
+        GerritContext gerritContext = new GerritContext()
         ContextHelper.executeInContext(contextClosure, gerritContext)
 
         NodeBuilder nodeBuilder = new NodeBuilder()

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/wrapper/WrapperContext.groovy

@@ -302,13 +302,6 @@ class WrapperContext implements Context {
         }
     }
 
-    void xvnc(boolean takeScreenshotAtEndOfBuild) {
-        jobManagement.logDeprecationWarning()
-        xvnc {
-            takeScreenshot(takeScreenshotAtEndOfBuild)
-        }
-    }
-
     /**
      * <org.jenkinsci.plugins.xvfb.XvfbBuildWrapper>
      *     <installationName>xvfb</installationName>

job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/publisher/PublisherContextSpec.groovy

@@ -179,22 +179,6 @@ class PublisherContextSpec extends Specification {
         archiveNode.allowEmptyArchive.isEmpty()
     }
 
-    def 'call deprecated junit archive with all args'() {
-        when:
-        context.archiveJunit('include/*', true, true, true)
-
-        then:
-        with(context.publisherNodes[0]) {
-            name() == 'hudson.tasks.junit.JUnitResultArchiver'
-            children().size() == 3
-            testResults[0].value() == 'include/*'
-            keepLongStdio[0].value() == true
-            testDataPublishers[0].children().size() == 2
-            testDataPublishers[0].'hudson.plugins.claim.ClaimTestDataPublisher'[0] != null
-            testDataPublishers[0].'hudson.plugins.junitattachments.AttachmentPublisher'[0] != null
-        }
-    }
-
     def 'call junit archive with all args'() {
         when:
         context.archiveJunit('include/*') {

job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/triggers/TriggerContextSpec.groovy

@@ -389,8 +389,8 @@ class TriggerContextSpec extends Specification {
         when:
         context.gerrit {
             events {
-                ChangeMerged
-                DraftPublished
+                changeMerged()
+                draftPublished()
             }
             project('reg_exp:myProject', ['ant:feature-branch', 'plain:origin/refs/mybranch']) // full access
             project('test-project', '**') // simplified
@@ -452,34 +452,12 @@ class TriggerContextSpec extends Specification {
         ]
     }
 
-    def 'call gerrit trigger with deprecated events'(String event) {
-        when:
-        context.gerrit {
-            events {
-                delegate."${event}"
-            }
-        }
-
-        then:
-        with(context.triggerNodes[0].triggerOnEvents[0]) {
-            children().size() == 1
-            children()[0].name() ==
-                    "com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.Plugin${event}Event"
-        }
-
-        where:
-        event << [
-                'ChangeAbandoned', 'ChangeMerged', 'ChangeRestored', 'CommentAdded', 'DraftPublished',
-                'PatchsetCreated', 'RefUpdated'
-        ]
-    }
-
     def 'call gerrit trigger and verify build status value settings'() {
         when:
         context.gerrit {
             events {
-                PatchsetCreated
-                DraftPublished
+                patchsetCreated()
+                draftPublished()
             }
 
             project('test-project', '**')
@@ -500,8 +478,8 @@ class TriggerContextSpec extends Specification {
         when:
         context.gerrit {
             events {
-                PatchsetCreated
-                DraftPublished
+                patchsetCreated()
+                draftPublished()
             }
 
             project('test-project', '**')

job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/wrapper/WrapperContextSpec.groovy

@@ -367,21 +367,6 @@ class WrapperContextSpec extends Specification {
         wrapper.useXauthority[0].value() == true
     }
 
-    def 'xvnc with takeScreenshot arg' () {
-        setup:
-        mockJobManagement.getPluginVersion('xvnc') >> new VersionNumber('1.16')
-
-        when:
-        context.xvnc(true)
-
-        then:
-        context.wrapperNodes[0].name() == 'hudson.plugins.xvnc.Xvnc'
-        def wrapper = context.wrapperNodes[0]
-        wrapper.children().size() == 2
-        wrapper.takeScreenshot[0].value() == true
-        wrapper.useXauthority[0].value() == true
-    }
-
     def 'xvnc with closure' () {
         setup:
         mockJobManagement.getPluginVersion('xvnc') >> new VersionNumber('1.16')