cleanup of context constructors

Author: daspilker

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ScmContext.groovy

@@ -18,23 +18,17 @@ import static javaposse.jobdsl.dsl.ContextHelper.executeInContext
 import static javaposse.jobdsl.dsl.helpers.publisher.PublisherContext.validCloneWorkspaceCriteria
 
 class ScmContext implements Context {
-    boolean multiEnabled
-    List<Node> scmNodes = []
-    List<WithXmlAction> withXmlActions = []
-    JobManagement jobManagement
+    private final boolean multiEnabled
+    final List<Node> scmNodes = []
+    private final List<WithXmlAction> withXmlActions
+    private final JobManagement jobManagement
 
-    ScmContext(multiEnabled = false, withXmlActions = [], jobManagement = null) {
+    ScmContext(boolean multiEnabled, List<WithXmlAction> withXmlActions, JobManagement jobManagement) {
         this.multiEnabled = multiEnabled
         this.withXmlActions = withXmlActions
         this.jobManagement = jobManagement
     }
 
-    // Package scope
-    ScmContext(Node singleNode, multiEnabled = false) {
-        this.multiEnabled = multiEnabled
-        scmNodes << singleNode // Safe since this is the constructor
-    }
-
     /**
      * Helper method for dealing with a single scm node
      */

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/step/StepContext.groovy

@@ -15,11 +15,10 @@ import static javaposse.jobdsl.dsl.helpers.common.MavenContext.LocalRepositoryLo
 class StepContext implements Context {
     private static final List<String> VALID_CONTINUATION_CONDITIONS = ['SUCCESSFUL', 'UNSTABLE', 'COMPLETED']
 
-    List<Node> stepNodes = []
-    JobManagement jobManagement
+    final List<Node> stepNodes = []
+    private final JobManagement jobManagement
 
-    StepContext(List<Node> stepNodes = [], JobManagement jobManagement) {
-        this.stepNodes = stepNodes
+    StepContext(JobManagement jobManagement) {
         this.jobManagement = jobManagement
     }