deprecated support for older versions of the Subversion plugin

Author: daspilker

docs/Home.md

@@ -42,7 +42,9 @@ Browse the Jenkins issue tracker to see any [open issues](https://issues.jenkins
   * Deprecated `concurrentBuild` method in `pipelineJob` context, see [Migration](Migration#migrating-to-176)
     ([JENKINS-53775](https://issues.jenkins-ci.org/browse/JENKINS-53775))
   * Support for older versions of the [Pipeline Job Plugin](https://plugins.jenkins.io/workflow-job) is deprecated, see
-    [Migration](Migration#migrating-to-169)
+    [Migration](Migration#migrating-to-176)
+  * Support for older versions of the [Subversion Plugin](https://plugins.jenkins.io/subversion) is deprecated, see
+    [Migration](Migration#migrating-to-176)
 * 1.75 (August 12 2019)
   * Added documentation about mandatory identifier in multi-branch Pipeline job branch sources, the identifier will no
     longer be generated and must be set to a constant and unique value, see [Migration](Migration#migrating-to-175)

docs/Migration.md

@@ -32,6 +32,11 @@ pipelineJob('example-2') {
 }
 ```
 
+### Subversion Plugin
+
+Support for versions older than 2.8 of the [Subversion Plugin](https://plugins.jenkins.io/subversion) is
+[[deprecated|Deprecation-Policy]] and will be removed.
+
 ## Migrating to 1.75
 
 The `id` option in the Git and GitHub branch source contexts is now mandatory

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContext.groovy

@@ -59,6 +59,8 @@ class BuildParametersContext extends AbstractExtensibleContext {
      */
     @RequiresPlugin(id = 'subversion', minimumVersion = '2.1')
     void listTagsParam(String parameterName, String scmUrl, @DslContext(ListTagsParamContext) Closure closure = null) {
+        jobManagement.logPluginDeprecationWarning('subversion', '2.8')
+
         checkParameterName(parameterName)
         checkNotNullOrEmpty(scmUrl, 'scmUrl cannot be null or empty')
 

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/ScmContext.groovy

@@ -229,6 +229,8 @@ class ScmContext extends AbstractExtensibleContext {
      */
     @RequiresPlugin(id = 'subversion', minimumVersion = '2.1')
     void svn(@DslContext(SvnContext) Closure svnClosure) {
+        jobManagement.logPluginDeprecationWarning('subversion', '2.8')
+
         SvnContext svnContext = new SvnContext(jobManagement)
         executeInContext(svnClosure, svnContext)
 

job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContextSpec.groovy

@@ -115,6 +115,7 @@ class BuildParametersContextSpec extends Specification {
             !uuid.text().empty
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'simplified listTagsParam usage'() {
@@ -140,6 +141,7 @@ class BuildParametersContextSpec extends Specification {
             !uuid.text().empty
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'simplest listTagsParam usage'() {
@@ -164,6 +166,7 @@ class BuildParametersContextSpec extends Specification {
             !uuid.text().empty
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'simplest closure listTagsParam usage'() {
@@ -189,6 +192,7 @@ class BuildParametersContextSpec extends Specification {
             !uuid.text().empty
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'listTagsParam with all closure options'() {
@@ -221,6 +225,7 @@ class BuildParametersContextSpec extends Specification {
             !uuid.text().empty
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'listTagsParam with maxTagsToDisplay int argument'() {
@@ -253,6 +258,7 @@ class BuildParametersContextSpec extends Specification {
             !uuid.text().empty
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'listTagsParam name argument cant be null'() {
@@ -305,6 +311,7 @@ class BuildParametersContextSpec extends Specification {
             maxTags.text() == 'all'
         }
         (1.._) * jobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * jobManagement.logPluginDeprecationWarning('subversion', '2.8')
 
         where:
         filter << [null, '']

job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/helpers/ScmContextSpec.groovy

@@ -1237,6 +1237,7 @@ class ScmContextSpec extends Specification {
         context.scmNodes[0].excludedRegions.size() == 1
         context.scmNodes[0].excludedRegions[0].value() == '/trunk/.*'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with remote and local'() {
@@ -1248,6 +1249,7 @@ class ScmContextSpec extends Specification {
             locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[0].local[0].value() == '/mydir/mycode'
         }
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with browser - Fisheye example'() {
@@ -1265,6 +1267,7 @@ class ScmContextSpec extends Specification {
         context.scmNodes[0].browser[0].url[0].value() == 'http://mycompany.com/fisheye/repo_name'
         context.scmNodes[0].browser[0].rootModule[0].value() == 'my_root_module'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with browser - ViewSVN example'() {
@@ -1278,6 +1281,7 @@ class ScmContextSpec extends Specification {
         context.scmNodes[0].browser[0].attributes()['class'] == 'hudson.scm.browsers.ViewSVN'
         context.scmNodes[0].browser[0].url[0].value() == 'http://mycompany.com/viewsvn/repo_name'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with no locations'() {
@@ -1309,6 +1313,7 @@ class ScmContextSpec extends Specification {
             locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[0].ignoreExternalsOption[0].value() == true
         }
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with credentials'() {
@@ -1331,6 +1336,7 @@ class ScmContextSpec extends Specification {
             locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[0].ignoreExternalsOption[0].value() == false
         }
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with multiple locations'() {
@@ -1350,6 +1356,7 @@ class ScmContextSpec extends Specification {
         context.scmNodes[0].locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[1].remote[0].value() == 'url2'
         context.scmNodes[0].locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[1].local[0].value() == 'dir2'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn without specifying a local dir for the location'() {
@@ -1364,6 +1371,7 @@ class ScmContextSpec extends Specification {
         context.scmNodes[0].locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[0].remote[0].value() == 'url'
         context.scmNodes[0].locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[0].local[0].value() == '.'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     @Unroll
@@ -1381,6 +1389,7 @@ class ScmContextSpec extends Specification {
             locations[0].'hudson.scm.SubversionSCM_-ModuleLocation'[0].depthOption[0].value() == xmlValue
         }
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
 
         where:
         depth              || xmlValue
@@ -1401,6 +1410,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].workspaceUpdater[0].attributes()['class'] == 'hudson.scm.subversion.UpdateUpdater'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with checkout strategy'() {
@@ -1414,6 +1424,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].workspaceUpdater[0].attributes()['class'] == workspaceUpdaterClass
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
 
         where:
         strategy                               | workspaceUpdaterClass
@@ -1433,6 +1444,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedRegions[0].value() == ''
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with single excluded region'() {
@@ -1446,6 +1458,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedRegions[0].value() == 'exreg'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with multiple excluded regions'() {
@@ -1460,6 +1473,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedRegions[0].value() == 'exreg1\nexreg2'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with a list of excluded regions'() {
@@ -1474,6 +1488,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedRegions[0].value() == 'exreg1\nexreg2\nexreg3\nexreg4'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn without included regions'() {
@@ -1486,6 +1501,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].includedRegions[0].value() == ''
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with single included region'() {
@@ -1499,6 +1515,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].includedRegions[0].value() == 'increg'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with multiple included regions'() {
@@ -1513,6 +1530,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].includedRegions[0].value() == 'increg1\nincreg2'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with a list of included regions'() {
@@ -1527,6 +1545,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].includedRegions[0].value() == 'increg1\nincreg2\nincreg3\nincreg4'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn without excluded users'() {
@@ -1539,6 +1558,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedUsers[0].value() == ''
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with single excluded user'() {
@@ -1552,6 +1572,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedUsers[0].value() == 'user'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with multiple excluded users'() {
@@ -1566,6 +1587,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedUsers[0].value() == 'user1\nuser2'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with a list of excluded users'() {
@@ -1580,6 +1602,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedUsers[0].value() == 'user1\nuser2\nuser3\nuser4'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn without excluded commit messages'() {
@@ -1592,6 +1615,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedCommitMessages[0].value() == ''
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with single excluded commit message'() {
@@ -1605,6 +1629,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedCommitMessages[0].value() == 'commit'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with multiple excluded commit messages'() {
@@ -1619,6 +1644,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedCommitMessages[0].value() == 'commit1\ncommit2'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with a list of excluded commit messages'() {
@@ -1633,6 +1659,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedCommitMessages[0].value() == 'commit1\ncommit2\ncommit3\ncommit4'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with a mix of excluded commit message specifications'() {
@@ -1647,6 +1674,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedCommitMessages[0].value() == 'commit1\ncommit2\ncommit3'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn without excluded revprop'() {
@@ -1659,6 +1687,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedRevprop[0].value() == ''
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with an excluded revprop'() {
@@ -1672,6 +1701,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].excludedRevprop[0].value() == 'revprop'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call svn with configure'() {
@@ -1687,6 +1717,7 @@ class ScmContextSpec extends Specification {
         isValidSvnScmNode(context.scmNodes[0])
         context.scmNodes[0].testNode[0].value() == 'testValue'
         (1.._) * mockJobManagement.requireMinimumPluginVersion('subversion', '2.1')
+        1 * mockJobManagement.logPluginDeprecationWarning('subversion', '2.8')
     }
 
     def 'call perforceP4 with all options'() {