improved support for views

[JENKINS-59117]

Author: daspilker

docs/Home.md

@@ -34,6 +34,8 @@ Browse the Jenkins issue tracker to see any [open issues](https://issues.jenkins
 ## Release Notes
 * 1.77 (unreleased)
   * Increased the minimum supported Jenkins version to 2.138
+  * Improved support for views
+    ([JENKINS-59117](https://issues.jenkins-ci.org/browse/JENKINS-59117))
   * Fixed problem with paths on Windows
     ([JENKINS-53840](https://issues.jenkins-ci.org/browse/JENKINS-53840))
 * 1.76 (August 22 2019)

job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/views/NestedViewsContext.groovy

@@ -1,17 +1,19 @@
 package javaposse.jobdsl.dsl.views
 
-import javaposse.jobdsl.dsl.AbstractContext
+import javaposse.jobdsl.dsl.AbstractExtensibleContext
+import javaposse.jobdsl.dsl.ContextType
 import javaposse.jobdsl.dsl.DslContext
 import javaposse.jobdsl.dsl.JobManagement
 import javaposse.jobdsl.dsl.Preconditions
 import javaposse.jobdsl.dsl.View
 import javaposse.jobdsl.dsl.ViewFactory
 
-class NestedViewsContext extends AbstractContext implements ViewFactory {
+@ContextType('hudson.model.View')
+class NestedViewsContext extends AbstractExtensibleContext implements ViewFactory {
     List<View> views = []
 
     NestedViewsContext(JobManagement jobManagement) {
-        super(jobManagement)
+        super(jobManagement, null)
     }
 
     /**
@@ -78,6 +80,16 @@ class NestedViewsContext extends AbstractContext implements ViewFactory {
         processView(name, DashboardView, closure)
     }
 
+    @Override
+    protected void addExtensionNode(Node node) {
+        views << new View(jobManagement, node['name'].text()) {
+            @Override
+            Node getNode() {
+                node
+            }
+        }
+    }
+
     private <T extends View> T processView(String name, Class<T> viewClass, Closure closure) {
         Preconditions.checkNotNullOrEmpty(name, 'name must be specified')
 

job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/views/NestedViewsContextSpec.groovy

@@ -0,0 +1,25 @@
+package javaposse.jobdsl.dsl.views
+
+import javaposse.jobdsl.dsl.JobManagement
+import spock.lang.Specification
+
+class NestedViewsContextSpec extends Specification {
+    private final JobManagement jobManagement = Mock(JobManagement)
+    private final NestedViewsContext context = new NestedViewsContext(jobManagement)
+
+    def 'extension'() {
+        given:
+        Node viewNode = new NodeBuilder().'my.custom.CustomView' {
+            name('myView')
+        }
+
+        when:
+        context.addExtensionNode(viewNode)
+
+        then:
+        context.views != null
+        context.views.size() == 1
+        context.views[0].name == 'myView'
+        context.views[0].node == viewNode
+    }
+}