Skip to content

Commit 0c7a88b

Browse files
committed
some fixes
1 parent 299cfd8 commit 0c7a88b

File tree

7 files changed

+38
-13
lines changed

7 files changed

+38
-13
lines changed

resources/ui/css/custom_ids.bss

140 Bytes
Binary file not shown.

resources/ui/css/custom_ids.css

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -824,4 +824,14 @@
824824
-fx-min-height: 25;
825825
-fx-pref-height: -fx-min-height;
826826
-fx-max-height: -fx-min-height;
827+
}
828+
829+
#ImageViewEditorContainer {
830+
-fx-alignment: center;
831+
-fx-background-color: -fx-background-background;
832+
}
833+
834+
#AudioViewEditorContainer {
835+
-fx-alignment: center;
836+
-fx-background-color: -fx-background-background;
827837
}

src/com/ss/editor/JFXApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ public void buildScene() {
206206
this.scene = EditorFXSceneBuilder.build(requireNonNull(stage));
207207

208208
final EditorFXScene scene = getScene();
209-
scene.notifyFinishBuild();
210209

211210
final Editor editor = Editor.getInstance();
212211
final EditorThreadExecutor executor = EditorThreadExecutor.getInstance();
@@ -240,6 +239,7 @@ private void createSceneProcessor(@NotNull final EditorFXScene scene, @NotNull f
240239
this.sceneProcessor = bind(editor, scene.getCanvas(), editor.getViewPort());
241240
final Stage stage = getStage();
242241
stage.focusedProperty().addListener((observable, oldValue, newValue) -> editor.setPaused(!newValue));
242+
Platform.runLater(scene::notifyFinishBuild);
243243
}
244244

245245
/**

src/com/ss/editor/ui/component/editor/area/EditorAreaComponent.java

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
import javafx.scene.control.Tab;
5050
import javafx.scene.control.TabPane;
5151
import javafx.scene.image.ImageView;
52+
import rlib.concurrent.util.ThreadUtils;
5253
import rlib.logging.Logger;
5354
import rlib.logging.LoggerManager;
5455
import rlib.ui.util.FXUtils;
@@ -317,7 +318,7 @@ private void processShowEditor(@Nullable final Tab prevTab, @Nullable final Tab
317318
final AppStateManager stateManager = EDITOR.getStateManager();
318319
final FrameTransferSceneProcessor sceneProcessor = JFX_APPLICATION.getSceneProcessor();
319320

320-
EXECUTOR_MANAGER.addFXTask(() -> sceneProcessor.setEnabled(false));
321+
boolean enabled = false;
321322

322323
if (prevTab != null) {
323324

@@ -328,15 +329,24 @@ private void processShowEditor(@Nullable final Tab prevTab, @Nullable final Tab
328329
states.forEach(stateManager::detach);
329330
}
330331

331-
if (newTab == null) return;
332+
if (newTab != null) {
332333

333-
final ObservableMap<Object, Object> properties = newTab.getProperties();
334-
final FileEditor fileEditor = (FileEditor) properties.get(KEY_EDITOR);
334+
final ObservableMap<Object, Object> properties = newTab.getProperties();
335+
final FileEditor fileEditor = (FileEditor) properties.get(KEY_EDITOR);
335336

336-
final Array<EditorAppState> states = fileEditor.getStates();
337-
states.forEach(stateManager::attach);
337+
final Array<EditorAppState> states = fileEditor.getStates();
338+
states.forEach(stateManager::attach);
339+
340+
enabled = states.size() > 0;
341+
}
338342

339-
EXECUTOR_MANAGER.addFXTask(() -> sceneProcessor.setEnabled(!states.isEmpty()));
343+
if (sceneProcessor.isEnabled() != enabled) {
344+
final boolean result = enabled;
345+
EXECUTOR_MANAGER.addFXTask(() -> {
346+
ThreadUtils.sleep(100);
347+
sceneProcessor.setEnabled(result);
348+
});
349+
}
340350
}
341351

342352
/**
@@ -449,7 +459,10 @@ private void loadOpenedFiles() {
449459

450460
final FrameTransferSceneProcessor sceneProcessor = JFX_APPLICATION.getSceneProcessor();
451461

452-
EXECUTOR_MANAGER.addFXTask(() -> sceneProcessor.setEnabled(false));
462+
EXECUTOR_MANAGER.addFXTask(() -> {
463+
ThreadUtils.sleep(200);
464+
sceneProcessor.setEnabled(false);
465+
});
453466

454467
final Workspace workspace = WORKSPACE_MANAGER.getCurrentWorkspace();
455468
if (workspace == null) return;

src/com/ss/editor/ui/component/editor/impl/AudioViewerEditor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import java.nio.file.Path;
2424
import java.util.Objects;
2525

26-
import javafx.geometry.Pos;
2726
import javafx.scene.control.Button;
2827
import javafx.scene.control.Label;
2928
import javafx.scene.control.TextField;
@@ -105,7 +104,7 @@ protected VBox createRoot() {
105104

106105
@Override
107106
protected void createContent(@NotNull final VBox root) {
108-
root.setAlignment(Pos.CENTER);
107+
root.setId(CSSIds.AUDIO_VIEW_EDITOR_CONTAINER);
109108

110109
final Label durationLabel = new Label(Messages.AUDIO_VIEWER_EDITOR_DURATION_LABEL + ":");
111110
durationLabel.setId(CSSIds.AUDIO_VIEWER_EDITOR_PARAM_LABEL);

src/com/ss/editor/ui/component/editor/impl/ImageViewerEditor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
import com.ss.editor.Messages;
66
import com.ss.editor.manager.JavaFXImageManager;
77
import com.ss.editor.ui.component.editor.EditorDescription;
8+
import com.ss.editor.ui.css.CSSIds;
89
import com.ss.editor.ui.event.impl.FileChangedEvent;
910

1011
import org.jetbrains.annotations.NotNull;
1112

1213
import java.nio.file.Path;
1314

14-
import javafx.geometry.Pos;
1515
import javafx.scene.image.Image;
1616
import javafx.scene.image.ImageView;
1717
import javafx.scene.layout.VBox;
@@ -55,7 +55,7 @@ protected VBox createRoot() {
5555

5656
@Override
5757
protected void createContent(@NotNull final VBox root) {
58-
root.setAlignment(Pos.CENTER);
58+
root.setId(CSSIds.IMAGE_VIEW_EDITOR_CONTAINER);
5959

6060
imageView = new ImageView();
6161

src/com/ss/editor/ui/css/CSSIds.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,4 +145,7 @@ public interface CSSIds {
145145

146146
String ADD_USER_DATA_DIALOG_LABEL = "AddUserDataDialogLabel";
147147
String ADD_USER_DATA_FIELD = "AddUserDataDialogField";
148+
149+
String IMAGE_VIEW_EDITOR_CONTAINER = "ImageViewEditorContainer";
150+
String AUDIO_VIEW_EDITOR_CONTAINER = "AudioViewEditorContainer";
148151
}

0 commit comments

Comments
 (0)