Skip to content

Commit 13e7e6a

Browse files
committed
[broker-25] fix for code review
1 parent 22552a1 commit 13e7e6a

File tree

3 files changed

+4
-109
lines changed

3 files changed

+4
-109
lines changed

src/main/java/com/ss/mqtt/broker/model/SubscribeTopicFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public SubscribeTopicFilter(@NotNull TopicFilter topicFilter, @NotNull QoS qos)
5151
}
5252

5353
@Override
54-
public String toString() {
54+
public @NotNull String toString() {
5555
return "SubscribeTopicFilter(" + "topicFilter=" + topicFilter.getRawTopic() + ", qos=" + qos + ", retainHandling=" +
5656
retainHandling + ", noLocal=" + noLocal + ", retainAsPublished=" + retainAsPublished + ')';
5757
}

src/test/groovy/com/ss/mqtt/broker/test/integration/ConnectSubscribePublishTest.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
1515
given:
1616
def received = new AtomicReference<Mqtt5Publish>()
1717
def subscriber = buildClient()
18-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
18+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
1919
def publisher = buildClient()
2020
when:
2121
subscriber.connect().join()
@@ -48,7 +48,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
4848
given:
4949
def received = new AtomicReference<Mqtt5Publish>()
5050
def subscriber = buildClient()
51-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
51+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
5252
def publisher = buildClient()
5353
when:
5454

@@ -82,7 +82,7 @@ class ConnectSubscribePublishTest extends IntegrationSpecification {
8282
given:
8383
def received = new AtomicReference<Mqtt5Publish>()
8484
def subscriber = buildClient()
85-
def subscriberId = subscriber.getConfig().clientIdentifier.get()toString()
85+
def subscriberId = subscriber.getConfig().clientIdentifier.get().toString()
8686
def publisher = buildClient()
8787
when:
8888

src/test/groovy/com/ss/mqtt/broker/test/integration/service/PublishRetryServiceTest.groovy

Lines changed: 0 additions & 105 deletions
This file was deleted.

0 commit comments

Comments
 (0)