Skip to content

Improve subscription process, part 2 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 10, 2025
Merged

Improve subscription process, part 2 #51

merged 6 commits into from
Nov 10, 2025

Conversation

@JavaSaBr
Copy link
Owner

@JavaSaBr JavaSaBr commented Nov 10, 2025

  1. Finalize Subscription Service to implement all requirements
  2. Finalize Subscription message handler to do all validations and error handling
  3. Extend test coverage

@JavaSaBr JavaSaBr self-assigned this Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Overall Project 84.86% -1.55% 🍏
Files changed 82.02% 🍏

File Coverage
Subscription.java 100% 🍏
TrackableMqttInMessage.java 100% 🍏
MqttClientConnectionConfig.java 100% 🍏
MqttProperties.java 100% 🍏
MqttServerConnectionConfig.java 100% 🍏
QoS.java 100% 🍏
TopicTreeBase.java 100% 🍏
ConcurrentTopicTree.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
PublishReleaseMqtt311OutMessage.java 100% 🍏
TrackableMqttOutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
SubscribeMqtt5OutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
PublishReleaseMqttInMessageHandler.java 100% 🍏
SubscriptionService.java 100% 🍏
InMemoryActiveSubscriptions.java 100% 🍏
InMemoryMessageTacker.java 100% 🍏
MqttMessageWriter.java 100% 🍏
TopicNode.java 98.78% 🍏
MqttDataUtils.java 97.56% 🍏
InMemorySubscriptionService.java 96.59% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
PublishMqttInMessage.java 95.83% 🍏
PublishReleaseMqttInMessage.java 95.51% -1.12% 🍏
PublishMqtt311OutMessage.java 94.38% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
PersistedMqttPublishOutMessageHandler.java 92% 🍏
MqttOutMessage.java 90.48% 🍏
SubscribeMqttInMessage.java 90.32% 🍏
MqttMessageReader.java 90.14% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqttInMessage.java 87.69% 🍏
AbstractMqttClient.java 87.23% 🍏
MqttInMessage.java 86.72% 🍏
UnsubscribeMqttInMessage.java 84.38% -1.56% 🍏
Mqtt5MessageOutFactory.java 84.26% 🍏
MqttConnection.java 83.78% -2.7% 🍏
SubscribeAckMqttInMessage.java 82.89% 🍏
AbstractMqttClientReleaseHandler.java 82.73% 🍏
ConnectInMqttInMessageHandler.java 80.68% -2.44% ❌
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryMqttSession.java 65.67% -2% 🍏
MqttMessageOutFactory.java 65.33% -4.67% 🍏
DefaultConnectionService.java 61.8% -29.81% ❌
Qos2MqttPublishInMessageHandler.java 60.5% 🍏
PublishMqttInMessageHandler.java 52.05% 🍏
InMemoryMqttSessionService.java 46.6% 🍏
DefaultTopicService.java 34.31% 🍏
UnsubscribeMqttInMessageHandler.java 26.42% -7.55% ❌
AbstractMqttInMessageHandler.java 21.47% -49.08% ❌
MqttSession.java 0% 🍏
PingResponseMqttInMessage.java 0% -27.27% ❌
PingRequestMqttInMessage.java 0% -27.27% ❌

@JavaSaBr JavaSaBr merged commit 6b912ea into develop Nov 10, 2025
6 checks passed
@JavaSaBr JavaSaBr deleted the improve-subscription-service-part2 branch November 10, 2025 17:40
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Overall Project 85.64% -1.55% 🍏
Files changed 82.02% 🍏

File Coverage
Subscription.java 100% 🍏
TrackableMqttInMessage.java 100% 🍏
MqttClientConnectionConfig.java 100% 🍏
MqttProperties.java 100% 🍏
MqttServerConnectionConfig.java 100% 🍏
QoS.java 100% 🍏
TopicTreeBase.java 100% 🍏
ConcurrentTopicTree.java 100% 🍏
SubscribeAckMqtt5OutMessage.java 100% 🍏
PublishReleaseMqtt311OutMessage.java 100% 🍏
TrackableMqttOutMessage.java 100% 🍏
SubscribeMqtt311OutMessage.java 100% 🍏
SubscribeAckMqtt311OutMessage.java 100% 🍏
ConnectAckMqtt5OutMessage.java 100% 🍏
DisconnectMqtt5OutMessage.java 100% 🍏
SubscribeMqtt5OutMessage.java 100% 🍏
PendingOutResponseMqttInMessageHandler.java 100% 🍏
SubscribeMqttInMessageHandler.java 100% 🍏
PublishReleaseMqttInMessageHandler.java 100% 🍏
SubscriptionService.java 100% 🍏
InMemoryActiveSubscriptions.java 100% 🍏
InMemoryMessageTacker.java 100% 🍏
MqttMessageWriter.java 100% 🍏
TopicNode.java 98.78% 🍏
MqttDataUtils.java 97.56% 🍏
InMemorySubscriptionService.java 96.59% 🍏
PublishReceivedMqttInMessage.java 96.34% 🍏
PublishCompleteMqttInMessage.java 96.34% 🍏
PublishAckMqttInMessage.java 96.1% 🍏
ConnectAckMqttInMessage.java 95.97% 🍏
PublishMqttInMessage.java 95.83% 🍏
PublishReleaseMqttInMessage.java 95.51% -1.12% 🍏
PublishMqtt311OutMessage.java 94.38% 🍏
DisconnectMqttInMessage.java 94.17% 🍏
UnsubscribeAckMqttInMessage.java 92.31% 🍏
PersistedMqttPublishOutMessageHandler.java 92% 🍏
MqttOutMessage.java 90.48% 🍏
SubscribeMqttInMessage.java 90.32% 🍏
MqttMessageReader.java 90.14% 🍏
AuthenticationMqttInMessage.java 88.24% 🍏
ConnectMqttInMessage.java 87.69% 🍏
AbstractMqttClient.java 87.23% 🍏
MqttInMessage.java 86.72% 🍏
UnsubscribeMqttInMessage.java 84.38% -1.56% 🍏
Mqtt5MessageOutFactory.java 84.26% 🍏
MqttConnection.java 83.78% -2.7% 🍏
SubscribeAckMqttInMessage.java 82.89% 🍏
AbstractMqttClientReleaseHandler.java 82.73% 🍏
ConnectInMqttInMessageHandler.java 80.68% -2.44% ❌
InMemoryMqttSessionService.java 78.57% 🍏
DisconnectMqttInMessageHandler.java 73.58% 🍏
InMemoryMqttSession.java 70.33% -2% 🍏
MqttMessageOutFactory.java 65.33% -4.67% 🍏
DefaultConnectionService.java 61.8% -29.81% ❌
Qos2MqttPublishInMessageHandler.java 60.5% 🍏
PublishMqttInMessageHandler.java 52.05% 🍏
DefaultTopicService.java 34.31% 🍏
UnsubscribeMqttInMessageHandler.java 26.42% -7.55% ❌
AbstractMqttInMessageHandler.java 21.47% -49.08% ❌
MqttSession.java 0% 🍏
PingResponseMqttInMessage.java 0% -27.27% ❌
PingRequestMqttInMessage.java 0% -27.27% ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JavaSaBr JavaSaBr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JavaSaBr