Skip to content

Commit 646bb9d

Browse files
committed
Update SolidJS config and esbuild loader handling
Changed JSX settings in deno.json to use 'preserve' and updated jsxImportSource to '@solid-js'. Added '@solid-js/jsx-runtime' to imports. Improved esbuild loader type handling and removed tsconfig from filesConfig. These changes improve compatibility with SolidJS and esbuild.
1 parent 33ab61d commit 646bb9d

File tree

3 files changed

+30
-8
lines changed

3 files changed

+30
-8
lines changed

build/esbuild.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const args = parseArgs<{
1313
}>(Deno.args);
1414

1515
// convert array to esbuild copy loader object
16-
const loaders = [
16+
const loaders : { [ext: string]: esbuild.Loader } = [
1717
".html",
1818
".css",
1919
".svg",
@@ -23,10 +23,10 @@ const loaders = [
2323
".ico"
2424
].reduce((
2525
previousExtension,
26-
extension
26+
currentExtension
2727
) => ({
2828
...previousExtension,
29-
[extension]: 'copy' as esbuild.Loader
29+
[currentExtension]: 'copy'
3030
}), {})
3131

3232
const copyConfig : esbuild.BuildOptions = {
@@ -55,7 +55,6 @@ const filesConfig : esbuild.BuildOptions = {
5555
target: 'esnext',
5656
sourcemap: args.develop ? 'linked' : false,
5757
sourcesContent: true,
58-
tsconfig: './deno.json',
5958
outdir: './dist',
6059
outbase: './src/client',
6160
entryPoints: [

deno.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@
6161
"dom",
6262
"webworker"
6363
],
64-
"jsx": "react-jsx",
65-
"jsxImportSource": "npm:solid-js"
64+
"jsx": "preserve",
65+
"jsxImportSource": "@solid-js"
6666
},
6767
"exclude": [
6868
"./dist/"
@@ -113,6 +113,7 @@
113113
"@esbuild": "npm:esbuild",
114114
"@esbuild-plugin-solid": "npm:esbuild-plugin-solid",
115115
"@solid-js": "https://esm.sh/[email protected]",
116+
"@solid-js/jsx-runtime": "https://esm.sh/[email protected]/jsx-runtime",
116117
"@solid-js/web": "https://esm.sh/[email protected]/web",
117118
"@solid-js/router": "https://esm.sh/@solidjs/[email protected]",
118119
"@std/cli/parse-args": "jsr:@std/cli@^1.0.6/parse-args",

deno.lock

Lines changed: 24 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)