v0.3.3, Telemetry config, fix potential issues with last element in vanilla arrays

Author: JavidPack

HEROsMod.cs

@@ -459,8 +459,11 @@ public static void LoadAddServices()
 
 			ServiceController.AddService(new Login());
 
-			ServiceController.AddService(new PSAService());
-			ServiceController.AddService(new StatsService());
+			if (ModContent.GetInstance<HEROsModServerConfig>().Telemetry)
+			{
+				ServiceController.AddService(new PSAService());
+				ServiceController.AddService(new StatsService());
+			}
 
 			//ServiceController.AddService(new HardmodeEnemyToggler(multiplayerOption.Hotbar));
 			//ServiceController.AddService(new ZoomToolsService());

HEROsModNetwork/GeneralMessages.cs

@@ -1173,7 +1173,7 @@ private static void ProcessSpawnNPCRequest(ref BinaryReader reader, int playerNu
 
 				if (newNPC.townNPC || global::HEROsMod.HEROsModServices.NPCStats.boundNPC.Contains(npcType))
 				{
-					for (int i = 0; i < Main.npc.Length; i++)
+					for (int i = 0; i < Main.maxNPCs; i++)
 					{
 						NPC npc = Main.npc[i];
 						if (npc.type == newNPC.type)

HEROsModNetwork/Network.cs

@@ -1003,7 +1003,7 @@ public static Region GetRegionByID(int id)
 
 		public static void ClearGroundItems()
 		{
-			for (int i = 0; i < Main.item.Length; i++)
+			for (int i = 0; i < Main.maxItems; i++)
 			{
 				if (Main.item[i].active)
 				{
@@ -1016,7 +1016,7 @@ public static void ClearGroundItems()
 		public static void SpawnNPC(int type, Vector2 position)
 		{
 			bool npcFound = false;
-			for (int i = 0; i < Main.npc.Length; i++)
+			for (int i = 0; i < Main.maxNPCs; i++)
 			{
 				NPC n = Main.npc[i];
 				if (n.type == type)

HEROsModServerConfig.cs

@@ -25,6 +25,12 @@ class HEROsModServerConfig : ModConfig
 		[DefaultValue(false)]
 		public bool FreezeNonLoggedIn { get; set; }
 
+		[Label("Telemetry")]
+		[Tooltip("Disable this to disable update notifications and other telemetry.")]
+		[DefaultValue(true)]
+		[ReloadRequired]
+		public bool Telemetry { get; set; }
+
 		public override bool AcceptClientChanges(ModConfig pendingConfig, int whoAmI, ref string message)
 		{
 			if (Network.Players[whoAmI].Group.IsAdmin)

HEROsModServices/EnemyToggler.cs

@@ -47,7 +47,7 @@ public static void ToggleNPCs()
 
 		public static void ClearNPCs()
 		{
-			for (int i = 0; i < Main.npc.Length; i++)
+			for (int i = 0; i < Main.maxNPCs; i++)
 			{
 				if (Main.npc[i] != null && !Main.npc[i].townNPC)
 				{

HEROsModServices/ItemClearer.cs

@@ -22,7 +22,7 @@ private void _hotbarIcon_onLeftClick(object sender, EventArgs e)
 			//ClearItems
 			if (ModUtils.NetworkMode == NetworkMode.None)
 			{
-				for (int i = 0; i < Main.item.Length; i++)
+				for (int i = 0; i < Main.maxItems; i++)
 				{
 					Main.item[i].active = false;
 				}

HEROsModServices/MobSpawner.cs

@@ -787,7 +787,7 @@ public virtual void Spawn(int playerIndex)
 			Player player = Main.player[playerIndex];
 			if (IsTownNPC || boundNPC.Contains(Type))
 			{
-				for (int i = 0; i < Main.npc.Length; i++)
+				for (int i = 0; i < Main.maxNPCs; i++)
 				{
 					NPC npc = Main.npc[i];
 					if (npc.type == NetID)

HEROsModVideo/Services/MobHUD/MobInfo.cs

@@ -13,7 +13,7 @@ internal class MobInfo
 
 		public static void Update()
 		{
-			for (int i = 0; i < Main.npc.Length; i++)
+			for (int i = 0; i < Main.maxNPCs; i++)
 			{
 				NPC npc = Main.npc[i];
 				if (npc.active && NPCOnScreen(npc))

build.txt

@@ -1,5 +1,5 @@
 author = HERO, jopojelly, Matt Thompson, Panini
-version = 0.3.2
+version = 0.3.3
 versionScheme = ?.?.Fix.Quickfix
 displayName = HERO's Mod
 homepage = http://forums.terraria.org/index.php?threads/heros-mod-creative-mode-server-management-and-over-25-tools-1-3-1-1-compatible.44650/