Skip to content

Commit 61e5471

Browse files
Address code review feedback: fix logger DI and remove unnecessary null-forgiving operator
Co-authored-by: JeanMarcMbouma <16613177+JeanMarcMbouma@users.noreply.github.com>
1 parent 777341d commit 61e5471

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/BbQ.Events.PostgreSql/Configuration/PostgreSqlSchemaInitializerHostedService.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,27 @@ namespace BbQ.Events.PostgreSql.Configuration;
1010
internal class PostgreSqlSchemaInitializerHostedService : IHostedService
1111
{
1212
private readonly ISchemaInitializer _schemaInitializer;
13-
private readonly ILogger<PostgreSqlSchemaInitializerHostedService>? _logger;
13+
private readonly ILogger<PostgreSqlSchemaInitializerHostedService> _logger;
1414

1515
public PostgreSqlSchemaInitializerHostedService(
1616
ISchemaInitializer schemaInitializer,
17-
ILogger<PostgreSqlSchemaInitializerHostedService>? logger = null)
17+
ILogger<PostgreSqlSchemaInitializerHostedService> logger)
1818
{
1919
_schemaInitializer = schemaInitializer ?? throw new ArgumentNullException(nameof(schemaInitializer));
20-
_logger = logger;
20+
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
2121
}
2222

2323
public async Task StartAsync(CancellationToken cancellationToken)
2424
{
2525
try
2626
{
27-
_logger?.LogInformation("Ensuring PostgreSQL event store schema exists...");
27+
_logger.LogInformation("Ensuring PostgreSQL event store schema exists...");
2828
await _schemaInitializer.EnsureSchemaAsync(cancellationToken);
29-
_logger?.LogInformation("PostgreSQL event store schema initialized successfully");
29+
_logger.LogInformation("PostgreSQL event store schema initialized successfully");
3030
}
3131
catch (Exception ex)
3232
{
33-
_logger?.LogError(ex, "Failed to initialize PostgreSQL event store schema");
33+
_logger.LogError(ex, "Failed to initialize PostgreSQL event store schema");
3434
throw;
3535
}
3636
}

src/BbQ.Events.SqlServer/Configuration/SqlServerSchemaInitializerHostedService.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,27 @@ namespace BbQ.Events.SqlServer.Configuration;
1010
internal class SqlServerSchemaInitializerHostedService : IHostedService
1111
{
1212
private readonly ISchemaInitializer _schemaInitializer;
13-
private readonly ILogger<SqlServerSchemaInitializerHostedService>? _logger;
13+
private readonly ILogger<SqlServerSchemaInitializerHostedService> _logger;
1414

1515
public SqlServerSchemaInitializerHostedService(
1616
ISchemaInitializer schemaInitializer,
17-
ILogger<SqlServerSchemaInitializerHostedService>? logger = null)
17+
ILogger<SqlServerSchemaInitializerHostedService> logger)
1818
{
1919
_schemaInitializer = schemaInitializer ?? throw new ArgumentNullException(nameof(schemaInitializer));
20-
_logger = logger;
20+
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
2121
}
2222

2323
public async Task StartAsync(CancellationToken cancellationToken)
2424
{
2525
try
2626
{
27-
_logger?.LogInformation("Ensuring SQL Server event store schema exists...");
27+
_logger.LogInformation("Ensuring SQL Server event store schema exists...");
2828
await _schemaInitializer.EnsureSchemaAsync(cancellationToken);
29-
_logger?.LogInformation("SQL Server event store schema initialized successfully");
29+
_logger.LogInformation("SQL Server event store schema initialized successfully");
3030
}
3131
catch (Exception ex)
3232
{
33-
_logger?.LogError(ex, "Failed to initialize SQL Server event store schema");
33+
_logger.LogError(ex, "Failed to initialize SQL Server event store schema");
3434
throw;
3535
}
3636
}

src/BbQ.Events.SqlServer/Schema/SqlServerSchemaInitializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ FROM INFORMATION_SCHEMA.TABLES
5656
await using var checkCommand = new SqlCommand(checkSql, connection);
5757
checkCommand.Parameters.AddWithValue("@TableName", tableName);
5858

59-
var exists = (int)(await checkCommand.ExecuteScalarAsync(cancellationToken))! > 0;
59+
var exists = (int)(await checkCommand.ExecuteScalarAsync(cancellationToken)) > 0;
6060

6161
if (exists)
6262
{

0 commit comments

Comments
 (0)