Skip to content

Commit d35e7f2

Browse files
devversionthePunderWoman
authored andcommitted
build: replace deprecated inquirer with new npm package (angular#57205)
The new package comes with types by default, and also has a nicer API. The old package had broken types and couldn't be used anymore; and it's deprecated/unmaintained. We did a similar switch in angular/dev-infra. PR Close angular#57205
1 parent e11c0c4 commit d35e7f2

File tree

3 files changed

+118
-128
lines changed

3 files changed

+118
-128
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,14 +178,14 @@
178178
"@codemirror/search": "^6.5.5",
179179
"@codemirror/state": "^6.3.3",
180180
"@codemirror/view": "^6.22.2",
181+
"@inquirer/prompts": "^5.3.6",
181182
"@lezer/common": "^1.1.2",
182183
"@lezer/highlight": "^1.2.0",
183184
"@lezer/javascript": "^1.4.10",
184185
"@octokit/graphql": "^8.0.0",
185186
"@types/adm-zip": "^0.5.0",
186187
"@types/cldrjs": "^0.4.22",
187188
"@types/d3": "^7.4.3",
188-
"@types/inquirer": "^9.0.3",
189189
"@types/jsdom": "^21.1.5",
190190
"@typescript/vfs": "^1.5.0",
191191
"@webcontainer/api": "^1.3.0-internal.2",
@@ -205,7 +205,6 @@
205205
"gulp-conventional-changelog": "^5.0.0",
206206
"html-entities": "^2.5.2",
207207
"husky": "9.1.4",
208-
"inquirer": "^10.0.0",
209208
"jsdom": "^24.0.0",
210209
"karma-coverage": "^2.2.1",
211210
"karma-jasmine-html-reporter": "^2.1.0",

scripts/benchmarks/index.mts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import {setOutput} from '@actions/core';
1010
import {GitClient, Log, bold, green, yellow} from '@angular/ng-dev';
11-
import inquirer from 'inquirer';
11+
import {select} from '@inquirer/prompts';
1212
import yargs from 'yargs';
1313
import {collectBenchmarkResults} from './results.mjs';
1414
import {ResolvedTarget, findBenchmarkTargets, getTestlogPath, resolveTarget} from './targets.mjs';
@@ -36,19 +36,19 @@ await yargs(process.argv.slice(2))
3636
demandOption: true,
3737
})
3838
.positional('bazel-target', {description: 'Bazel target', type: 'string'}),
39-
(args) => runCompare(args.bazelTarget, args.compareRef)
39+
(args) => runCompare(args.bazelTarget, args.compareRef),
4040
)
4141
.command(
4242
'run [bazel-target]',
4343
'Runs a benchmark',
4444
(argv) => argv.positional('bazel-target', {description: 'Bazel target', type: 'string'}),
45-
(args) => runBenchmarkCmd(args.bazelTarget)
45+
(args) => runBenchmarkCmd(args.bazelTarget),
4646
)
4747
.command(
4848
'prepare-for-github-action <comment-body>',
4949
false, // Do not show in help.
5050
(argv) => argv.positional('comment-body', {demandOption: true, type: 'string'}),
51-
(args) => prepareForGitHubAction(args.commentBody)
51+
(args) => prepareForGitHubAction(args.commentBody),
5252
)
5353
.demandCommand()
5454
.scriptName('$0')
@@ -60,14 +60,10 @@ await yargs(process.argv.slice(2))
6060
async function promptForBenchmarkTarget(): Promise<string> {
6161
const targets = await findBenchmarkTargets();
6262

63-
return (
64-
await inquirer.prompt<{bazelTarget: string}>({
65-
name: 'bazelTarget',
66-
message: 'Select benchmark target to run:',
67-
type: 'list',
68-
choices: targets.map((t) => ({value: t, name: t})),
69-
})
70-
).bazelTarget;
63+
return await select({
64+
message: 'Select benchmark target to run:',
65+
choices: targets.map((t) => ({value: t, name: t})),
66+
});
7167
}
7268

7369
/**

0 commit comments

Comments
 (0)