Skip to content

Commit b6ff16b

Browse files
Fix incorrect pre-compiled-header usage (#468)
- Remove `#include <pch.h>` directive from source and header files as the benefits of using precompiled headers with cmake comes in not adding that compilation burder per translation unit. - The `target_precompile_headers()` cmake command was being used correctly, but the include statement negates the benefits https://cmake.org/cmake/help/latest/command/target_precompile_headers.html Co-authored-by: Mathew Benson <[email protected]>
1 parent e2fadae commit b6ff16b

File tree

65 files changed

+20
-85
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+20
-85
lines changed

Obelisk/EntryPoint.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <CLI/CLI.hpp>
32
#include <ZEngine/Core/Memory/MemoryManager.h>
43
#include <ZEngine/EngineConfiguration.h>

Obelisk/pch.cpp

Lines changed: 0 additions & 1 deletion
This file was deleted.

Tetragrama/Components/DockspaceUIComponent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <DockspaceUIComponent.h>
32
#include <Editor.h>
43
#include <Helpers/UIDispatcher.h>

Tetragrama/Components/HierarchyViewUIComponent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <Controllers/EditorCameraController.h>
32
#include <Editor.h>
43
#include <HierarchyViewUIComponent.h>

Tetragrama/Components/InspectorViewUIComponent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <Editor.h>
32
#include <InspectorViewUIComponent.h>
43
#include <UIComponentDrawerHelper.h>

Tetragrama/Components/LogUIComponent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <Helpers/MemoryOperations.h>
32
#include <LogUIComponent.h>
43
#include <SearchPatternAlgorithm.h>

Tetragrama/Components/ProjectViewUIComponent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <Editor.h>
32
#include <Helpers/SearchPatternAlgorithm.h>
43
#include <ProjectViewUIComponent.h>

Tetragrama/Components/SceneViewportUIComponent.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <Controllers/EditorCameraController.h>
32
#include <MessageToken.h>
43
#include <Messengers/Messenger.h>

Tetragrama/Editor.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <Controllers/EditorCameraController.h>
32
#include <Editor.h>
43
#include <MessageToken.h>

Tetragrama/EditorScene.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <pch.h>
21
#include <EditorScene.h>
32
#include <ZEngine/Managers/AssetManager.h>
43
#include <stack>
@@ -383,4 +382,4 @@ namespace Tetragrama
383382
asset_manager->LoadAssetFile(ZEngine::Importers::AssetImporterOutput{.Type = file.Type, .Path = file.Path.c_str(), .RootPath = file.RootPath.c_str()});
384383
}
385384
}
386-
} // namespace Tetragrama
385+
} // namespace Tetragrama

0 commit comments

Comments
 (0)