Enable CrossPlatform Builds and CI #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanPhilippeKernel
added
enhancement
JeanPhilippeKernel
requested changes
Aug 19, 2025
JeanPhilippeKernel
requested changes
Aug 19, 2025
|
@MathewBensonCode I think to make it easier you can break this PR into smaller PR's that focus on one thing at a time
that way its not overwhelming and things are fixed one at a time |
JeanPhilippeKernel
added
area-linux
JeanPhilippeKernel
requested changes
Aug 19, 2025
MathewBensonCode
pushed a commit
to MathewBensonCode/RendererEngine
that referenced
this pull request
Aug 20, 2025
MathewBensonCode
pushed a commit
to MathewBensonCode/RendererEngine
that referenced
this pull request
Aug 21, 2025
- install llvm20 for linux workflow and configure clang-format search paths for different linux options. - ShaderC download for linux matches the other systems and the previous hack to use system versions reverted. - Renamed the cmake imported targets for the ZEngine and Tetragrama dependencies. - Reatructured compile options and definitions for imgui, imguizmo and zengine - removed some erroneously included changes as requested. clang-format-20 ubuntu
|
I have tried to capture the requested changes in a single commit which we can now look into splitting up into smaller PRs as necessary. I found it a little tricky to split up because the changes were related but we can now discuss this further and you can let me know what you have in mind. |
MathewBensonCode
pushed a commit
to MathewBensonCode/RendererEngine
that referenced
this pull request
Aug 21, 2025
- install llvm20 for linux workflow and configure clang-format search paths for different linux options. - ShaderC download for linux matches the other systems and the previous hack to use system versions reverted. - Renamed the cmake imported targets for the ZEngine and Tetragrama dependencies. - Reatructured compile options and definitions for imgui, imguizmo and zengine - removed some erroneously included changes as requested. clang-format-20 ubuntu
MathewBensonCode
force-pushed
the
compile_on_linux
branch
from
ab77975 to
c4494f0
Compare
MathewBensonCode
changed the title
MathewBensonCode
changed the title
MathewBensonCode
force-pushed
the
compile_on_linux
branch
from
c4494f0 to
aebab1b
Compare
MathewBensonCode
force-pushed
the
compile_on_linux
branch
from
aebab1b to
e296ab7
Compare
JeanPhilippeKernel
requested changes
Aug 26, 2025
- Renamed variables that have the same name as the naming type as this wasn't compiling on GCC. - Replicated Linux CI workflow using Ninja Generator for Linux - Removed hard requirement for gcc and clang version 11 and use CMAKE_CXX_STANDARD = 20 enforce this. - Enabled Linux Output Paths in Panzerfaust.csproj - Add Search Paths for clang-format specific to possible location in different linux versions.(list may be incomplete for other distributions)
MathewBensonCode
force-pushed
the
compile_on_linux
branch
from
e296ab7 to
c0df1b4
Compare
jnyfah
requested changes
Aug 29, 2025
There was a problem hiding this comment.
i dont know why i cant comment on the file, but shared.ps1 add linux to the GlslangValidatorCandidates line 161
`
$GlslangValidatorCandidates = @(
'glslangValidator'
if ($IsWindows) {
Join-Path -Path $shaderCCompilerPath -ChildPath "\bin\glslangValidator.exe" # On Windows, the pipeline build might pick up this option...
}
if ($IsMacOS) {
Join-Path -Path $shaderCCompilerPath -ChildPath "\bin\glslangValidator" # On macOS, the pipeline build might pick up this option...
}
if ($IsLinux) {
Join-Path -Path $shaderCCompilerPath -ChildPath "\bin\glslangValidator"
}
)
`
jnyfah
approved these changes
Aug 29, 2025
jnyfah
requested changes
Aug 29, 2025
JeanPhilippeKernel
approved these changes
Aug 29, 2025
jnyfah
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to enable cross platform builds