Remove LLVM 20 limitation #485
Conversation
- clang-format ignore on CoroutineScheduler.h and VulkanDevice.h for operator bool() - update ubuntu CI workflow to use version 21.
| if ($IsLinux) { | ||
| '/usr/bin/clang-format' | ||
| '/usr/bin/clang-format-21' | ||
| '/usr/bin/clang-format-20' |
There was a problem hiding this comment.
That means we want to remove the clang-format-20 from candidate list
There was a problem hiding this comment.
I thought to leave it in as a precaution incase someone is still on the older platform. The main idea was to remove the restriction on newer versions but that compatibility with the older version is retained as specified in repoConfig.json
| run: sudo dpkg -i packages-microsoft-prod.deb | ||
|
|
||
| - name: Install LLVM-20 | ||
| - name: Install LLVM-21 |
There was a problem hiding this comment.
if we have to upgrade to LLVM-21 , that means we need to ensure that all platform we support , as well as pipeline agents have it available.
Also Readme need to be updated for contributors to be aware
There was a problem hiding this comment.
I put this change in the CI as a proof of concept that version 21 does work as well as version 20.
There was a problem hiding this comment.
Sure ! -
what I mean is that we need to propage the change to windows and macos as well
There was a problem hiding this comment.
Windows actually prompted the change as the default version moved to version 21. This is on developer machines. I used winget and it tracks the current stable version. I believe the same should be true for macOS.
Ubuntu and debian tend to be conservative so are always behind in their software versions, hence the need to specifically install version 20 and above. I think I recall that the ubuntu CI build would not work out of the box without this specific installation as the maximum they had available was version 19.
It may be possible to lower the requirement in the repoConfiguration.json to earlier versions and not have to bother with constraining user versions as it should just work everywhere...(hopefully).
3 participants
Closes #484