translations: Implement --release arg for the translation compilation scripts

Author: JeansBoussier

docs/windows_install.md

@@ -3,7 +3,6 @@ This section describes how to install the app (CLI and GUI) from source.
 
 > [!NOTE]
 > This is the Windows guide. If you're on Linux (or want to use WSL) follow the [Linux Installation](linux_install.md).
-> There is no native Windows pacakge yet, but you may be interested in the [Docker Image](../README.md#installation).
 
 1) Download and install system dependencies
 

packaging/docker/Dockerfile.Latest

@@ -8,7 +8,7 @@ RUN apt-get update \
     && rm -rf /var/lib/apt/lists/*
 RUN pip install --no-deps --no-cache-dir --requirement https://codeberg.org/ladaapp/lada/raw/main/packaging/requirements-cli.txt
 RUN curl -Ls https://codeberg.org/ladaapp/lada/archive/main.tar.gz | tar -zx \
-    && sh lada/translations/compile_po.sh zh_CN \
+    && sh lada/translations/compile_po.sh --release \
     && pip install --no-deps --no-cache-dir './lada[basicvsrpp]' \
     && patch -u -p4 -d /usr/local/lib/python3.13 < lada/patches/increase_mms_time_limit.patch \
     && patch -u -p4 -d /usr/local/lib/python3.13 < lada/patches/remove_ultralytics_telemetry.patch \

packaging/windows/README.md

@@ -38,7 +38,7 @@ Invoke-WebRequest 'https://huggingface.co/ladaapp/lada/resolve/main/lada_mosaic_
 Invoke-WebRequest 'https://huggingface.co/ladaapp/lada/resolve/main/lada_mosaic_restoration_model_generic_v1.2.pth?download=true' -OutFile ".\model_weights\lada_mosaic_restoration_model_generic_v1.2.pth"
 Invoke-WebRequest 'https://drive.usercontent.google.com/download?id=1ulct4RhRxQp1v5xwEmUH7xz7AK42Oqlw&export=download&confirm=t' -OutFile ".\model_weights\3rd_party\clean_youknow_video.pth"
 
-powershell .\translations/compile_po.ps1
+powershell .\translations/compile_po.ps1 --release
 ```
 
 Just do a quick test `lada`, drop in a video and see if it loads. If all looks good lets continue and create a package:

translations/README.md

@@ -0,0 +1,9 @@
+Use either `compile_po.ps1` or `compile_po.sh` to compile translations.
+
+If run without additional arguments all .po files will be compiled.
+
+To only compile translations that should land in a release run the script with `--release` argument.
+
+This will only consider translations contained in the file `release_ready_translations.txt` (single line, lang codes separated by spaces)
+
+Only if quality and completeness of a translation is good enough it should be added to that file.

translations/compile_po.ps1

@@ -6,15 +6,66 @@ if ((Get-Location).Path -ne $translationsDir) {
     Set-Location $translationsDir
 }
 
+$global:lang_filter = ""
+if ($args -contains "--release") {
+    $global:lang_filter = (Get-Content .\release_ready_translations.txt -Raw).Trim()
+    if ($global:lang_filter -eq "") {
+        Write-Host "No translations in .\release_ready_translations.txt"
+        return
+    }
+}
+
+function should_compile_po {
+    param (
+        [string]$lang
+    )
+
+    if (-not $global:lang_filter) {
+        return $true
+    }
+
+    foreach ($filter_lang in $global:lang_filter) {
+        if ($filter_lang -eq $lang) {
+            return $true
+        }
+    }
+
+    return $false
+}
+
+# Clean up compiled translations if there is no corresponding .po file anymore (deleted translations)
+Get-ChildItem -Directory -Path ..\lada\locale | ForEach-Object {
+    $langDir = $_.FullName
+    $lang = $_.Name
+
+    $poFile = "$lang.po"
+    if (-not (Test-Path $poFile)) {
+        $lcMessagesDir = Join-Path $langDir "LC_MESSAGES"
+        if (Test-Path $lcMessagesDir) {
+            Write-Host "Removing outdated compiled translations for language '$lang' at '$langDir'"
+            Remove-Item -Path $langDir -Recurse -Force
+        }
+    }
+}
+
+# Compile .po files
 Get-ChildItem -File -Filter "*.po" | ForEach-Object {
     $poFile = $_.Name
     $lang = $poFile -replace "\.po$"
 
+    if (-not (should_compile_po $lang)) {
+        $_langDir = "..\lada\locale\$lang"
+        if (Test-Path $_langDir) {
+            Remove-Item -Path $_langDir -Recurse -Force
+        }
+        return # actually a continue in a ForEach-Object loop
+    }
+
     $langDir = "..\lada\locale\$lang\LC_MESSAGES"
     if (-not (Test-Path -Path $langDir)) {
-        New-Item -ItemType Directory -Path $langDir -Force
+        New-Item -ItemType Directory -Path $langDir -Force | Out-Null
     }
 
     Write-Host "Compiling language '$lang' .po file into .mo file"
     & msgfmt $poFile -o "$langDir\lada.mo"
-}
+}

translations/compile_po.sh

@@ -8,7 +8,14 @@ if [ "$(pwd)" != "$translations_dir" ] ; then
   cd "$translations_dir"
 fi
 
-lang_filter="$@"
+lang_filter=""
+if [[ "$@" =~ "--release" ]]; then
+    lang_filter=$(cat release_ready_translations.txt | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
+    if [[ -z "$lang filter" ]]; then
+        echo "No translations in release_ready_translations.txt"
+        exit 1
+    fi
+fi
 
 function should_compile_po() {
   lang="$1"
@@ -23,9 +30,23 @@ function should_compile_po() {
   return 1
 }
 
+# Clean up compiled translations if there is no corresponding .po file anymore (deleted translations)
+find ../lada/locale/ -mindepth 2 -maxdepth 2 -type d -name LC_MESSAGES | while read lang_dir; do
+  lang=$(basename "$(dirname "$lang_dir")")
+  po_file="$lang.po"
+  if [ ! -f "$po_file" ]; then
+    rm -rf "$(dirname $lang_dir)"
+  fi
+done
+
+# Compile .po files
 find . -mindepth 1 -maxdepth 1 -type f -name "*.po" -printf '%f\n' | while read po_file ; do
   lang="${po_file%.po}"
-  should_compile_po $lang || continue
+  if ! should_compile_po $lang ; then
+    _lang_dir="../lada/locale/$lang"
+    [ -d "$_lang_dir" ] && rm -r "$_lang_dir"
+    continue
+  fi
   lang_dir="../lada/locale/$lang/LC_MESSAGES"
   if [ ! -d "$lang_dir" ] ; then
     mkdir -p "$lang_dir"

translations/release_ready_translations.txt

@@ -0,0 +1 @@
+zh_CN