Add exception handling in _do_callbacks (#554)

A single bad callback would crash _do_callbacks and prevent remaining
callbacks from executing. Now wraps each callback in try/except to
ensure all registered callbacks run even if one raises.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: JeffSteinbok

custom_components/dreo/pydreo/pydreobasedevice.py

@@ -190,13 +190,16 @@ def add_attr_callback(self, cb):
         self._attr_cbs.append(cb)
 
     def _do_callbacks(self):
-        """Run all registered callback"""
+        """Run all registered callbacks."""
         cbs = []
         with self._lock:
             for cb in self._attr_cbs:
                 cbs.append(cb)
         for cb in cbs:
-            cb()
+            try:
+                cb()
+            except Exception as ex:  # pylint: disable=broad-except
+                _LOGGER.error("_do_callbacks: Callback %s raised: %s", cb, ex)
 
     @property
     def device_definition(self) -> DreoDeviceDetails:

tests/pydreo/test_pydreobasedevice.py

@@ -0,0 +1,42 @@
+"""Tests for PyDreoBaseDevice callback safety."""
+import logging
+from unittest.mock import MagicMock, patch
+from .imports import * # pylint: disable=W0401,W0614
+from .testbase import TestBase
+
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.DEBUG)
+
+
+class TestPyDreoBaseDevice(TestBase):
+    """Test PyDreoBaseDevice class."""
+
+    def test_do_callbacks_continues_after_exception(self):
+        """Test that _do_callbacks continues executing remaining callbacks when one raises."""
+        self.get_devices_file_name = "get_devices_HSH009S.json"
+        self.pydreo_manager.load_devices()
+        device = self.pydreo_manager.devices[0]
+
+        cb1 = MagicMock()
+        cb2 = MagicMock(side_effect=RuntimeError("callback error"))
+        cb3 = MagicMock()
+
+        device.add_attr_callback(cb1)
+        device.add_attr_callback(cb2)
+        device.add_attr_callback(cb3)
+
+        device._do_callbacks()
+
+        # All three should have been called, even though cb2 raised
+        cb1.assert_called_once()
+        cb2.assert_called_once()
+        cb3.assert_called_once()
+
+    def test_do_callbacks_no_callbacks(self):
+        """Test _do_callbacks with no registered callbacks."""
+        self.get_devices_file_name = "get_devices_HSH009S.json"
+        self.pydreo_manager.load_devices()
+        device = self.pydreo_manager.devices[0]
+
+        # Should not raise
+        device._do_callbacks()