Skip to content

Commit 1dfa223

Browse files
mathieuouillonbaltzell
authored andcommitted
fix: geometry order of points that define the wire cell to satify a Concave Componment requierment for ALERT
1 parent a21aa3d commit 1dfa223

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

common-tools/clas-geometry/src/main/java/org/jlab/geom/detector/alert/AHDC/AlertDCFactory.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -195,18 +195,19 @@ public AlertDCLayer createLayer(ConstantProvider cp, int sectorId, int superlaye
195195
Point3D p_11 = new Point3D(px_11, py_11, zl);
196196
// defining a cell around a wireLine, must be counter-clockwise!
197197
firstF.add(p_0);
198-
firstF.add(p_1);
199-
firstF.add(p_2);
200-
firstF.add(p_3);
201-
firstF.add(p_4);
202198
firstF.add(p_5);
199+
firstF.add(p_4);
200+
firstF.add(p_3);
201+
firstF.add(p_2);
202+
firstF.add(p_1);
203203

204204
secondF.add(p_6);
205-
secondF.add(p_7);
206-
secondF.add(p_8);
207-
secondF.add(p_9);
208-
secondF.add(p_10);
209205
secondF.add(p_11);
206+
secondF.add(p_10);
207+
secondF.add(p_9);
208+
secondF.add(p_8);
209+
secondF.add(p_7);
210+
210211

211212
// Create the cell and signal wire inside
212213
// PrismaticComponent(int componentId, List<Point3D> firstFace, List<Point3D> secondFace)

common-tools/clas-geometry/src/main/java/org/jlab/geom/detector/alert/AHDC/ConcaveComponent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ protected ConcaveComponent(int componentId, List<Point3D> firstFace, List<Point3
6060
if (n.dot(direction) > 0.001) {
6161
// System.err.println("PrismaticComponent: #" + componentId + " " + n.dot(direction) + " > 0");
6262
// for (Point3D point : firstFace) System.err.println("\t" + point);
63-
throw new IllegalArgumentException("the first face is not counter-clockwise: componentId=" + componentId);
63+
throw new IllegalArgumentException("the first face is not counter-clockwise: componentId=" + componentId);
6464
}
6565
u = secondFace.get(1).vectorFrom(secondFace.get(0));
6666
v = secondFace.get(2).vectorFrom(secondFace.get(0));

0 commit comments

Comments
 (0)