prevent adding methods to the functions > and >=#90
Open
nsajko wants to merge 3 commits intoJeffreySarnoff:mainfrom
Open
prevent adding methods to the functions > and >=#90nsajko wants to merge 3 commits intoJeffreySarnoff:mainfrom
> and >=#90nsajko wants to merge 3 commits intoJeffreySarnoff:mainfrom
Conversation
Owner
|
Thank you. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
I reverted all deletions that might impact behavior. Now this PR just deletes methods such that there is obviously no change in behavior. |
As documented, the intended way to implement `>` is to add a method to `<`. Similarly with `>=`. A package should never add a method to either `>` or `>=`.
nsajko
force-pushed
the
prevent_adding_methods_fix
branch
from
d4d51bb to
c8c03eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented, the intended way to implement
>is to add a method to<. Similarly with>=. A package should never add a method to either>or>=.The
!=function should also usually not get any new methods.EDIT: some of the methods here behave differently than Julia's generic fallback. These methods are preserved with this change to prevent breakage.