Parsing error on linux-rockhip.inc file

[NunoBarix]

Bitbake is complaining about a parsing error. It appears to occur only when a defconfig is included in upper layers.

This is the bitbake output:
Error during parse shell code, the last 5 lines are: | ETA: 0:00:17 bbnote "Final scc/cfg list: $sccs_defconfig $bsp_definition $sccs $KERNEL_FEATURES_FINAL"

Commenting out sections of the recipes while tracing the issue indicates that the problem originates from the linux-rochip.inc file, with this specific line implicated:

cat ${KBUILD_DEFCONFIGS:-$CONFIGS} > ${KBUILD_DEFCONFIG} || true

Bitbake task functions do not support bash-style variable expansion with curly brackets and default values (i.e., ${VAR:-fallback}) or non-standard constructs.

I tested this only on scarthgap branch, but it may happen in other branches.

[JeffyCN]

Thanks for checking it. I don't have a setup on hand, so could you try it?

--- a/recipes-kernel/linux/linux-rockchip.inc
+++ b/recipes-kernel/linux/linux-rockchip.inc
@@ -52,11 +52,13 @@ do_kernel_metadata:prepend() {
        # Support defconfig fragments
        cd "${S}/arch/${ARCH}/configs"
        if [ ! -f "${KBUILD_DEFCONFIG}" ]; then
-               DEFCONFIGS="rockchip_linux_defconfig ${RK_SOC_FAMILY}_linux.config"
-               [ "${KBUILD_DEFCONFIGS}" ] || KBUILD_DEFCONFIGS="$DEFCONFIGS"
-
-               echo "Merging ${KBUILD_DEFCONFIGS} into ${KBUILD_DEFCONFIG}..."
-               cat ${KBUILD_DEFCONFIGS:-$CONFIGS} > ${KBUILD_DEFCONFIG} || true
+               for cfg in rockchip_linux_defconfig ${RK_SOC_FAMILY}.config \
+                       ${RK_SOC_FAMILY}_linux.config; do
+                       if [ -r ${cfg} ]; then
+                               echo "Merging ${cfg} into ${KBUILD_DEFCONFIG}..."
+                               cat ${cfg} >> ${KBUILD_DEFCONFIG}
+                       fi
+               done
        fi
        cd -
 }

[NunoBarix]

It still returns a parsing error.

Could this be a solution? It doesn't fail with this.

do_kernel_metadata:prepend() {
    # Force regenerating defconfig
    rm -f ${WORKDIR}/defconfig
 
    # Support defconfig fragments
    cd "${S}/arch/${ARCH}/configs"
    if [ ! -f "${KBUILD_DEFCONFIG}" ]; then
        DEFCONFIGS="rockchip_linux_defconfig ${RK_SOC_FAMILY}_linux.config"
        [ "${KBUILD_DEFCONFIGS}" ] || KBUILD_DEFCONFIGS="$DEFCONFIGS"
 
        echo "Merging ${KBUILD_DEFCONFIGS} into ${KBUILD_DEFCONFIG}..."
        #cat ${KBUILD_DEFCONFIGS:-$CONFIGS} > ${KBUILD_DEFCONFIG} || true
        if [ -n "${KBUILD_DEFCONFIGS}" ]; then
            cat "${KBUILD_DEFCONFIGS}" > "${KBUILD_DEFCONFIG}" || echo "Warning: failed to write KBUILD_DEFCONFIG"
        elif [ -n "${CONFIGS}" ]; then
            cat "${CONFIGS}" > "${KBUILD_DEFCONFIG}" || echo "Warning: failed to write CONFIGS to KBUILD_DEFCONFIG"
        else
            echo "Error: Neither KBUILD_DEFCONFIGS nor CONFIGS is set"
        fi
    fi
    cd -
}

[JeffyCN]

Can't reproduce this. Works fine for me. This code hasn't been touched in years and has been tested by many.
Am i missing something?