Skip to content

Commit 06a1457

Browse files
chore(deps): bump actions/download-artifact from 4 to 5 (#114)
* chore(deps): bump actions/download-artifact from 4 to 5 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 6819c25 commit 06a1457

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+1146
-1147
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ jobs:
225225
node-version: '20'
226226

227227
- name: 📥 Download all artifacts
228-
uses: actions/download-artifact@v4
228+
uses: actions/download-artifact@v5
229229
with:
230230
path: all-reports
231231

.github/workflows/frontend-tests.yml

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -23,37 +23,37 @@ jobs:
2323
test:
2424
name: Run JavaScript Tests
2525
runs-on: ubuntu-latest
26-
26+
2727
strategy:
2828
matrix:
2929
node-version: [18, 20]
30-
30+
3131
steps:
3232
- name: 📂 Checkout repository
3333
uses: actions/checkout@v5
34-
34+
3535
- name: 🟢 Setup Node.js ${{ matrix.node-version }}
3636
uses: actions/setup-node@v4
3737
with:
3838
node-version: ${{ matrix.node-version }}
3939
cache: 'npm'
40-
40+
4141
- name: 📦 Install dependencies
4242
run: |
4343
npm ci
4444
# Also install optional reporter if needed
4545
npm install jest-html-reporter --save-dev || true
46-
46+
4747
- name: 🧪 Run unit tests
4848
run: npm test -- --coverage --ci --maxWorkers=2
4949
env:
5050
CI: true
51-
51+
5252
- name: 📊 Generate coverage report
5353
if: matrix.node-version == '20' # Only run coverage on one version
5454
run: |
5555
npm run test:coverage || true
56-
56+
5757
- name: 📤 Upload coverage to Codecov
5858
if: matrix.node-version == '20'
5959
uses: codecov/codecov-action@v5
@@ -62,7 +62,7 @@ jobs:
6262
flags: frontend
6363
name: frontend-coverage
6464
fail_ci_if_error: false
65-
65+
6666
- name: 📋 Upload test results
6767
if: always()
6868
uses: actions/upload-artifact@v4
@@ -72,27 +72,27 @@ jobs:
7272
coverage/
7373
test-report.html
7474
retention-days: 7
75-
75+
7676
- name: 💬 Comment PR with results
7777
if: github.event_name == 'pull_request' && matrix.node-version == '20'
7878
uses: actions/github-script@v7
7979
with:
8080
script: |
8181
const fs = require('fs');
8282
let coverageText = '📊 **Frontend Test Coverage Report**\n\n';
83-
83+
8484
try {
8585
// Try to read coverage summary if it exists
8686
const coveragePath = './coverage/coverage-summary.json';
8787
if (fs.existsSync(coveragePath)) {
8888
const coverage = JSON.parse(fs.readFileSync(coveragePath, 'utf8'));
8989
const total = coverage.total;
90-
90+
9191
coverageText += '| Metric | Coverage | Status |\n';
9292
coverageText += '|--------|----------|--------|\n';
93-
93+
9494
const getStatus = (pct) => pct >= 80 ? '✅' : pct >= 70 ? '⚠️' : '❌';
95-
95+
9696
coverageText += `| Lines | ${total.lines.pct}% | ${getStatus(total.lines.pct)} |\n`;
9797
coverageText += `| Statements | ${total.statements.pct}% | ${getStatus(total.statements.pct)} |\n`;
9898
coverageText += `| Functions | ${total.functions.pct}% | ${getStatus(total.functions.pct)} |\n`;
@@ -103,19 +103,19 @@ jobs:
103103
} catch (error) {
104104
coverageText += `⚠️ Could not parse coverage report: ${error.message}\n`;
105105
}
106-
106+
107107
// Find and update or create comment
108108
const { data: comments } = await github.rest.issues.listComments({
109109
owner: context.repo.owner,
110110
repo: context.repo.repo,
111111
issue_number: context.issue.number,
112112
});
113-
114-
const botComment = comments.find(comment =>
115-
comment.user.type === 'Bot' &&
113+
114+
const botComment = comments.find(comment =>
115+
comment.user.type === 'Bot' &&
116116
comment.body.includes('Frontend Test Coverage Report')
117117
);
118-
118+
119119
if (botComment) {
120120
await github.rest.issues.updateComment({
121121
owner: context.repo.owner,
@@ -135,22 +135,22 @@ jobs:
135135
lint-js:
136136
name: Lint JavaScript
137137
runs-on: ubuntu-latest
138-
138+
139139
steps:
140140
- name: 📂 Checkout repository
141141
uses: actions/checkout@v5
142-
142+
143143
- name: 🟢 Setup Node.js
144144
uses: actions/setup-node@v4
145145
with:
146146
node-version: '20'
147147
cache: 'npm'
148-
148+
149149
- name: 📦 Install ESLint
150150
run: |
151151
npm install --save-dev eslint
152152
npm install --save-dev eslint-plugin-jest || true
153-
153+
154154
- name: 🔍 Run ESLint
155155
run: |
156156
npx eslint static/js/*.js --ignore-pattern "*.min.js" || true
@@ -160,42 +160,42 @@ jobs:
160160
name: Integration Tests
161161
runs-on: ubuntu-latest
162162
needs: test
163-
163+
164164
steps:
165165
- name: 📂 Checkout repository
166166
uses: actions/checkout@v5
167-
167+
168168
- name: 🟢 Setup Node.js
169169
uses: actions/setup-node@v4
170170
with:
171171
node-version: '20'
172172
cache: 'npm'
173-
173+
174174
- name: 💎 Setup Ruby
175175
uses: ruby/setup-ruby@v1
176176
with:
177177
ruby-version: '3.3'
178178
bundler-cache: true
179-
179+
180180
- name: 📦 Install dependencies
181181
run: |
182182
npm ci
183183
bundle install
184-
184+
185185
- name: 🏗️ Build Jekyll site
186186
run: |
187187
bundle exec jekyll build
188188
env:
189189
JEKYLL_ENV: test
190-
190+
191191
- name: 🧪 Run integration tests
192192
run: |
193193
npm run test:integration || echo "No integration tests yet"
194194
continue-on-error: true
195-
195+
196196
- name: 📤 Upload built site
197197
uses: actions/upload-artifact@v4
198198
with:
199199
name: built-site
200200
path: _site/
201-
retention-days: 1
201+
retention-days: 1

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,4 +176,3 @@ utils/tidy_conf/data/.tmp/
176176

177177
# Node modules
178178
node_modules/
179-

_config.test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ force_polling: false
9898
# Ensure JavaScript files are always fresh
9999
sass:
100100
style: expanded # Easier to debug
101-
sourcemap: never # Don't generate sourcemaps
101+
sourcemap: never # Don't generate sourcemaps

_config_dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# Development configuration - single language only
2-
languages: ["en"]
2+
languages: ["en"]

_includes/action_bar.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<!-- Check if conference is saved/series followed (would come from JavaScript) -->
77

88
<!-- Desktop: Colored Line Indicator -->
9-
<div class="action-indicator"
9+
<div class="action-indicator"
1010
role="button"
1111
tabindex="0"
1212
data-conf-id="{{ conf_id }}"
@@ -53,8 +53,8 @@
5353
</div>
5454

5555
<!-- Mobile: Bookmark Button -->
56-
<button class="mobile-action-bookmark"
56+
<button class="mobile-action-bookmark"
5757
data-conf-id="{{ conf_id }}"
5858
aria-label="Save conference">
5959
<i class="far fa-bookmark"></i>
60-
</button>
60+
</button>

_includes/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function update_filtering(data) {
55
} else {
66
// Fallback for legacy support
77
console.warn('ConferenceFilter module not loaded, using legacy filtering');
8-
8+
99
// Defensive check for data parameter
1010
if (!data || typeof data !== 'object') {
1111
console.error('update_filtering called with invalid data:', data);

_layouts/default.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</head>
1111
<body>
1212
{% include header.html %}
13-
13+
1414
{% if page.show_masthead %}
1515
{% capture masthead_title %}
1616
{% if page.masthead_title %}
@@ -19,36 +19,36 @@
1919
{% t page.title %}
2020
{% endif %}
2121
{% endcapture %}
22-
22+
2323
{% capture masthead_hook %}
2424
{% if page.masthead_hook %}
2525
{{ page.masthead_hook }}
2626
{% endif %}
2727
{% endcapture %}
28-
28+
2929
{% capture masthead_description %}
3030
{% if page.masthead_description %}
3131
{{ page.masthead_description }}
3232
{% endif %}
3333
{% endcapture %}
34-
34+
3535
{% include masthead.html url=page.url title=masthead_title hook=masthead_hook description=masthead_description %}
3636
{% endif %}
37-
37+
3838
<div class="container" id="main-content">
3939
{{ content }}
4040
</div>
41-
41+
4242
{% if page.extra_js %}
4343
{% for js in page.extra_js %}
4444
<script type="text/javascript" src="{{ js | prepend: site.baseurl_root }}?t={{site.time | date: '%s'}}"></script>
4545
{% endfor %}
4646
{% endif %}
47-
47+
4848
{% if page.include_footer %}
4949
<footer>{% include_cached footer.html %}</footer>
5050
{% else %}
5151
{% include sneks.html %}
5252
{% endif %}
5353
</body>
54-
</html>
54+
</html>

_layouts/home.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818
{{ content }}
1919

2020
<!-- Consolidated Conference Filtering -->
21-
<script type="text/javascript" src="{{ "/static/js/conference-filter.js" | prepend:site.baseurl_root }}?t={{site.time | date: '%s'}}"></script>
21+
<script type="text/javascript" src="{{ "/static/js/conference-filter.js" | prepend:site.baseurl_root }}?t={{site.time | date: '%s'}}"></script>

_layouts/page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
layout: default
33
---
44

5-
{{ content }}
5+
{{ content }}

0 commit comments

Comments
 (0)