fix: convert test infrastructure from ES6 modules to CommonJS

- Convert all test files from ES6 import/export to CommonJS require/module.exports
- Remove babel transform configuration from jest.config.js
- Expose NotificationManager to window for testing
- Add mock for FavoritesManager dependency
- Tests now run successfully in Jest/Node environment

Author: JesperDramsch

jest.config.js

@@ -69,10 +69,6 @@ module.exports = {
     '**/tests/frontend/**/*.spec.js'
   ],
 
-  // Transform files
-  transform: {
-    '^.+\\.js$': ['<rootDir>/tests/frontend/utils/jsTransform.js']
-  },
 
   // Global variables available in tests
   globals: {

static/js/notifications.js

@@ -466,3 +466,8 @@ const NotificationManager = {
 $(document).ready(function() {
     NotificationManager.init();
 });
+
+// Expose for testing
+if (typeof window !== 'undefined') {
+    window.NotificationManager = NotificationManager;
+}

tests/frontend/setup.js

@@ -3,7 +3,7 @@
  */
 
 // Add custom matchers from jest-dom
-import '@testing-library/jest-dom';
+require('@testing-library/jest-dom');
 
 // Set up global jQuery
 global.$ = global.jQuery = require('../../static/js/jquery.min.js');

tests/frontend/unit/countdown-simple.test.js

@@ -2,8 +2,8 @@
  * Tests for countdown-simple.js
  */
 
-import { TimerController, mockLuxonDateTime } from '../utils/mockHelpers';
-import { createConferenceWithDeadline, setupConferenceDOM } from '../utils/dataHelpers';
+const { TimerController, mockLuxonDateTime } = require('../utils/mockHelpers');
+const { createConferenceWithDeadline, setupConferenceDOM } = require('../utils/dataHelpers');
 
 describe('Countdown Timer System', () => {
   let timerController;

tests/frontend/unit/notifications.test.js

@@ -2,20 +2,20 @@
  * Tests for NotificationManager
  */
 
-import {
+const {
   mockNotificationAPI,
   mockStore,
   TimerController,
   mockBootstrapModal,
   mockPageVisibility
-} from '../utils/mockHelpers';
+} = require('../utils/mockHelpers');
 
-import {
+const {
   createConferenceWithDeadline,
   createSavedConferences,
   setupConferenceDOM,
   createConferenceSet
-} from '../utils/dataHelpers';
+} = require('../utils/dataHelpers');
 
 // We'll load the actual file in the test
 let NotificationManager;
@@ -37,11 +37,25 @@ describe('NotificationManager', () => {
     // Set current time
     timerController.setCurrentTime('2024-01-15 12:00:00');
 
-    // Load NotificationManager (it's an IIFE so it auto-initializes)
+    // Mock FavoritesManager (dependency of NotificationManager)
+    window.FavoritesManager = {
+      getSavedConferences: jest.fn(() => ({})),
+      showToast: jest.fn(),
+      init: jest.fn()
+    };
+
+    // Mock jQuery ready to prevent auto-init
+    const originalReady = $.fn.ready;
+    $.fn.ready = jest.fn();
+
+    // Load NotificationManager (it exposes itself to window)
     jest.isolateModules(() => {
       require('../../../static/js/notifications.js');
       NotificationManager = window.NotificationManager;
     });
+
+    // Restore jQuery ready
+    $.fn.ready = originalReady;
   });
 
   afterEach(() => {

tests/frontend/utils/dataHelpers.js

@@ -5,7 +5,7 @@
 /**
  * Generate mock conference data
  */
-export function createMockConference(overrides = {}) {
+function createMockConference(overrides = {}) {
   const baseDate = new Date();
   const cfpDate = new Date(baseDate);
   cfpDate.setDate(cfpDate.getDate() + 30); // CFP 30 days from now
@@ -42,7 +42,7 @@ export function createMockConference(overrides = {}) {
 /**
  * Create conference with specific days until deadline
  */
-export function createConferenceWithDeadline(daysUntilDeadline, overrides = {}) {
+function createConferenceWithDeadline(daysUntilDeadline, overrides = {}) {
   const cfpDate = new Date();
   cfpDate.setDate(cfpDate.getDate() + daysUntilDeadline);
   cfpDate.setHours(23, 59, 59, 0);
@@ -56,7 +56,7 @@ export function createConferenceWithDeadline(daysUntilDeadline, overrides = {})
 /**
  * Create past conference
  */
-export function createPastConference(daysPast = 30, overrides = {}) {
+function createPastConference(daysPast = 30, overrides = {}) {
   const cfpDate = new Date();
   cfpDate.setDate(cfpDate.getDate() - daysPast);
 
@@ -69,7 +69,7 @@ export function createPastConference(daysPast = 30, overrides = {}) {
 /**
  * Create DOM element for conference
  */
-export function createConferenceDOM(conference) {
+function createConferenceDOM(conference) {
   const div = document.createElement('div');
   div.className = 'ConfItem';
   div.id = conference.id;
@@ -127,7 +127,7 @@ export function createConferenceDOM(conference) {
 /**
  * Create multiple conferences with varied deadlines
  */
-export function createConferenceSet() {
+function createConferenceSet() {
   return {
     upcoming7Days: createConferenceWithDeadline(7, {
       id: 'conf-7days',
@@ -155,7 +155,7 @@ export function createConferenceSet() {
 /**
  * Create saved conferences structure for localStorage
  */
-export function createSavedConferences(conferences) {
+function createSavedConferences(conferences) {
   const saved = {};
   conferences.forEach(conf => {
     saved[conf.id] = {
@@ -170,7 +170,7 @@ export function createSavedConferences(conferences) {
 /**
  * Create series subscription data
  */
-export function createSeriesSubscription(seriesName, settings = {}) {
+function createSeriesSubscription(seriesName, settings = {}) {
   return {
     [seriesName.toLowerCase()]: {
       name: seriesName,
@@ -185,7 +185,7 @@ export function createSeriesSubscription(seriesName, settings = {}) {
 /**
  * Setup DOM with multiple conferences
  */
-export function setupConferenceDOM(conferences) {
+function setupConferenceDOM(conferences) {
   const container = document.createElement('div');
   container.id = 'conference-list';
   container.className = 'conference-list';
@@ -208,3 +208,15 @@ export function setupConferenceDOM(conferences) {
 
   return container;
 }
+
+// Export all data helpers
+module.exports = {
+  createMockConference,
+  createConferenceWithDeadline,
+  createPastConference,
+  createConferenceDOM,
+  createConferenceSet,
+  createSavedConferences,
+  createSeriesSubscription,
+  setupConferenceDOM
+};

tests/frontend/utils/mockHelpers.js

@@ -5,7 +5,7 @@
 /**
  * Mock Notification API
  */
-export function mockNotificationAPI(permission = 'default') {
+function mockNotificationAPI(permission = 'default') {
   const NotificationMock = jest.fn().mockImplementation(function(title, options) {
     this.title = title;
     this.body = options?.body;
@@ -40,7 +40,7 @@ export function mockNotificationAPI(permission = 'default') {
 /**
  * Mock localStorage with persistence within test
  */
-export function mockLocalStorage() {
+function mockLocalStorage() {
   const storage = {};
 
   const localStorageMock = {
@@ -76,7 +76,7 @@ export function mockLocalStorage() {
 /**
  * Mock store.js library
  */
-export function mockStore() {
+function mockStore() {
   const storage = new Map();
 
   const storeMock = {
@@ -98,7 +98,7 @@ export function mockStore() {
 /**
  * Mock timers with control
  */
-export class TimerController {
+class TimerController {
   constructor() {
     this.currentTime = new Date();
     jest.useFakeTimers();
@@ -148,7 +148,7 @@ export class TimerController {
 /**
  * Mock Bootstrap modal
  */
-export function mockBootstrapModal() {
+function mockBootstrapModal() {
   $.fn.modal = jest.fn(function(action) {
     if (action === 'show') {
       $(this).addClass('show');
@@ -181,7 +181,7 @@ export function mockBootstrapModal() {
 /**
  * Mock window.focus and document.hidden
  */
-export function mockPageVisibility(isVisible = true) {
+function mockPageVisibility(isVisible = true) {
   Object.defineProperty(document, 'hidden', {
     configurable: true,
     get: () => !isVisible
@@ -214,7 +214,7 @@ export function mockPageVisibility(isVisible = true) {
 /**
  * Mock Luxon DateTime
  */
-export function mockLuxonDateTime() {
+function mockLuxonDateTime() {
   if (!window.luxon) {
     // Simple mock if Luxon not loaded
     window.luxon = {
@@ -255,3 +255,14 @@ export function mockLuxonDateTime() {
   }
   return window.luxon;
 }
+
+// Export all mock helpers
+module.exports = {
+  mockNotificationAPI,
+  mockLocalStorage,
+  mockStore,
+  TimerController,
+  mockBootstrapModal,
+  mockPageVisibility,
+  mockLuxonDateTime
+};