Linting

Author: JesperDramsch

.github/workflows/smart-test-runner.yml

@@ -23,7 +23,7 @@ jobs:
       run-jekyll-build: ${{ steps.filter.outputs.jekyll }}
       is-data-only: ${{ steps.filter.outputs.data-only }}
       test-strategy: ${{ steps.strategy.outputs.strategy }}
-    
+
     steps:
       - name: 📂 Checkout repository
         uses: actions/checkout@v5
@@ -43,7 +43,7 @@ jobs:
               - 'package.json'
               - 'package-lock.json'
               - 'jest.config.js'
-            
+
             # Changes requiring E2E tests
             e2e:
               - 'static/js/**/*.js'
@@ -52,15 +52,15 @@ jobs:
               - '_pages/**'
               - 'tests/e2e/**'
               - 'playwright.config.js'
-            
+
             # Python utility changes
             python:
               - 'utils/**/*.py'
               - 'tests/python/**'
               - 'pixi.toml'
               - 'pyproject.toml'
               - 'requirements*.txt'
-            
+
             # Jekyll/Ruby changes
             jekyll:
               - '_config*.yml'
@@ -69,7 +69,7 @@ jobs:
               - '_includes/**'
               - '_sass/**'
               - 'Gemfile*'
-            
+
             # Data-only changes (no tests needed)
             data-only:
               - '_data/conferences.yml'
@@ -116,25 +116,25 @@ jobs:
           script: |
             const strategy = '${{ steps.strategy.outputs.strategy }}';
             let comment = '## 🧪 Test Strategy Analysis\n\n';
-            
+
             const changes = {
               frontend: ${{ steps.filter.outputs.frontend }},
               e2e: ${{ steps.filter.outputs.e2e }},
               python: ${{ steps.filter.outputs.python }},
               jekyll: ${{ steps.filter.outputs.jekyll }},
               dataOnly: ${{ steps.filter.outputs.data-only }}
             };
-            
+
             comment += '### 📊 Detected Changes:\n';
             comment += `- Frontend JS: ${changes.frontend ? '✅ Yes' : '❌ No'}\n`;
             comment += `- E2E Required: ${changes.e2e ? '✅ Yes' : '❌ No'}\n`;
             comment += `- Python Utils: ${changes.python ? '✅ Yes' : '❌ No'}\n`;
             comment += `- Jekyll Config: ${changes.jekyll ? '✅ Yes' : '❌ No'}\n`;
             comment += `- Data Only: ${changes.dataOnly ? '✅ Yes' : '❌ No'}\n`;
             comment += '\n';
-            
+
             comment += '### 🎯 Test Strategy: `' + strategy + '`\n\n';
-            
+
             switch(strategy) {
               case 'data-validation-only':
                 comment += '✨ **Optimized Run**: Only conference data validation will run.\n';
@@ -152,21 +152,21 @@ jobs:
               default:
                 comment += '✅ **Minimal Checks**: Running basic validation only.\n';
             }
-            
+
             comment += '\n💰 **Cost Savings**: This intelligent test selection reduces unnecessary CI runs.';
-            
+
             // Find and update or create comment
             const { data: comments } = await github.rest.issues.listComments({
               owner: context.repo.owner,
               repo: context.repo.repo,
               issue_number: context.issue.number,
             });
-            
+
             const botComment = comments.find(comment =>
               comment.user.type === 'Bot' &&
               comment.body.includes('Test Strategy Analysis')
             );
-            
+
             if (botComment) {
               await github.rest.issues.updateComment({
                 owner: context.repo.owner,
@@ -189,23 +189,23 @@ jobs:
     needs: analyze-changes
     if: always()  # Always run data validation
     runs-on: ubuntu-latest
-    
+
     steps:
       - name: 📂 Checkout repository
         uses: actions/checkout@v5
-      
+
       - name: 🐍 Setup Pixi
         uses: prefix-dev/[email protected]
-      
+
       - name: ✅ Validate conference data
         run: |
           pixi run sort --check
           pixi run validate
-      
+
       - name: 📊 Check for duplicates
         run: |
           python utils/check_duplicates.py || true
-      
+
       - name: 🔗 Validate URLs (sample)
         if: needs.analyze-changes.outputs.is-data-only == 'true'
         run: |
@@ -234,14 +234,14 @@ jobs:
     needs: analyze-changes
     if: needs.analyze-changes.outputs.run-python-tests == 'true'
     runs-on: ubuntu-latest
-    
+
     steps:
       - name: 📂 Checkout repository
         uses: actions/checkout@v5
-      
+
       - name: 🐍 Setup Pixi
         uses: prefix-dev/[email protected]
-      
+
       - name: 🧪 Run Python tests
         run: |
           pixi run test
@@ -252,17 +252,17 @@ jobs:
     needs: analyze-changes
     if: needs.analyze-changes.outputs.run-jekyll-build == 'true'
     runs-on: ubuntu-latest
-    
+
     steps:
       - name: 📂 Checkout repository
         uses: actions/checkout@v5
-      
+
       - name: 💎 Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: '3.3'
           bundler-cache: true
-      
+
       - name: 🏗️ Test Jekyll build
         run: |
           bundle exec jekyll build
@@ -275,7 +275,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [data-validation, frontend-tests, e2e-tests, python-tests, jekyll-build-test]
     if: always()
-    
+
     steps:
       - name: ✅ All tests passed
         if: |
@@ -287,7 +287,7 @@ jobs:
         run: |
           echo "✅ All required tests passed!"
           echo "Test strategy successfully reduced unnecessary runs."
-      
+
       - name: ❌ Some tests failed
         if: |
           needs.data-validation.result == 'failure' ||

tests/e2e/specs/conference-filters.spec.js

@@ -452,4 +452,4 @@ test.describe('Conference Filters', () => {
       }
     });
   });
-});
+});

tests/e2e/specs/search-functionality.spec.js

@@ -400,4 +400,4 @@ test.describe('Search Functionality', () => {
       await expect(results).toBeVisible();
     });
   });
-});
+});

tests/frontend/unit/action-bar.test.js

@@ -189,7 +189,7 @@ describe('ActionBar', () => {
 
     test('should handle empty preferences gracefully', () => {
       storeMock.get.mockReturnValue(null);
-      
+
       // Should not throw
       expect(() => {
         document.querySelectorAll('.action-indicator').forEach(indicator => {
@@ -317,10 +317,10 @@ describe('ActionBar', () => {
 
     test('should handle tap interactions on mobile', () => {
       const indicator = document.querySelector('.action-indicator[data-conf-id="pycon-2025"]');
-      
+
       const touchEvent = new TouchEvent('touchstart');
       indicator.dispatchEvent(touchEvent);
-      
+
       // Mobile should show popover on tap
       expect(document.querySelector('.action-content')).toBeDefined();
     });
@@ -329,7 +329,7 @@ describe('ActionBar', () => {
   describe('Conference Data Extraction', () => {
     test('should extract conference data from indicator attributes', () => {
       const indicator = document.querySelector('.action-indicator[data-conf-id="pycon-2025"]');
-      
+
       expect(indicator.dataset.confId).toBe('pycon-2025');
       expect(indicator.dataset.confName).toBe('PyCon US');
       expect(indicator.dataset.confCfp).toBe('2025-02-15 23:59:00');
@@ -374,7 +374,7 @@ describe('ActionBar', () => {
       const clickEvent = new MouseEvent('click', { bubbles: true });
       Object.defineProperty(clickEvent, 'target', { value: saveBtn, enumerable: true });
       document.dispatchEvent(clickEvent);
-      
+
       expect(window.dispatchEvent).toHaveBeenCalledWith(
         expect.objectContaining({
           type: 'favoritesUpdated',
@@ -392,9 +392,9 @@ describe('ActionBar', () => {
           savedConferences: {}
         }
       });
-      
+
       window.dispatchEvent(event);
-      
+
       // Indicators should update based on event
       const indicator = document.querySelector('.action-indicator[data-conf-id="pycon-2025"]');
       // Would need actual event handler implementation
@@ -406,7 +406,7 @@ describe('ActionBar', () => {
       storeMock.get.mockImplementation(() => {
         throw new Error('localStorage unavailable');
       });
-      
+
       // Should not throw
       expect(() => {
         document.querySelectorAll('.action-indicator').forEach(indicator => {
@@ -420,7 +420,7 @@ describe('ActionBar', () => {
       indicator.className = 'action-indicator';
       // No data-conf-id
       document.body.appendChild(indicator);
-      
+
       // Should not process indicators without conf-id
       expect(() => {
         document.querySelectorAll('.action-indicator').forEach(ind => {

tests/frontend/unit/conference-manager.test.js

@@ -488,4 +488,4 @@ describe('ConferenceStateManager', () => {
       expect(manager.archiveLoaded).toBe(false);
     });
   });
-});
+});