UOE from ModelAccessNoLimit.runWriteAction due to stale FileDataSource listeners of modules still registered with ModuleLoader's repository

Author: artem-tikhomirov

plugins/mps-build/languages/build.mps/source_gen.caches/jetbrains/mps/build/mps/util/dependencies

@@ -173,6 +173,7 @@
     <classNode dependClassName="java.lang.UnsupportedOperationException" />
     <classNode dependClassName="java.util.ArrayList" />
     <classNode dependClassName="java.util.HashMap" />
+    <classNode dependClassName="java.util.List" />
     <classNode dependClassName="java.util.Map" />
     <classNode dependClassName="java.util.Objects" />
     <classNode dependClassName="jetbrains.mps.build.behavior.BuildSourcePath__BehaviorDescriptor" />
@@ -181,11 +182,13 @@
     <classNode dependClassName="jetbrains.mps.build.mps.util.PathConverter" />
     <classNode dependClassName="jetbrains.mps.build.mps.util.VisibleModules" />
     <classNode dependClassName="jetbrains.mps.build.util.Context" />
+    <classNode dependClassName="jetbrains.mps.extapi.module.SModuleBase" />
     <classNode dependClassName="jetbrains.mps.extapi.module.SRepositoryBase" />
     <classNode dependClassName="jetbrains.mps.extapi.module.SRepositoryExt" />
     <classNode dependClassName="jetbrains.mps.generator.template.TemplateQueryContext" />
     <classNode dependClassName="jetbrains.mps.internal.collections.runtime.IVisitor" />
     <classNode dependClassName="jetbrains.mps.internal.collections.runtime.IWhereFilter" />
+    <classNode dependClassName="jetbrains.mps.internal.collections.runtime.ListSequence" />
     <classNode dependClassName="jetbrains.mps.internal.collections.runtime.Sequence" />
     <classNode dependClassName="jetbrains.mps.lang.smodel.generator.smodelAdapter.SLinkOperations" />
     <classNode dependClassName="jetbrains.mps.lang.smodel.generator.smodelAdapter.SNodeOperations" />
@@ -202,6 +205,7 @@
     <classNode dependClassName="jetbrains.mps.smodel.MPSModuleOwner" />
     <classNode dependClassName="jetbrains.mps.smodel.ModuleRepositoryFacade" />
     <classNode dependClassName="jetbrains.mps.smodel.adapter.structure.MetaAdapterFactory" />
+    <classNode dependClassName="jetbrains.mps.util.IterableUtil" />
     <classNode dependClassName="jetbrains.mps.util.MacroHelper" />
     <classNode dependClassName="jetbrains.mps.vfs.FileSystem" />
     <classNode dependClassName="jetbrains.mps.vfs.IFile" />

plugins/mps-build/languages/build.mps/source_gen.caches/jetbrains/mps/build/mps/util/generated

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<product version="3" modelHash="coeljdt38uk7a6b10d23tttlq4l8z1h">
+<product version="3" modelHash="-42ewhpzdf120o23qxq5uyy5mwxa925">
   <files names="ArtifactsRelativePathHelper.java:MPSModulesClosure.java:MPSModulesPartitioner.java:ModuleChecker.java:ModuleFinder.java:ModuleLoader.java:ModuleLoaderException.java:ModuleLoaderUtils.java:ModulePlugins.java:PathBuilder.java:PathConverter.java:RequiredPlugins.java:VisibleModules.java" />
 </product>
 

plugins/mps-build/languages/build.mps/source_gen/jetbrains/mps/build/mps/util/ModuleChecker.java

@@ -118,7 +118,7 @@ public void check(ModuleChecker.CheckType type) {
       checkModule(type);
     }
     if (myRepository != null && myLoadedModule != null) {
-      // XXX in case myMudyle is _Language, there' might be another _Generator that references it, and we need to keep module registered. 
+      // XXX in case myModule is _Language, there' might be another _Generator that references it, and we need to keep module registered. 
       // Don't want to deal with different module kinds right now (i.e. can drop _Solution and _Generator here) 
       myLoadedModule = null;
     }

plugins/mps-build/languages/build.mps/source_gen/jetbrains/mps/build/mps/util/ModuleLoader.java

@@ -19,6 +19,11 @@
 import jetbrains.mps.internal.collections.runtime.Sequence;
 import jetbrains.mps.internal.collections.runtime.IWhereFilter;
 import jetbrains.mps.internal.collections.runtime.IVisitor;
+import java.util.List;
+import org.jetbrains.mps.openapi.module.SModule;
+import jetbrains.mps.util.IterableUtil;
+import jetbrains.mps.internal.collections.runtime.ListSequence;
+import jetbrains.mps.extapi.module.SModuleBase;
 import jetbrains.mps.build.behavior.BuildSourcePath__BehaviorDescriptor;
 import jetbrains.mps.lang.smodel.generator.smodelAdapter.SPropertyOperations;
 import java.io.File;
@@ -34,7 +39,6 @@
 import org.jetbrains.mps.openapi.module.ModelAccess;
 import java.util.Map;
 import org.jetbrains.mps.openapi.module.SModuleId;
-import org.jetbrains.mps.openapi.module.SModule;
 import java.util.HashMap;
 import jetbrains.mps.smodel.MPSModuleOwner;
 import jetbrains.mps.project.AbstractModule;
@@ -98,7 +102,20 @@ public void visit(SNode it) {
     });
 
     // XXX would be great to unregister all modules here, to dispose them explicitly, but as long as its our private repo, does it matter? 
+    // We have to dispose modules as their models/datasources attach e.g. file listeners that get notified long time after generation of a build project is over. 
     // BEWARE, don't ever try to do myRepository.dispose(). MRF is CoreComponent AND singleton, dispose just makes subsequent MRF.getInstance() (yes, there are still few out there) to fail with NPE 
+    if (myRepository != null) {
+      // MRF has distinction between 'true' repo and a global one it looks into at certain moments, beware to use proper one 
+      List<SModule> modules = IterableUtil.copyToList(myRepository.getRepository().getModules());
+      for (SModule m : ListSequence.fromList(modules)) {
+        // would be great to myRepository.unregisterModule(m) here, but there are 2 obstacles: 
+        // first, MRF doesn't use true repo; second, we need to know module owner which is internal class in ModuleChecker now 
+        // As I'm about to throw myRepository away, I don't care that much it is to hold information about disposed modules 
+        if (m instanceof SModuleBase) {
+          ((SModuleBase) m).dispose();
+        }
+      }
+    }
   }
 
   public ModuleChecker createModuleChecker(SNode module) {