Skip to content

Commit 6aad554

Browse files
committed
Address PR feedback.
1 parent c815098 commit 6aad554

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/dsl/AppCdsSettings.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ abstract class AppCdsConfiguration {
1818
*/
1919
@Suppress("MemberVisibilityCanBePrivate")
2020
var logging: Boolean = false
21+
}
2122

22-
/**
23-
* Returns the AppCDS-related arguments to pass the JVM when running the app.
24-
*/
25-
internal fun runtimeJvmArgs() = buildList {
26-
addAll(mode.runtimeJvmArgs())
27-
if (logging) add("-Xlog:cds")
28-
}
23+
/**
24+
* Returns the AppCDS-related arguments to pass the JVM when running the app.
25+
*/
26+
internal fun AppCdsConfiguration.runtimeJvmArgs() = buildList {
27+
addAll(mode.runtimeJvmArgs())
28+
if (logging) add("-Xlog:cds")
2929
}
3030

3131
/**

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/configureJvmApplication.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import org.gradle.api.tasks.Sync
1313
import org.gradle.api.tasks.TaskProvider
1414
import org.gradle.jvm.tasks.Jar
1515
import org.jetbrains.compose.desktop.application.dsl.TargetFormat
16+
import org.jetbrains.compose.desktop.application.dsl.runtimeJvmArgs
1617
import org.jetbrains.compose.desktop.application.internal.validation.validatePackageVersions
1718
import org.jetbrains.compose.desktop.application.tasks.*
1819
import org.jetbrains.compose.desktop.tasks.AbstractJarsFlattenTask

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/tasks/AbstractCreateAppCdsArchiveTask.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ abstract class AbstractCreateAppCdsArchiveTask @Inject constructor(
2323
internal val packageName: Provider<String> = createDistributable.flatMap { it.packageName }
2424

2525
@get:Input
26-
internal val appCdsMode: Property<AppCdsMode> = objects.notNullProperty()
26+
internal abstract val appCdsMode: Property<AppCdsMode>
2727

2828
@Suppress("unused")
2929
@OutputFile

0 commit comments

Comments
 (0)