Skip to content

Commit ce00896

Browse files
authored
update test projects for gradle plugin to use direct dependencies (#5469)
Update test projects for Gradle plugin to use direct dependencies instead of aliases Describe proposed changes and the issue being fixed Fixes [CMP-9183](https://youtrack.jetbrains.com/issue/CMP-9183) ## Testing Existing tests should continue to pass ## Release Notes N/A
1 parent a82ee3e commit ce00896

File tree

43 files changed

+101
-100
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+101
-100
lines changed

gradle-plugins/compose/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ for (gradleVersion in supportedGradleVersions) {
207207
configureAllTests {
208208
dependsOn(":publishToMavenLocal")
209209
systemProperty("compose.tests.compose.gradle.plugin.version", BuildProperties.deployVersion(project))
210+
systemProperty("compose.tests.compose.version", BuildProperties.composeVersion(project))
210211
val summaryDir = project.layout.buildDirectory.get().asFile.resolve("test-summary")
211212
systemProperty("compose.tests.summary.file", summaryDir.resolve("$name.md").absolutePath)
212213
systemProperties(project.properties.filter { it.key.startsWith("compose.") })

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ abstract class ComposePlugin : Plugin<Project> {
8686
@Deprecated("Specify dependency via version catalog", replaceWith = ReplaceWith("\"org.jetbrains.compose.ui:ui-test:${ComposeBuildConfig.composeVersion}\""))
8787
@ExperimentalComposeLibrary
8888
val uiTest get() = composeDependency("org.jetbrains.compose.ui:ui-test")
89-
@Deprecated("Use org.jetbrains.compose.ui:ui-tooling-preview module instead", replaceWith = ReplaceWith("\"org.jetbrains.compose.ui:ui-tooling:${ComposeBuildConfig.composeVersion}\""))
89+
@Deprecated("Use org.jetbrains.compose.ui:ui-tooling module instead", replaceWith = ReplaceWith("\"org.jetbrains.compose.ui:ui-tooling:${ComposeBuildConfig.composeVersion}\""))
9090
val uiTooling get() = composeDependency("org.jetbrains.compose.ui:ui-tooling")
9191
@Deprecated("Specify dependency via version catalog", replaceWith = ReplaceWith("\"org.jetbrains.compose.ui:ui-util:${ComposeBuildConfig.composeVersion}\""))
9292
val uiUtil get() = composeDependency("org.jetbrains.compose.ui:ui-util")

gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/ResourcesTest.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -549,8 +549,8 @@ class ResourcesTest : GradlePluginTestBase() {
549549

550550
modifyText("build.gradle.kts") { str ->
551551
str.replace(
552-
"api(compose.components.resources)",
553-
"//api(compose.components.resources)"
552+
"api(\"org.jetbrains.compose.components:components-resources:${defaultTestEnvironment.composeVersion}\")",
553+
"//api(\"org.jetbrains.compose.components:components-resources:${defaultTestEnvironment.composeVersion}\")"
554554
)
555555
}
556556
gradle("prepareKotlinIdeaImport").checks {
@@ -559,8 +559,8 @@ class ResourcesTest : GradlePluginTestBase() {
559559

560560
modifyText("build.gradle.kts") { str ->
561561
str.replace(
562-
"//api(compose.components.resources)",
563-
"api(compose.components.resources)"
562+
"//api(\"org.jetbrains.compose.components:components-resources:${defaultTestEnvironment.composeVersion}\")",
563+
"api(\"org.jetbrains.compose.components:components-resources:${defaultTestEnvironment.composeVersion}\")"
564564
)
565565
}
566566
modifyText("build.gradle.kts") { str ->
@@ -735,9 +735,9 @@ class ResourcesTest : GradlePluginTestBase() {
735735
| sourceSets {
736736
| commonMain {
737737
| dependencies {
738-
| implementation(compose.runtime)
739-
| implementation(compose.material)
740-
| implementation(compose.components.resources)
738+
| implementation("org.jetbrains.compose.runtime:runtime:${defaultTestEnvironment.composeVersion}")
739+
| implementation("org.jetbrains.compose.material:material:${defaultTestEnvironment.composeVersion}")
740+
| implementation("org.jetbrains.compose.components:components-resources:${defaultTestEnvironment.composeVersion}")
741741
| }
742742
| }
743743
| }
@@ -784,9 +784,9 @@ class ResourcesTest : GradlePluginTestBase() {
784784
| sourceSets {
785785
| commonMain {
786786
| dependencies {
787-
| implementation(compose.runtime)
788-
| implementation(compose.material)
789-
| implementation(compose.components.resources)
787+
| implementation("org.jetbrains.compose.runtime:runtime:${defaultTestEnvironment.composeVersion}")
788+
| implementation("org.jetbrains.compose.material:material:${defaultTestEnvironment.composeVersion}")
789+
| implementation("org.jetbrains.compose.components:components-resources:${defaultTestEnvironment.composeVersion}")
790790
| }
791791
| }
792792
| }

gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/WebCompatibilityDistributionTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class WebCompatibilityDistributionTest : GradlePluginTestBase() {
3434
}
3535

3636
private fun TestProject.applyBuildConfig(caseName: String) {
37-
file("build.gradle.kts.${caseName}").renameTo(file("build.gradle.kts"))
37+
file("build.${caseName}.gradle.kts").renameTo(file("build.gradle.kts"))
3838
}
3939

4040
@Test

gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/utils/TestProject.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ data class TestEnvironment(
1818
val gradleVersion: String = TestProperties.gradleVersion,
1919
val agpVersion: String = TestProperties.agpVersion,
2020
val composeGradlePluginVersion: String = TestProperties.composeGradlePluginVersion,
21+
val composeVersion: String = TestProperties.composeVersion,
2122
val mokoResourcesPluginVersion: String = "0.23.0",
2223
val composeCompilerPlugin: String? = null,
2324
val composeCompilerArgs: String? = null,
@@ -27,6 +28,7 @@ data class TestEnvironment(
2728
) {
2829
private val placeholders = linkedMapOf(
2930
"COMPOSE_GRADLE_PLUGIN_VERSION_PLACEHOLDER" to composeGradlePluginVersion,
31+
"COMPOSE_VERSION_PLACEHOLDER" to composeVersion,
3032
"KOTLIN_VERSION_PLACEHOLDER" to kotlinVersion,
3133
"AGP_VERSION_PLACEHOLDER" to agpVersion,
3234
"COMPOSE_COMPILER_PLUGIN_PLACEHOLDER" to composeCompilerPlugin,

gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/utils/TestProperties.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ object TestProperties {
1414
val composeGradlePluginVersion: String
1515
get() = notNullSystemProperty("compose.tests.compose.gradle.plugin.version")
1616

17+
val composeVersion: String
18+
get() = notNullSystemProperty("compose.tests.compose.version")
19+
1720
val gradleVersion: String
1821
get() = notNullSystemProperty("compose.tests.gradle.version")
1922

gradle-plugins/compose/src/test/test-projects/application/jsMpp/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ kotlin {
1515
}
1616
named("jsMain") {
1717
dependencies {
18-
implementation(compose.html.core)
19-
implementation(compose.runtime)
18+
implementation("org.jetbrains.compose.html:html-core:COMPOSE_VERSION_PLACEHOLDER")
19+
implementation("org.jetbrains.compose.runtime:runtime:COMPOSE_VERSION_PLACEHOLDER")
2020
}
2121
}
2222
named("jvmMain") {

gradle-plugins/compose/src/test/test-projects/application/newAndroidTarget/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ kotlin {
1818
sourceSets {
1919
getByName("commonMain") {
2020
dependencies {
21-
implementation(compose.ui)
22-
implementation(compose.runtime)
23-
implementation(compose.foundation)
24-
implementation(compose.material3)
21+
implementation("org.jetbrains.compose.ui:ui:COMPOSE_VERSION_PLACEHOLDER")
22+
implementation("org.jetbrains.compose.runtime:runtime:COMPOSE_VERSION_PLACEHOLDER")
23+
implementation("org.jetbrains.compose.foundation:foundation:COMPOSE_VERSION_PLACEHOLDER")
24+
implementation("org.jetbrains.compose.material3:material3:1.9.0")
2525
}
2626
}
2727
}

gradle-plugins/compose/src/test/test-projects/application/proguard/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ dependencies {
1212
implementation "org.jetbrains.kotlin:kotlin-stdlib"
1313
implementation "org.jetbrains.kotlinx:kotlinx-serialization-core:1.9.0"
1414
implementation compose.desktop.currentOs
15-
implementation compose.material3
15+
// material3 is not used, but it is a part of the test
16+
implementation "org.jetbrains.compose.material3:material3:1.9.0"
1617
}
1718

1819
compose.desktop {

gradle-plugins/compose/src/test/test-projects/application/webApp/build.gradle.kts.WebApp renamed to gradle-plugins/compose/src/test/test-projects/application/webApp/build.WebApp.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ kotlin {
1717

1818
sourceSets {
1919
commonMain.dependencies {
20-
implementation(compose.runtime)
20+
implementation("org.jetbrains.compose.runtime:runtime:COMPOSE_VERSION_PLACEHOLDER")
2121
}
2222

2323
val webMain by creating { dependsOn(commonMain.get()) }

0 commit comments

Comments
 (0)