Skip to content

Commit d3b05fd

Browse files
committed
Fix ResourcesTest
1 parent e7c66b6 commit d3b05fd

File tree

3 files changed

+14
-28
lines changed

3 files changed

+14
-28
lines changed

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/ComposeResources.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ private fun Project.onKgpApplied(config: Provider<ResourcesExtension>, kgp: Kotl
3636

3737
if (kmpResourcesAreAvailable) {
3838
configureMultimoduleResources(kotlinExtension, config)
39-
configureXCFrameworkComposeResources(kotlinExtension, kgp)
39+
configureXCFrameworkComposeResources(kotlinExtension)
4040
} else {
4141
if (!disableMultimoduleResources) {
4242
if (!hasKmpResources) logger.info(
Lines changed: 11 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,30 @@
11
package org.jetbrains.compose.resources
22

33
import org.gradle.api.Project
4-
import org.jetbrains.compose.internal.Version
54
import org.jetbrains.kotlin.gradle.ComposeKotlinGradlePluginApi
65
import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
7-
import org.jetbrains.kotlin.gradle.plugin.KotlinBasePlugin
86
import org.jetbrains.kotlin.gradle.plugin.extraProperties
97
import org.jetbrains.kotlin.gradle.plugin.mpp.Framework
108
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinNativeTarget
119
import org.jetbrains.kotlin.gradle.plugin.mpp.apple.XCFrameworkTask
1210
import org.jetbrains.kotlin.gradle.plugin.mpp.resources.KotlinTargetResourcesPublication
1311

14-
private const val MIN_KGP_VERSION_FOR_XCFRAMEWORK_RESOURCES = "2.2.0-Beta2-1"
15-
1612
@OptIn(ComposeKotlinGradlePluginApi::class)
1713
internal fun Project.configureXCFrameworkComposeResources(
18-
kotlinExtension: KotlinMultiplatformExtension,
19-
kgp: KotlinBasePlugin
14+
kotlinExtension: KotlinMultiplatformExtension
2015
) {
21-
val kgpVersion = Version.fromString(kgp.pluginVersion)
2216
val kmpResources = extraProperties.get(KMP_RES_EXT) as KotlinTargetResourcesPublication
23-
val requiredVersion = Version.fromString(MIN_KGP_VERSION_FOR_XCFRAMEWORK_RESOURCES)
24-
val isAvailable = kgpVersion >= requiredVersion
25-
2617
tasks.withType(XCFrameworkTask::class.java).configureEach { task ->
27-
if (isAvailable) {
28-
logger.info("Configure compose resources in ${task.name}")
29-
kotlinExtension.targets
30-
.withType(KotlinNativeTarget::class.java)
31-
.configureEach { target ->
32-
target.binaries.withType(Framework::class.java).configureEach { framework ->
33-
task.addTargetResources(
34-
resources = kmpResources.resolveResources(target),
35-
target = framework.target.konanTarget
36-
)
37-
}
18+
logger.info("Configure compose resources in ${task.name}")
19+
kotlinExtension.targets
20+
.withType(KotlinNativeTarget::class.java)
21+
.configureEach { target ->
22+
target.binaries.withType(Framework::class.java).configureEach { framework ->
23+
task.addTargetResources(
24+
resources = kmpResources.resolveResources(target),
25+
target = framework.target.konanTarget
26+
)
3827
}
39-
} else {
40-
logger.warn("Compose resources are supported in XCFrameworks " +
41-
"since '$MIN_KGP_VERSION_FOR_XCFRAMEWORK_RESOURCES' Kotlin Gradle plugin version")
42-
}
28+
}
4329
}
4430
}

gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/ResourcesTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -745,8 +745,8 @@ class ResourcesTest : GradlePluginTestBase() {
745745
|
746746
""".trimMargin()
747747
}
748-
gradle(":assembleComposeAppDebugXCFramework", "--dry-run").checks {
749-
check.logContains("Compose resources are supported in XCFrameworks since '2.2.0-Beta2-1' Kotlin Gradle plugin version")
748+
gradleFailure(":assembleComposeAppDebugXCFramework", "--dry-run").checks {
749+
check.logContains("e: Configuration problem: Minimal supported Kotlin")
750750
}
751751
}
752752
}

0 commit comments

Comments
 (0)