Skip to content

Commit 5eb9f09

Browse files
committed
VerifyPluginTaskSpec tests fix
1 parent d16944d commit 5eb9f09

File tree

1 file changed

+7
-30
lines changed

1 file changed

+7
-30
lines changed

src/test/kotlin/org/jetbrains/intellij/tasks/VerifyPluginTaskSpec.kt

Lines changed: 7 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,6 @@ import kotlin.test.Test
99
@Suppress("PluginXmlCapitalization", "PluginXmlValidity", "ComplexRedundantLet")
1010
class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
1111

12-
@Test
13-
fun `do not fail on warning by default`() {
14-
buildFile.groovy(
15-
"""
16-
version '1.0'
17-
""".trimIndent()
18-
)
19-
20-
pluginXml.xml(
21-
"""
22-
<idea-plugin>
23-
<name>PluginName</name>
24-
<description>Lorem ipsum dolor sit amet, consectetur adipisicing elit.</description>
25-
<vendor>JetBrains</vendor>
26-
</idea-plugin>
27-
""".trimIndent()
28-
)
29-
30-
build(VERIFY_PLUGIN_TASK_NAME).let {
31-
assertContains("Plugin name specified in plugin.xml should not contain the word 'plugin'", it.output)
32-
}
33-
}
34-
3512
@Test
3613
fun `fail on warning if option is disabled`() {
3714
buildFile.groovy(
@@ -55,7 +32,7 @@ class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
5532
)
5633

5734
buildAndFail(VERIFY_PLUGIN_TASK_NAME).let {
58-
assertContains("Plugin name specified in plugin.xml should not contain the word 'IntelliJ'", it.output)
35+
assertContains("The plugin name should not contain the word 'IntelliJ'", it.output)
5936
}
6037
}
6138

@@ -78,7 +55,7 @@ class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
7855
)
7956

8057
buildAndFail(VERIFY_PLUGIN_TASK_NAME).let {
81-
assertContains("Invalid plugin descriptor 'description': Please provide a long-enough English description.", it.output)
58+
assertContains("Invalid plugin descriptor 'description'. The plugin description is shorter than 40 characters and/or the plugin description contains non-Latin characters.", it.output)
8259
}
8360
}
8461

@@ -105,15 +82,15 @@ class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
10582
)
10683

10784
build(VERIFY_PLUGIN_TASK_NAME).let {
108-
assertContains("Invalid plugin descriptor 'description': Please provide a long-enough English description.", it.output)
85+
assertContains("Invalid plugin descriptor 'description'. The plugin description is shorter than 40 characters and/or the plugin description contains non-Latin characters.", it.output)
10986
}
11087
}
11188

11289
@Test
11390
fun `fail on errors by default`() {
11491
pluginXml.delete()
11592
buildAndFail(VERIFY_PLUGIN_TASK_NAME).let {
116-
assertContains("Plugin descriptor 'plugin.xml' is not found", it.output)
93+
assertContains("The plugin descriptor 'plugin.xml' is not found.", it.output)
11794
}
11895
}
11996

@@ -129,7 +106,7 @@ class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
129106

130107
pluginXml.delete()
131108
build(VERIFY_PLUGIN_TASK_NAME).let {
132-
assertContains("Plugin descriptor 'plugin.xml' is not found", it.output)
109+
assertContains("The plugin descriptor 'plugin.xml' is not found.", it.output)
133110
}
134111
}
135112

@@ -156,7 +133,7 @@ class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
156133
)
157134

158135
buildAndFail(VERIFY_PLUGIN_TASK_NAME).let {
159-
assertContains("<name> must not be equal to default value:", it.output)
136+
assertContains("Please ensure that <name> is not equal to the default value", it.output)
160137
}
161138
}
162139

@@ -183,7 +160,7 @@ class VerifyPluginTaskSpec : IntelliJPluginSpecBase() {
183160
)
184161

185162
build(VERIFY_PLUGIN_TASK_NAME).let {
186-
assertContains("Invalid plugin descriptor 'description': Please provide a long-enough English description.", it.output)
163+
assertContains("Invalid plugin descriptor 'description'. The plugin description is shorter than 40 characters and/or the plugin description contains non-Latin characters.", it.output)
187164
}
188165
}
189166

0 commit comments

Comments
 (0)