Skip to content

Commit 9c07706

Browse files
committed
Set the minimal supported Gradle version to 7.1
1 parent a80ec66 commit 9c07706

File tree

8 files changed

+16
-53
lines changed

8 files changed

+16
-53
lines changed

.github/workflows/reusable-integrationTests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ jobs:
5555
fail-fast: false
5656
matrix:
5757
gradleVersion:
58-
- 6.8
59-
- 6.9.3
58+
- 7.1
6059
- 7.6
6160
os:
6261
- windows-latest

.github/workflows/reusable-unitTests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ jobs:
3030
fail-fast: false
3131
matrix:
3232
gradleVersion:
33-
- 6.8
34-
- 6.9.3
33+
- 7.1
3534
- 7.6
3635
os:
3736
- windows-latest

.teamcity/settings.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ project {
4343

4444

4545
object UnitTests : BuildType({
46-
val gradleVersions = listOf("6.8", "6.9.3", "7.6")
46+
val gradleVersions = listOf("7.1", "7.6")
4747

4848
name = "Unit Tests"
4949

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## [next]
44

5+
### Changed
6+
- Set minimum supported Gradle version from `6.8` to `7.1`
7+
58
### Fixed
69
- Fixed "Error: Could not find or load main class" when using older SDK versions
710
- Fix launch information could not be found for macOS. [#1230](../../issues/1230)

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ ossrhUsername=
2020
ossrhPassword=
2121
pluginsRepository=https://cache-redirector.jetbrains.com/plugins.jetbrains.com/maven
2222

23-
gradleVersion=7.6
23+
gradleVersion=7.1
2424
kotlinVersion=1.7.22
2525

2626
testGradleVersion=

integration-tests/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ Each of the Integration Tests is a standalone project that focuses on a specific
1313
Running Integration Tests is based on GitHub Actions and makes use of the matrix build so that we can run all tests with variations of different properties:
1414
- Operating systems: macOS, Windows, Linux
1515
- Gradle versions:
16-
- first supported: `6.8`
17-
- last from `6.x` branch: `6.9.3`
16+
- first supported: `7.1`
1817
- latest available: `7.6`
1918
- IntelliJ IDEA SDK versions:
2019
- latest stable: `2021.3.3`

src/main/kotlin/org/jetbrains/intellij/IntelliJPluginConstants.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ object IntelliJPluginConstants {
5050

5151
const val ANNOTATIONS_DEPENDENCY_VERSION = "23.0.0"
5252
const val DEFAULT_IDEA_VERSION = "LATEST-EAP-SNAPSHOT"
53-
const val MINIMAL_SUPPORTED_GRADLE_VERSION = "6.8"
53+
const val MINIMAL_SUPPORTED_GRADLE_VERSION = "7.1"
5454

5555
const val RELEASE_SUFFIX_EAP = "-EAP-SNAPSHOT"
5656
const val RELEASE_SUFFIX_EAP_CANDIDATE = "-EAP-CANDIDATE-SNAPSHOT"

src/test/kotlin/org/jetbrains/intellij/IntelliJPluginSpec.kt

Lines changed: 7 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -575,50 +575,13 @@ class IntelliJPluginSpec : IntelliJPluginSpecBase() {
575575
}
576576
}
577577

578-
// /**
579-
// * Note: An older version of `kotlin("jvm")` is because 1.7.+ requires Gradle 7.1.
580-
// *
581-
// * (specifically `kotlin("jvm")` requires the method [org.gradle.api.plugins.JavaPluginExtension.getSourceSets])
582-
// */
583-
// @Test
584-
// fun `expect successful build using minimal supported Gradle version`() {
585-
//
586-
// buildFile.writeText("") // reset the build file - need to apply an older version of Kotlin plugin
587-
// buildFile.groovy(
588-
// """
589-
// plugins {
590-
// id 'org.jetbrains.intellij'
591-
// id 'org.jetbrains.kotlin.jvm' version '1.4.20'
592-
// }
593-
// sourceCompatibility = 11
594-
// targetCompatibility = 11
595-
// repositories {
596-
// mavenCentral()
597-
// }
598-
// intellij {
599-
// version = '$intellijVersion'
600-
// downloadSources = false
601-
// pluginsRepositories {
602-
// maven('$pluginsRepository')
603-
// }
604-
// instrumentCode = false
605-
// }
606-
// buildSearchableOptions {
607-
// enabled = false
608-
// }
609-
//
610-
// // Define tasks with a minimal set of tasks required to build a source set
611-
// sourceSets.all {
612-
// task(it.getTaskName('build', 'SourceSet'), dependsOn: it.output)
613-
// }
614-
// """.trimIndent()
615-
// )
616-
//
617-
// val buildResult = build(MINIMAL_SUPPORTED_GRADLE_VERSION, false, "help")
618-
//
619-
// assertContains("BUILD SUCCESSFUL", buildResult.output)
620-
// assertNotContains("Gradle IntelliJ Plugin requires Gradle", buildResult.output)
621-
// }
578+
@Test
579+
fun `expect successful build using minimal supported Gradle version`() {
580+
val buildResult = build(MINIMAL_SUPPORTED_GRADLE_VERSION, false, "help")
581+
582+
assertContains("BUILD SUCCESSFUL", buildResult.output)
583+
assertNotContains("Gradle IntelliJ Plugin requires Gradle", buildResult.output)
584+
}
622585

623586
@SuppressWarnings("GrEqualsBetweenInconvertibleTypes")
624587
fun assertPathParameters(testCommand: ProcessProperties, sandboxPath: String) {

0 commit comments

Comments
 (0)