Skip to content

Commit 27bedbf

Browse files
committed
sbt project view: update comment #SCL-22171
1 parent dd4688e commit 27bedbf

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

scala/scala-impl/src/org/jetbrains/plugins/scala/projectView/ScalaTreeStructureProvider.scala

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@ final class ScalaTreeStructureProvider extends TreeStructureProvider with DumbAw
3535
val childrenSeq = children.asScala.toSeq
3636
val modifiedChildren = parent match {
3737
// note: in GradleTreeStructureProvider they also implemented special handling for ProjectViewModuleGroupNode.
38-
// It is more important in Gradle because they allow modules to be created outside the project base directory and in such cases it may happen
39-
// that ProjectViewModuleGroupNode will be a parent.
40-
// In sbt I have not been able to find any standard case in which we would need it. I was able to recreate such situation
38+
// It is important in Gradle because they allow:
39+
// - modules to be created outside the project base directory,
40+
// - creation of modules with empty/non-existent/many content roots (we always have single content root for module)
41+
// In all this cases ProjectViewModuleGroupNode could be a parent.
42+
// In sbt I haven't been able to find any standard case in which we would need it. I was able to recreate such situation
4143
// by e.g. removing content root in the root module, but it is not our standard case, so I think we shouldn't care about it.
42-
// recheck it when SCL-21157 is fixed
44+
// Handling ProjectViewModuleGroupNode will be probably needed for SCL-21157
4345
case _: ProjectViewProjectNode =>
4446
getProjectViewProjectNodeChildren(childrenSeq)(project, settings)
4547
case _ =>

0 commit comments

Comments
 (0)