Skip to content

Commit 357c1e4

Browse files
committed
Code cleanup GraphQLPsiSearchHelper
1 parent 1970efa commit 357c1e4

File tree

9 files changed

+354
-54
lines changed

9 files changed

+354
-54
lines changed

src/main/com/intellij/lang/jsgraphql/ide/completion/GraphQLCompletionContributor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ protected void addCompletions(@NotNull final CompletionParameters parameters,
491491
if (directiveLocations != null) {
492492
final Set<String> currentLocations = Sets.newHashSet();
493493
directiveLocations.getDirectiveLocationList().forEach(location -> currentLocations.add(location.getText()));
494-
final PsiFile builtInSchema = GraphQLPsiSearchHelper.getService(completionElement.getProject()).getBuiltInSchema();
494+
final PsiFile builtInSchema = GraphQLPsiSearchHelper.getInstance(completionElement.getProject()).getBuiltInSchema();
495495

496496
builtInSchema.accept(new PsiRecursiveElementVisitor() {
497497
@Override
@@ -718,7 +718,7 @@ protected void addCompletions(@NotNull final CompletionParameters parameters,
718718
// fragment must be compatible with the type in scope
719719
final TypeDefinitionRegistry typeDefinitionRegistry = GraphQLSchemaProvider.getInstance(completionElement.getProject()).getTolerantRegistry(parameters.getOriginalFile());
720720

721-
final List<GraphQLFragmentDefinition> knownFragmentDefinitions = GraphQLPsiSearchHelper.getService(completionElement.getProject()).getKnownFragmentDefinitions(parameters.getOriginalFile());
721+
final List<GraphQLFragmentDefinition> knownFragmentDefinitions = GraphQLPsiSearchHelper.getInstance(completionElement.getProject()).getKnownFragmentDefinitions(parameters.getOriginalFile());
722722
for (GraphQLFragmentDefinition fragmentDefinition : knownFragmentDefinitions) {
723723
final String name = fragmentDefinition.getName();
724724
if (name != null) {

src/main/com/intellij/lang/jsgraphql/ide/project/GraphQLPsiSearchHelper.java

Lines changed: 60 additions & 44 deletions
Large diffs are not rendered by default.

src/main/com/intellij/lang/jsgraphql/ide/project/schemastatus/GraphQLDefaultSchemaNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ protected GraphQLDefaultSchemaNode(Project project, GraphQLSchemasRootNode graph
3333
myName = "Default project-wide schema";
3434
getPresentation().setLocationString(project.getPresentableUrl());
3535
getPresentation().setIcon(JSGraphQLIcons.Files.GraphQLSchema);
36-
final GraphQLFile defaultProjectFile = GraphQLPsiSearchHelper.getService(myProject).getDefaultProjectFile();
36+
final GraphQLFile defaultProjectFile = GraphQLPsiSearchHelper.getInstance(myProject).getDefaultProjectFile();
3737
final GraphQLSchemaProvider registry = GraphQLSchemaProvider.getInstance(myProject);
3838
myValidatedSchema = registry.getValidatedSchema(defaultProjectFile);
3939
}

src/main/com/intellij/lang/jsgraphql/ide/references/GraphQLReferenceService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public static GraphQLReferenceService getService(@NotNull Project project) {
6565
}
6666

6767
public GraphQLReferenceService(@NotNull final Project project) {
68-
psiSearchHelper = GraphQLPsiSearchHelper.getService(project);
68+
psiSearchHelper = GraphQLPsiSearchHelper.getInstance(project);
6969
project.getMessageBus().connect().subscribe(PsiManagerImpl.ANY_PSI_CHANGE_TOPIC, new AnyPsiChangeListener.Adapter() {
7070
@Override
7171
public void beforePsiChanged(boolean isPhysical) {
@@ -213,7 +213,7 @@ PsiReference resolveFieldReference(GraphQLReferencePsiElement element, GraphQLFi
213213
final String name = element.getName();
214214
Ref<PsiReference> reference = new Ref<>();
215215
if (name != null) {
216-
final GraphQLPsiSearchHelper graphQLPsiSearchHelper = GraphQLPsiSearchHelper.getService(element.getProject());
216+
final GraphQLPsiSearchHelper graphQLPsiSearchHelper = GraphQLPsiSearchHelper.getInstance(element.getProject());
217217
if (name.startsWith("__")) {
218218
// __typename or introspection fields __schema and __type which implicitly extends the query root type
219219
graphQLPsiSearchHelper.getBuiltInSchema().accept(new PsiRecursiveElementVisitor() {

src/main/com/intellij/lang/jsgraphql/ide/rename/GraphQLRenameVetoCondition.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
public class GraphQLRenameVetoCondition implements Condition<PsiElement> {
1919
@Override
2020
public boolean value(PsiElement psiElement) {
21-
final PsiFile builtInSchema = GraphQLPsiSearchHelper.getService(psiElement.getProject()).getBuiltInSchema();
21+
final PsiFile builtInSchema = GraphQLPsiSearchHelper.getInstance(psiElement.getProject()).getBuiltInSchema();
2222
return builtInSchema == psiElement.getContainingFile();
2323
}
24-
}
24+
}

src/main/com/intellij/lang/jsgraphql/ide/search/GraphQLDefinitionsSearchExecutor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ private static boolean doExecute(PsiElement sourceElement, final Processor<? sup
3434
if (sourceElement instanceof GraphQLIdentifier && sourceElement.getParent() instanceof GraphQLTypeNameDefinition) {
3535
final GraphQLInterfaceTypeDefinition interfaceTypeDefinition = PsiTreeUtil.getParentOfType(sourceElement, GraphQLInterfaceTypeDefinition.class);
3636
if (interfaceTypeDefinition != null) {
37-
GraphQLPsiSearchHelper.getService(sourceElement.getProject()).processElementsWithWord(sourceElement, sourceElement.getText(), namedElement -> {
37+
GraphQLPsiSearchHelper.getInstance(sourceElement.getProject()).processElementsWithWord(sourceElement, sourceElement.getText(), namedElement -> {
3838
ProgressManager.checkCanceled();
3939
if (namedElement instanceof GraphQLIdentifier && PsiTreeUtil.getParentOfType(namedElement, GraphQLImplementsInterfaces.class) != null) {
4040
final GraphQLTypeSystemDefinition typeSystemDefinition = PsiTreeUtil.getParentOfType(namedElement, GraphQLObjectTypeDefinition.class, GraphQLObjectTypeExtensionDefinition.class);

src/main/com/intellij/lang/jsgraphql/psi/impl/GraphQLDirectiveLocationPsiElement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public PsiReference getReference() {
3232
final Ref<PsiReference> reference = new Ref<>();
3333
final GraphQLDirectiveLocationPsiElement psiElement = this;
3434
final String locationName = psiElement.getText();
35-
GraphQLPsiSearchHelper.getService(getProject()).getBuiltInSchema().accept(new PsiRecursiveElementVisitor() {
35+
GraphQLPsiSearchHelper.getInstance(getProject()).getBuiltInSchema().accept(new PsiRecursiveElementVisitor() {
3636
@Override
3737
public void visitElement(PsiElement element) {
3838
if(element instanceof GraphQLEnumValue && element.getText().equals(locationName)) {

src/main/com/intellij/lang/jsgraphql/psi/impl/GraphQLReferencePsiElement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public SearchScope getUseScope() {
4848
PsiElement context = psiFile.getContext();
4949
if(context != null && context.getLanguage() != this.getLanguage()) {
5050
// this PSI element is part of injected GraphQL, so we have to expand the use scope which defaults to the current file only
51-
useScope = useScope.union(GraphQLPsiSearchHelper.getService(getProject()).getUseScope(this));
51+
useScope = useScope.union(GraphQLPsiSearchHelper.getInstance(getProject()).getUseScope(this));
5252
}
5353
}
5454
return useScope;

0 commit comments

Comments
 (0)