Additional logging for GraphQL libraries

Author: vepanimas

src/main/com/intellij/lang/jsgraphql/ide/resolve/GraphQLResolveUtil.java

@@ -4,6 +4,7 @@
 import com.intellij.lang.jsgraphql.schema.library.GraphQLLibrary;
 import com.intellij.lang.jsgraphql.schema.library.GraphQLLibraryDescriptor;
 import com.intellij.lang.jsgraphql.schema.library.GraphQLLibraryRootsProvider;
+import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiFile;
@@ -18,21 +19,30 @@
 import java.util.Collection;
 
 public final class GraphQLResolveUtil {
+
+    private static final Logger LOG = Logger.getInstance(GraphQLResolveUtil.class);
+
     private GraphQLResolveUtil() {
     }
 
     public static void processFilesInLibrary(@NotNull GraphQLLibraryDescriptor libraryDescriptor,
                                              @NotNull PsiElement context,
                                              @NotNull Processor<? super GraphQLFile> processor) {
         GraphQLLibrary library = GraphQLLibraryRootsProvider.findLibrary(context.getProject(), libraryDescriptor);
-        if (library == null) return;
+        if (library == null) {
+            LOG.warn("Library is not found: " + libraryDescriptor);
+            return;
+        }
 
         PsiManager psiManager = context.getManager();
         for (VirtualFile root : library.getSourceRoots()) {
             PsiFile file = psiManager.findFile(root);
-            if (file instanceof GraphQLFile && file.isValid()) {
-                if (!processor.process(((GraphQLFile) file))) return;
+            if (!(file instanceof GraphQLFile) || !file.isValid()) {
+                LOG.warn("Library file is invalid: " + root.getPath());
+                continue;
             }
+
+            if (!processor.process(((GraphQLFile) file))) return;
         }
     }
 

src/main/com/intellij/lang/jsgraphql/schema/library/GraphQLLibraryDescriptor.java

@@ -3,6 +3,8 @@
 import com.intellij.openapi.project.Project;
 import org.jetbrains.annotations.NotNull;
 
+import java.util.Objects;
+
 public class GraphQLLibraryDescriptor {
 
     private final String myIdentifier;
@@ -25,6 +27,19 @@ public boolean isEnabled(@NotNull Project project) {
         return true;
     }
 
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        GraphQLLibraryDescriptor that = (GraphQLLibraryDescriptor) o;
+        return Objects.equals(myIdentifier, that.myIdentifier);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(myIdentifier);
+    }
+
     @Override
     public String toString() {
         return "GraphQLLibraryDescriptor{" +

src/main/com/intellij/lang/jsgraphql/schema/library/GraphQLLibraryManager.java

@@ -62,6 +62,7 @@ public GraphQLLibrary getOrCreateLibrary(@NotNull GraphQLLibraryDescriptor libra
         return myLibraries.computeIfAbsent(libraryDescriptor, __ -> {
             VirtualFile root = resolveLibraryRoot(libraryDescriptor);
             if (root == null) {
+                LOG.warn("Unresolved library root: " + libraryDescriptor);
                 return null;
             }
             return new GraphQLLibrary(libraryDescriptor, root);
@@ -79,8 +80,12 @@ public Collection<SyntheticLibrary> getAllLibraries() {
     }
 
     @Nullable
-    private VirtualFile resolveLibraryRoot(@NotNull GraphQLLibraryDescriptor definition) {
-        String resourceName = ourDefinitionResourcePaths.get(definition);
+    private VirtualFile resolveLibraryRoot(@NotNull GraphQLLibraryDescriptor descriptor) {
+        String resourceName = ourDefinitionResourcePaths.get(descriptor);
+        if (resourceName == null) {
+            LOG.error("No resource files found for library: " + descriptor);
+            return null;
+        }
         URL resource = getClass().getClassLoader().getResource(DEFINITIONS_RESOURCE_DIR + resourceName);
         if (resource == null) {
             LOG.error("Resource not found: " + resourceName);