fix(e2e): remove redundant timeouts and update isDevelopment logic

- Eliminate unnecessary `waitForTimeout` calls for improved test performance in `teach.spec.ts`.
- Refactor `playwright.config.ts` to enhance `isDevelopment` logic, ensuring proper handling of CI and local development environments.

Author: zoobestik

playwright.config.ts

@@ -2,13 +2,16 @@ import { defineConfig, devices } from '@playwright/test';
 
 const MAX_DIFF_PIXEL_RATIO = 0.025 as const;
 
+const isDevelopment = !process.env.CI;
+
 export default defineConfig({
     globalSetup: require.resolve('./test/global-setup.ts'),
-    forbidOnly: !!process.env.CI,
-    retries: process.env.CI ? 2 : 0,
-    reporter: process.env.CI ? 'playwright-teamcity-reporter' : 'list',
+    forbidOnly: !isDevelopment,
+    retries: isDevelopment ? 0 : 2,
+    reporter: isDevelopment ?  'list' : 'playwright-teamcity-reporter',
     snapshotDir: 'test/snapshots',
     expect: {
+        timeout: isDevelopment ? 10000 : 5000,
         toMatchSnapshot: { maxDiffPixelRatio: MAX_DIFF_PIXEL_RATIO },
         toHaveScreenshot: { maxDiffPixelRatio: MAX_DIFF_PIXEL_RATIO }
     },

test/production/teach.spec.ts

@@ -9,15 +9,13 @@ test.describe('Teach page', () => {
         const whyTeachKotlinButton = page.getByRole('link', { name: 'Why Teach Kotlin' }).first();
         await expect(whyTeachKotlinButton).toBeVisible();
         await whyTeachKotlinButton.click();
-        await page.waitForTimeout(3000);
         await expect(page.url()).toContain('/education/why-teach-kotlin/');
     });
 
     test('List of courses button in navbar opens the related page', async ({ page }) => {
         const listOfCoursesButton = page.getByRole('link', { name: 'List of Courses' });
         await expect(listOfCoursesButton).toBeVisible();
         await listOfCoursesButton.click();
-        await page.waitForTimeout(3000);
         await expect(page.url()).toContain('/education/courses/');
     });
 
@@ -55,16 +53,14 @@ test.describe('Teach page', () => {
         const whyTeachKotlinButton = page.getByRole('link', { name: 'Why Teach Kotlin' }).nth(1);
         await expect(whyTeachKotlinButton).toBeVisible();
         await whyTeachKotlinButton.click();
-        await page.waitForTimeout(3000);
         await expect(page.url()).toContain('/education/why-teach-kotlin');
     });
 
     test('All universities button opens the related page', async ({ page }) => {
         const allUniversitiesButton = page.getByRole('link', { name: 'All universities' });
         await expect(allUniversitiesButton).toBeVisible();
         await allUniversitiesButton.click();
-        await page.waitForTimeout(3000);
-        await expect(page.url()).toContain('/education/courses');
+        expect(page.url()).toContain('/education/courses');
     });
 
     test('Slack-channel button in context opens the related page', async ({ page, context }) => {
@@ -74,6 +70,6 @@ test.describe('Teach page', () => {
         await joinEducatorsButton.click();
         const newPage = await newPagePromise;
         await newPage.waitForLoadState();
-        await expect(newPage.url()).toContain('https://surveys.jetbrains.com/s3/kotlin-slack-signup-educators');
+        expect(newPage.url()).toContain('https://surveys.jetbrains.com/s3/kotlin-slack-signup-educators');
     });
 });