-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: binary options #4974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: binary options #4974
Conversation
e510793
to
ee0c924
Compare
Thank you, overall looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix just one last thing (overlooked it during prev review, sorry!).
<li><code>false</code> (default)</li> | ||
</list> | ||
</td> | ||
<td>Decreases the binary size for iOS targets.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag works for any target, but only in release mode at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, we missed this during WN 2.2.20-Beta publication, fixed in WN as well. thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! I just have minor suggestions.
Co-authored-by: Sarah Haggarty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
No description provided.