Skip to content

Conversation

danil-pavlov
Copy link
Contributor

No description provided.

@danil-pavlov danil-pavlov force-pushed the native-binary-options branch from e510793 to ee0c924 Compare August 5, 2025 12:01
@danil-pavlov danil-pavlov marked this pull request as ready for review August 5, 2025 12:57
@danil-pavlov danil-pavlov requested a review from a team as a code owner August 5, 2025 12:57
@sbogolepov sbogolepov self-requested a review August 5, 2025 13:02
@sbogolepov
Copy link
Contributor

Thank you, overall looks good to me!

Copy link
Contributor

@sbogolepov sbogolepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix just one last thing (overlooked it during prev review, sorry!).

<li><code>false</code> (default)</li>
</list>
</td>
<td>Decreases the binary size for iOS targets.</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag works for any target, but only in release mode at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, we missed this during WN 2.2.20-Beta publication, fixed in WN as well. thank you!

@sarahhaggarty sarahhaggarty self-assigned this Aug 18, 2025
@sarahhaggarty sarahhaggarty self-requested a review August 18, 2025 09:22
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I just have minor suggestions.

danil-pavlov and others added 2 commits August 19, 2025 13:43
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@danil-pavlov danil-pavlov merged commit 6f5db63 into master Aug 19, 2025
4 checks passed
@danil-pavlov danil-pavlov deleted the native-binary-options branch August 19, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants