[Plugins] Require a unique pluginId for all compiler plugins

^KT-55300

Author: bnorm

compiler/plugin-api/src/org/jetbrains/kotlin/compiler/plugin/CompilerPluginRegistrar.kt

@@ -23,8 +23,7 @@ abstract class CompilerPluginRegistrar {
      * Uniquely identifies the Kotlin compiler plugin. Must match the `pluginId` specified in [CommandLineProcessor].
      * The ID can be used in combination with `-Xcompiler-plugin-order` to control execution order of compiler plugins.
      */
-    open val pluginId: String
-        get() = "" // TODO(KT-55300) property will be made abstract in immediate followup.
+    abstract val pluginId: String
 
     abstract fun ExtensionStorage.registerExtensions(configuration: CompilerConfiguration)
 

libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/resources/testProject/compilerPlugins/incrementalChangeInPlugin/plugin/src/main/kotlin/test/compiler/plugin/TestComponentRegistrar.kt

@@ -16,5 +16,6 @@ class TestComponentRegistrar : CompilerPluginRegistrar() {
         IrGenerationExtension.registerExtension(MyMethodGenerator())
     }
 
+    override val pluginId: String get() = "test.compiler.plugin"
     override val supportsK2: Boolean = true
 }

libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/resources/testProject/compilerPlugins/pluginUsesJdkClass/plugin/src/main/kotlin/test/compiler/plugin/TestComponentRegistrar.kt

@@ -31,5 +31,6 @@ class TestComponentRegistrar : CompilerPluginRegistrar() {
         }
     }
 
-    override val supportsK2: Boolean = true
+    override val pluginId: String get() = "test.compiler.plugin"
+    override val supportsK2: Boolean get() = true
 }

libraries/tools/kotlin-maven-plugin-test/src/it/test-plugins/test-extension/src/main/kotlin/org/jetbrains/kotlin/test/TestKotlinPluginRegistrar.kt

@@ -43,6 +43,6 @@ class TestKotlinPluginRegistrar : CompilerPluginRegistrar() {
         collector.report(CompilerMessageSeverity.INFO, "Option value: $option")
     }
 
-    override val supportsK2: Boolean
-        get() = true
+    override val pluginId: String get() = "test.compiler.plugin"
+    override val supportsK2: Boolean get() = true
 }

plugins/allopen/allopen.cli/src/org/jetbrains/kotlin/allopen/AllOpenPlugin.kt

@@ -56,6 +56,8 @@ class AllOpenComponentRegistrar : CompilerPluginRegistrar() {
         FirExtensionRegistrarAdapter.registerExtension(FirAllOpenExtensionRegistrar(annotations))
     }
 
+    override val pluginId: String get() = AllOpenPluginNames.PLUGIN_ID
+
     override val supportsK2: Boolean
         get() = true
 }

plugins/assign-plugin/assign-plugin.cli/src/org/jetbrains/kotlin/assignment/plugin/ValueContainerAssignmentPlugin.kt

@@ -54,6 +54,8 @@ class AssignmentComponentRegistrar : CompilerPluginRegistrar() {
         }
     }
 
+    override val pluginId: String get() = PLUGIN_ID
+
     override val supportsK2: Boolean
         get() = true
 }

plugins/atomicfu/atomicfu-compiler/src/org/jetbrains/kotlinx/atomicfu/compiler/extensions/AtomicfuComponentRegistrar.kt

@@ -29,6 +29,8 @@ class AtomicfuComponentRegistrar : CompilerPluginRegistrar() {
         registerExtensions(this)
     }
 
+    override val pluginId: String get() = "org.jetbrains.kotlinx.atomicfu"
+
     override val supportsK2: Boolean
         get() = true
 

plugins/compose/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/ComposePlugin.kt

@@ -577,6 +577,8 @@ fun validateFeatureFlag(
 
 @OptIn(ExperimentalCompilerApi::class)
 class ComposePluginRegistrar : CompilerPluginRegistrar() {
+    override val pluginId: String get() = COMPOSE_PLUGIN_ID
+
     override val supportsK2: Boolean
         get() = true
 

plugins/js-plain-objects/compiler-plugin/js-plain-objects.cli/src/org/jetbrains/kotlinx/jso/compiler/cli/JsPlainObjectsComponentRegistrar.kt

@@ -13,6 +13,7 @@ import org.jetbrains.kotlinx.jspo.compiler.backend.JsPlainObjectsLoweringExtensi
 import org.jetbrains.kotlinx.jspo.compiler.fir.JsPlainObjectsExtensionRegistrar
 
 class JsPlainObjectsComponentRegistrar : CompilerPluginRegistrar() {
+    override val pluginId: String get() = "org.jetbrains.kotlinx.jspo"
     override val supportsK2: Boolean get() = true
 
     override fun ExtensionStorage.registerExtensions(configuration: CompilerConfiguration) {

plugins/jvm-abi-gen/src/org/jetbrains/kotlin/jvm/abi/JvmAbiComponentRegistrar.kt

@@ -13,6 +13,7 @@ import org.jetbrains.kotlin.codegen.extensions.ClassFileFactoryFinalizerExtensio
 import org.jetbrains.kotlin.compiler.plugin.CompilerPluginRegistrar
 import org.jetbrains.kotlin.config.CompilerConfiguration
 import org.jetbrains.kotlin.config.messageCollector
+import org.jetbrains.kotlin.jvm.abi.JvmAbiCommandLineProcessor.Companion.COMPILER_PLUGIN_ID
 import java.io.File
 
 /**
@@ -52,6 +53,8 @@ class JvmAbiComponentRegistrar(
         ClassFileFactoryFinalizerExtension.registerExtension(outputExtension)
     }
 
+    override val pluginId: String get() = COMPILER_PLUGIN_ID
+
     override val supportsK2: Boolean
         get() = true
 }