IR interpreter: do not interpret absence of argument as empty array

 #KT-72881 Fixed

Author: udalov

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLBlackBoxTestGenerated.java

@@ -234,8 +234,8 @@ internal fun IrElement.toConstantValueOrNull(): ConstantValue<*>? {
             val classId = this.symbol.owner.constructedClass.classId ?: return null
             val rawArguments = this.getAllArgumentsWithIr()
             val argumentMapping = rawArguments
-                .filter { it.second != null || it.first.type.isArray() }
-                .associate { (parameter, expression) -> parameter.name to (expression?.toConstantValue() ?: ArrayValue(emptyList())) }
+                .filter { it.second != null }
+                .associate { (parameter, expression) -> parameter.name to expression!!.toConstantValue() }
             AnnotationValue.create(classId, argumentMapping)
         }
         is IrGetEnumValue -> {

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLReversedBlackBoxTestGenerated.java

@@ -0,0 +1,9 @@
+MODULE main
+	CLASS test/A.class
+		CLASS METADATA
+			CONSTRUCTOR <init>(Lkotlin/Array;)V
+				Property: class.metadata.constructor.valueParameters
+					K1
+						(values: kotlin/Array<kotlin/String> /* = ... */)
+					K2
+						(values: kotlin/Array<kotlin/String> = ["Fail"])

compiler/fir/fir2ir/tests-gen/org/jetbrains/kotlin/test/runners/codegen/FirLightTreeBlackBoxCodegenTestGenerated.java

@@ -0,0 +1,17 @@
+// TARGET_BACKEND: JVM
+// WITH_REFLECT
+// JVM_ABI_K1_K2_DIFF: K2 serializes annotation parameter default values (KT-59526).
+
+package test
+
+import kotlin.test.assertEquals
+
+@Target(AnnotationTarget.TYPE)
+annotation class A(val values: Array<String> = ["Fail"])
+
+fun f(): @A Unit {}
+
+fun box(): String {
+    assertEquals("@test.A()", ::f.returnType.annotations.single().toString())
+    return "OK"
+}

compiler/fir/fir2ir/tests-gen/org/jetbrains/kotlin/test/runners/codegen/FirPsiBlackBoxCodegenTestGenerated.java

@@ -1,7 +1,7 @@
 field:@FIELD:R|test/Anno|(t = <implicitArrayOf>(String(prosper))) public final val bar: R|kotlin/Int|
     public get(): R|kotlin/Int|
 
-@R|test/Anno|(t = <implicitArrayOf>()) @R|test/Anno2|(t = <implicitArrayOf>()) @R|test/Anno3|(t = <implicitArrayOf>()) @R|test/Anno4|(t = <implicitArrayOf>()) @R|test/Anno5|(t = <implicitArrayOf>()) @R|test/Anno6|(t = <implicitArrayOf>()) public final fun baz(): R|kotlin/Unit|
+@R|test/Anno|(t = <implicitArrayOf>()) @R|test/Anno2|() @R|test/Anno3|() @R|test/Anno4|(t = <implicitArrayOf>()) @R|test/Anno5|() @R|test/Anno6|() public final fun baz(): R|kotlin/Unit|
 
 @R|test/Anno|(t = <implicitArrayOf>(String(live), String(long))) public final fun foo(): R|kotlin/Unit|
 

compiler/ir/ir.interpreter/src/org/jetbrains/kotlin/ir/interpreter/IrTreeBuildUtils.kt

@@ -5,10 +5,6 @@
 // LANGUAGE: +MultiPlatformProjects
 // K1/K2 difference: KT-60820
 
-// IGNORE_FIR_METADATA_LOADING_K2_WITH_ANNOTATIONS_IN_METADATA
-// ^ With annotations in metadata, compiler also loads `t = <implicitArrayOf>()` in some annotation classes.
-// Once AnnotationsInMetadata is enabled by default, this directive can be removed and the txt dump can be updated.
-
 // MODULE: common
 // FILE: common.kt
 package test