[SLC] do not generate redundant no-arg constructor

If some secondary constructor produces a variant with no arguments

^KT-80656 Fixed

Author: dimonchik0036

analysis/symbol-light-classes/src/org/jetbrains/kotlin/light/classes/symbol/methods/SymbolLightConstructor.kt

@@ -8,11 +8,8 @@ package org.jetbrains.kotlin.light.classes.symbol.methods
 import com.intellij.openapi.progress.ProgressManager
 import com.intellij.psi.*
 import org.jetbrains.kotlin.analysis.api.KaSession
-import org.jetbrains.kotlin.analysis.api.symbols.KaClassKind
-import org.jetbrains.kotlin.analysis.api.symbols.KaConstructorSymbol
-import org.jetbrains.kotlin.analysis.api.symbols.KaSymbolVisibility
+import org.jetbrains.kotlin.analysis.api.symbols.*
 import org.jetbrains.kotlin.analysis.api.symbols.pointers.KaSymbolPointer
-import org.jetbrains.kotlin.analysis.api.symbols.sourcePsiSafe
 import org.jetbrains.kotlin.asJava.builder.LightMemberOriginForDeclaration
 import org.jetbrains.kotlin.asJava.classes.METHOD_INDEX_BASE
 import org.jetbrains.kotlin.asJava.classes.METHOD_INDEX_FOR_DEFAULT_CTOR
@@ -169,15 +166,21 @@ internal class SymbolLightConstructor private constructor(
             constructors: Iterable<KaConstructorSymbol>,
         ): Boolean {
             val classOrObject = lightClass.kotlinOrigin ?: return false
-            return primaryConstructor.visibility != KaSymbolVisibility.PRIVATE &&
-                    !classOrObject.hasModifier(INNER_KEYWORD) && !lightClass.isEnum &&
+            return !classOrObject.hasModifier(INNER_KEYWORD) &&
                     !classOrObject.hasModifier(SEALED_KEYWORD) &&
-                    primaryConstructor.valueParameters.isNotEmpty() &&
-                    primaryConstructor.valueParameters.all { it.hasDefaultValue } &&
-                    constructors.none { it.valueParameters.isEmpty() } &&
-                    !primaryConstructor.hasJvmOverloadsAnnotation()
+                    !lightClass.isEnum &&
+                    primaryConstructor.valueParameters.all(KaValueParameterSymbol::hasDefaultValue) &&
+                    constructors.none { it.isEffectivelyParameterless } &&
+                    primaryConstructor.visibility != KaSymbolVisibility.PRIVATE
         }
 
+        /**
+         * Whether the constructor either has no arguments or has [JvmOverloads] which would result in a method with no arguments.
+         * */
+        private val KaConstructorSymbol.isEffectivelyParameterless: Boolean
+            get() = valueParameters.isEmpty() ||
+                    valueParameters.all(KaValueParameterSymbol::hasDefaultValue) && hasJvmOverloadsAnnotation()
+
         private fun SymbolLightClassBase.defaultConstructor(): KtLightMethod {
             val classOrObject = kotlinOrigin
             val visibility = when {

compiler/testData/asJava/lightClasses/lightClassByFqName/duplicatedNoArg.java

@@ -11,9 +11,6 @@ public final class Foo /* test.pkg.Foo*/ {
   @test.pkg.B()
   public  Foo(@org.jetbrains.annotations.NotNull() @org.jetbrains.annotations.NotNull() java.lang.String, int);//  .ctor(@org.jetbrains.annotations.NotNull() java.lang.String, int)
 
-  @test.pkg.A()
-  public  Foo();//  .ctor()
-
   @test.pkg.A()
   public  Foo(int);//  .ctor(int)
 }