[FIR] Enhance status for Java methods with MustUse status from overridden members

Since we copy return value status from parents to implementations (KT-79922),
it should be done for Java enhanced methods as well, to support mixed hierarchies.

By doing so, we can also ditch hard-coded list of collection methods in the checker
— all required statuses will be copied to Java's collections implementations
from interfaces declared in kotlin.collections.

#KT-74810 Fixed

Author: sandwwraith

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLDiagnosticsFe10TestGenerated.java

@@ -171,44 +171,9 @@ private fun ConeKotlinType.isIgnorable(): Boolean {
 private fun FirCallableSymbol<*>.isExcluded(session: FirSession): Boolean = session.mustUseReturnValueStatusComponent.hasIgnorableLikeAnnotation(resolvedAnnotationClassIds)
 
 private fun FirCallableSymbol<*>.isSubjectToCheck(): Boolean {
-    callableId?.ifTypealiasedJvmCollection { return it }
-
-
     // TBD: Do we want to report them unconditionally? Or only in FULL mode?
     // If latter, metadata flag should be added for them too.
     if (this is FirEnumEntrySymbol) return true
 
     return resolvedStatus.returnValueStatus == ReturnValueStatus.MustUse
 }
-
-private inline fun CallableId.ifTypealiasedJvmCollection(nonIgnorableCollectionMethod: (Boolean) -> Unit) {
-    val packageName = packageName.asString()
-    if (packageName != "kotlin.collections" && packageName != "java.util") return
-    val className = className?.asString() ?: return
-    if (className !in setOf( // libraries/stdlib/jvm/src/kotlin/collections/TypeAliases.kt
-            "ArrayList",
-            "HashSet",
-            "LinkedHashSet",
-            "HashMap",
-            "LinkedHashMap",
-        )
-    ) return
-    nonIgnorableCollectionMethod(
-        callableName.asString() !in setOf(
-            "add",
-            "addAll",
-            "remove",
-            "removeAt",
-            "removeAll",
-            "removeIf",
-            "set",
-            "put",
-            "putIfAbsent",
-            "merge",
-            "compute",
-            "computeIfAbsent",
-            "retainAll",
-            "removeLast"
-        )
-    )
-}

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLPartialDiagnosticsFe10TestGenerated.java

@@ -21,7 +21,6 @@ import org.jetbrains.kotlin.fir.caches.firCachesFactory
 import org.jetbrains.kotlin.fir.declarations.*
 import org.jetbrains.kotlin.fir.declarations.builder.*
 import org.jetbrains.kotlin.fir.declarations.impl.FirDeclarationStatusImpl
-import org.jetbrains.kotlin.fir.declarations.impl.FirResolvedDeclarationStatusImpl
 import org.jetbrains.kotlin.fir.declarations.synthetic.FirSyntheticProperty
 import org.jetbrains.kotlin.fir.declarations.synthetic.buildSyntheticProperty
 import org.jetbrains.kotlin.fir.declarations.utils.*
@@ -59,6 +58,7 @@ import org.jetbrains.kotlin.load.java.AnnotationQualifierApplicabilityType.VALUE
 import org.jetbrains.kotlin.load.java.typeEnhancement.*
 import org.jetbrains.kotlin.load.kotlin.SignatureBuildingComponents
 import org.jetbrains.kotlin.name.*
+import org.jetbrains.kotlin.resolve.ReturnValueStatus
 import org.jetbrains.kotlin.types.AbstractTypeChecker
 import org.jetbrains.kotlin.types.model.KotlinTypeMarker
 import org.jetbrains.kotlin.types.model.TypeParameterMarker
@@ -409,7 +409,7 @@ class FirSignatureEnhancement(
                     origin = declarationOrigin
 
                     this.name = name!!
-                    status = firMethod.status
+                    status = enhanceStatus(firMethod, predefinedEnhancementInfo, overriddenMembers)
                     symbol = if (isIntersectionOverride) {
                         FirIntersectionOverrideFunctionSymbol(
                             methodId, overriddenMembers.map { it.symbol },
@@ -505,6 +505,20 @@ class FirSignatureEnhancement(
         return function.symbol
     }
 
+    private fun enhanceStatus(
+        method: FirSimpleFunction,
+        predefinedEnhancementInfo: PredefinedFunctionEnhancementInfo?,
+        overriddenMembers: List<FirCallableDeclaration>,
+    ): FirDeclarationStatus {
+        val original = method.status
+        if (original.returnValueStatus != ReturnValueStatus.Unspecified) return original
+        val newRvStatus = overriddenMembers.firstNotNullOfOrNull { declaration ->
+            declaration.status.returnValueStatus.takeIf { it != ReturnValueStatus.Unspecified }
+        }
+        if (newRvStatus == null) return original
+        return original.copy(returnValueStatus = newRvStatus)
+    }
+
     private fun buildEnhancedValueParameter(
         valueParameter: FirValueParameter,
         enhancedReturnType: FirResolvedTypeRef,

analysis/low-level-api-fir/tests-gen/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/LLReversedDiagnosticsFe10TestGenerated.java

@@ -10,6 +10,7 @@ fun unitF(): Unit = Unit
 fun coll(m: MutableList<String>) {
     m.add("")
     <!RETURN_VALUE_NOT_USED!>m.isEmpty()<!>
+    <!RETURN_VALUE_NOT_USED!>m.toString()<!>
 }
 
 fun nullable(m: MutableList<String>?) {
@@ -20,6 +21,7 @@ fun nullable(m: MutableList<String>?) {
 fun lhs(s: LinkedHashSet<String>) {
     s.add("x")
     <!RETURN_VALUE_NOT_USED!>s.isEmpty()<!>
+    <!RETURN_VALUE_NOT_USED!>s.toString()<!>
 }
 
 fun javaType(m: java.util.ArrayList<String>) {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirLightTreeOldFrontendDiagnosticsWithLatestLanguageVersionTestGenerated.java

@@ -10,6 +10,7 @@ fun unitF(): Unit = Unit
 fun coll(m: MutableList<String>) {
     m.add("")
     m.isEmpty()
+    m.toString()
 }
 
 fun nullable(m: MutableList<String>?) {
@@ -20,6 +21,7 @@ fun nullable(m: MutableList<String>?) {
 fun lhs(s: LinkedHashSet<String>) {
     s.add("x")
     s.isEmpty()
+    s.toString()
 }
 
 fun javaType(m: java.util.ArrayList<String>) {