[FIR] Set fake source kind for invalid expressions with no source

This helps AA ignore such error expressions.

^KT-79143 Fixed
KT-75969

Author: abelkov

analysis/analysis-api/testData/components/resolver/singleByPsi/withErrors/incompleteBinaryExpression.call.txt

@@ -1,15 +1,7 @@
 KtBinaryExpression(17,24): '"dsd" +'
   KaSuccessCallInfo:
     call = KaSimpleFunctionCall:
-      argumentMapping = {
-        "dsd" + -> (KaVariableSignature:
-          name = other
-          receiverType = null
-          returnType = kotlin.Any?
-          symbol = other: kotlin.Any?
-          contextParameters = []
-          callableId = null)
-      }
+      argumentMapping = {}
       isImplicitInvoke = false
       partiallyAppliedSymbol = KaPartiallyAppliedSymbol:
         contextArguments = []

analysis/analysis-api/testData/components/resolver/singleByPsi/withErrors/incompleteBinaryExpression.candidates.txt

@@ -1,15 +1,7 @@
 KtBinaryExpression(17,24): '"dsd" +'
   KaApplicableCallCandidateInfo:
     candidate = KaSimpleFunctionCall:
-      argumentMapping = {
-        "dsd" + -> (KaVariableSignature:
-          name = other
-          receiverType = null
-          returnType = kotlin.Any?
-          symbol = other: kotlin.Any?
-          contextParameters = []
-          callableId = null)
-      }
+      argumentMapping = {}
       isImplicitInvoke = false
       partiallyAppliedSymbol = KaPartiallyAppliedSymbol:
         contextArguments = []
@@ -38,15 +30,7 @@ KtBinaryExpression(17,24): '"dsd" +'
 
   KaApplicableCallCandidateInfo:
     candidate = KaSimpleFunctionCall:
-      argumentMapping = {
-        "dsd" + -> (KaVariableSignature:
-          name = other
-          receiverType = null
-          returnType = kotlin.Any?
-          symbol = other: kotlin.Any?
-          contextParameters = []
-          callableId = null)
-      }
+      argumentMapping = {}
       isImplicitInvoke = false
       partiallyAppliedSymbol = KaPartiallyAppliedSymbol:
         contextArguments = []
@@ -71,4 +55,4 @@ KtBinaryExpression(17,24): '"dsd" +'
           contextParameters = []
           callableId = kotlin/plus
       typeArgumentsMapping = {}
-    isInBestCandidates = false
+    isInBestCandidates = false

analysis/analysis-api/testData/components/resolver/singleByPsi/withErrors/incompleteBinaryExpression.descriptors.call.txt

@@ -95,16 +95,23 @@ class LightTreeRawFirExpressionBuilder(
             converted is R -> when {
                 isValidExpression(converted) -> converted
                 else -> buildErrorExpression(
-                    converted.source?.realElement() ?: expression?.toFirSourceElement() ?: sourceWhenInvalidExpression.toFirSourceElement(),
-                    ConeSimpleDiagnostic(errorReason, DiagnosticKind.ExpressionExpected),
-                    converted,
+                    source = converted.source?.realElement()
+                        ?: expression?.toFirSourceElement()
+                        ?: sourceWhenInvalidExpression.toFirSourceElement(kind = KtFakeSourceElementKind.ErrorExpression),
+                    diagnostic = ConeSimpleDiagnostic(errorReason, DiagnosticKind.ExpressionExpected),
+                    element = converted,
                 )
             }
             else -> buildErrorExpression(
-                converted?.source?.realElement() ?: expression?.toFirSourceElement() ?: sourceWhenInvalidExpression.toFirSourceElement(),
-                if (expression == null) ConeSyntaxDiagnostic(errorReason)
-                else ConeSimpleDiagnostic(errorReason, DiagnosticKind.ExpressionExpected),
-                converted,
+                source = converted?.source?.realElement()
+                    ?: expression?.toFirSourceElement()
+                    ?: sourceWhenInvalidExpression.toFirSourceElement(kind = KtFakeSourceElementKind.ErrorExpression),
+                diagnostic = if (expression == null) {
+                    ConeSyntaxDiagnostic(errorReason)
+                } else {
+                    ConeSimpleDiagnostic(errorReason, DiagnosticKind.ExpressionExpected)
+                },
+                element = converted,
             )
         } as R
     }

compiler/fir/raw-fir/light-tree2fir/src/org/jetbrains/kotlin/fir/lightTree/converter/LightTreeRawFirExpressionBuilder.kt

@@ -346,7 +346,10 @@ open class PsiRawFirBuilder(
             diagnosticFn: (missing: Boolean) -> ConeDiagnostic,
         ): FirExpression {
             if (this == null) {
-                return buildErrorExpression(source = sourceWhenInvalidExpression.toFirSourceElement(), diagnosticFn(true))
+                return buildErrorExpression(
+                    source = sourceWhenInvalidExpression.toFirSourceElement(kind = KtFakeSourceElementKind.ErrorExpression),
+                    diagnosticFn(true)
+                )
             }
 
             return when (val fir = convertElement(this, null)) {
@@ -355,7 +358,8 @@ open class PsiRawFirBuilder(
                     else -> buildErrorExpression {
                         nonExpressionElement = fir
                         diagnostic = diagnosticFn(false)
-                        source = fir.source?.realElement() ?: sourceWhenInvalidExpression.toFirSourceElement()
+                        source = fir.source?.realElement()
+                            ?: sourceWhenInvalidExpression.toFirSourceElement(kind = KtFakeSourceElementKind.ErrorExpression)
                     }
                 }
                 else -> buildErrorExpression {

compiler/fir/raw-fir/psi2fir/src/org/jetbrains/kotlin/fir/builder/PsiRawFirBuilder.kt

@@ -557,6 +557,11 @@ sealed class KtFakeSourceElementKind(final override val shouldSkipErrorTypeRepor
      */
     object ErrorExpressionForTopLevelLambda : KtFakeSourceElementKind()
 
+    /**
+     * Arbitrary error expression for which we failed to build the real PSI.
+     */
+    object ErrorExpression : KtFakeSourceElementKind()
+
     /**
      * When resolving ENTRY as `MyEnum.ENTRY` this is used for the `MyEnum` part
      */