Skip to content

Commit 76cdb87

Browse files
lunakolySpace Team
authored andcommitted
[Commonizer] Remove references to CallableMemberDescriptor
In FIR, we're fine using `Modality`, `Visibility`, and `ClassKind`, but this one will probably be dropped together with K1.
1 parent d254bc5 commit 76cdb87

File tree

7 files changed

+24
-22
lines changed

7 files changed

+24
-22
lines changed

native/commonizer/src/org/jetbrains/kotlin/commonizer/cir/CirFunction.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package org.jetbrains.kotlin.commonizer.cir
77

8-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor
98
import org.jetbrains.kotlin.descriptors.Modality
109
import org.jetbrains.kotlin.descriptors.Visibility
1110

@@ -20,7 +19,7 @@ data class CirFunction(
2019
override var hasStableParameterNames: Boolean,
2120
override val extensionReceiver: CirExtensionReceiver?,
2221
override val returnType: CirType,
23-
override val kind: CallableMemberDescriptor.Kind,
22+
override val kind: CirFunctionOrProperty.Kind,
2423
val modifiers: CirFunctionModifiers
2524
) : CirFunctionOrProperty, CirCallableMemberWithParameters {
2625
override fun withContainingClass(containingClass: CirContainingClass): CirFunction {

native/commonizer/src/org/jetbrains/kotlin/commonizer/cir/CirFunctionOrProperty.kt

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package org.jetbrains.kotlin.commonizer.cir
77

8-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor
98
import org.jetbrains.kotlin.descriptors.ClassKind
109
import org.jetbrains.kotlin.descriptors.Modality
1110
import org.jetbrains.kotlin.descriptors.Visibilities
@@ -21,7 +20,14 @@ interface CirFunctionOrProperty :
2120

2221
val extensionReceiver: CirExtensionReceiver?
2322
val returnType: CirType
24-
val kind: CallableMemberDescriptor.Kind
23+
val kind: Kind
24+
25+
enum class Kind {
26+
DECLARATION,
27+
FAKE_OVERRIDE,
28+
DELEGATION,
29+
SYNTHESIZED,
30+
}
2531

2632
fun isVirtual(): Boolean =
2733
visibility != Visibilities.Private

native/commonizer/src/org/jetbrains/kotlin/commonizer/cir/CirProperty.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package org.jetbrains.kotlin.commonizer.cir
77

8-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor
98
import org.jetbrains.kotlin.descriptors.Modality
109
import org.jetbrains.kotlin.descriptors.Visibility
1110

@@ -18,7 +17,7 @@ data class CirProperty(
1817
override val containingClass: CirContainingClass?,
1918
override val extensionReceiver: CirExtensionReceiver?,
2019
override val returnType: CirType,
21-
override val kind: CallableMemberDescriptor.Kind,
20+
override val kind: CirFunctionOrProperty.Kind,
2221
val isVar: Boolean,
2322
val isLateInit: Boolean,
2423
val isConst: Boolean,

native/commonizer/src/org/jetbrains/kotlin/commonizer/core/AbstractFunctionOrPropertyCommonizer.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ import org.jetbrains.kotlin.commonizer.CommonizerSettings
99
import org.jetbrains.kotlin.commonizer.cir.*
1010
import org.jetbrains.kotlin.commonizer.mergedtree.CirKnownClassifiers
1111
import org.jetbrains.kotlin.commonizer.utils.singleDistinctValueOrNull
12-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor
13-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor.Kind.DELEGATION
14-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor.Kind.SYNTHESIZED
12+
import org.jetbrains.kotlin.commonizer.cir.CirFunctionOrProperty.Kind.DELEGATION
13+
import org.jetbrains.kotlin.commonizer.cir.CirFunctionOrProperty.Kind.SYNTHESIZED
1514
import org.jetbrains.kotlin.descriptors.Modality
1615
import org.jetbrains.kotlin.descriptors.Visibility
1716

@@ -25,7 +24,7 @@ class FunctionOrPropertyBaseCommonizer(
2524

2625
data class FunctionOrProperty(
2726
val name: CirName,
28-
val kind: CallableMemberDescriptor.Kind,
27+
val kind: CirFunctionOrProperty.Kind,
2928
val modality: Modality,
3029
val visibility: Visibility,
3130
val extensionReceiver: CirExtensionReceiver?,

native/commonizer/src/org/jetbrains/kotlin/commonizer/metadata/CirDeserializers.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ object CirDeserializers {
142142
}
143143

144144
@Suppress("NOTHING_TO_INLINE")
145-
private inline fun callableKind(memberKind: MemberKind): CallableMemberDescriptor.Kind =
145+
private inline fun callableKind(memberKind: MemberKind): CirFunctionOrProperty.Kind =
146146
when (memberKind) {
147-
MemberKind.DECLARATION -> CallableMemberDescriptor.Kind.DECLARATION
148-
MemberKind.FAKE_OVERRIDE -> CallableMemberDescriptor.Kind.FAKE_OVERRIDE
149-
MemberKind.DELEGATION -> CallableMemberDescriptor.Kind.DELEGATION
150-
MemberKind.SYNTHESIZED -> CallableMemberDescriptor.Kind.SYNTHESIZED
147+
MemberKind.DECLARATION -> CirFunctionOrProperty.Kind.DECLARATION
148+
MemberKind.FAKE_OVERRIDE -> CirFunctionOrProperty.Kind.FAKE_OVERRIDE
149+
MemberKind.DELEGATION -> CirFunctionOrProperty.Kind.DELEGATION
150+
MemberKind.SYNTHESIZED -> CirFunctionOrProperty.Kind.SYNTHESIZED
151151
}
152152

153153
fun function(name: CirName, source: KmFunction, containingClass: CirContainingClass?, typeResolver: CirTypeResolver): CirFunction =

native/commonizer/src/org/jetbrains/kotlin/commonizer/metadata/CirSerializers.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ internal fun CirFunction.serializeFunction(
182182
): KmFunction = KmFunction(
183183
name = name.name
184184
).also { function ->
185-
function.modifiersFrom(this, isExpect = context.isCommon && kind != CallableMemberDescriptor.Kind.SYNTHESIZED)
185+
function.modifiersFrom(this, isExpect = context.isCommon && kind != CirFunctionOrProperty.Kind.SYNTHESIZED)
186186
annotations.mapTo(function.annotations) { it.serializeAnnotation() }
187187
typeParameters.serializeTypeParameters(context, output = function.typeParameters)
188188
valueParameters.mapTo(function.valueParameters) { it.serializeValueParameter(context) }

native/commonizer/src/org/jetbrains/kotlin/commonizer/metadata/flags.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
package org.jetbrains.kotlin.commonizer.metadata
88

99
import org.jetbrains.kotlin.commonizer.cir.*
10-
import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor
1110
import org.jetbrains.kotlin.descriptors.ClassKind
1211
import org.jetbrains.kotlin.descriptors.Modality
1312
import org.jetbrains.kotlin.descriptors.Visibilities
@@ -120,12 +119,12 @@ private inline val CirHasModality.kmModality: KmModality
120119
Modality.SEALED -> KmModality.SEALED
121120
}
122121

123-
private inline val CallableMemberDescriptor.Kind.kmMemberKind: MemberKind
122+
private inline val CirFunctionOrProperty.Kind.kmMemberKind: MemberKind
124123
get() = when (this) {
125-
CallableMemberDescriptor.Kind.DECLARATION -> MemberKind.DECLARATION
126-
CallableMemberDescriptor.Kind.FAKE_OVERRIDE -> MemberKind.FAKE_OVERRIDE
127-
CallableMemberDescriptor.Kind.DELEGATION -> MemberKind.DELEGATION
128-
CallableMemberDescriptor.Kind.SYNTHESIZED -> MemberKind.SYNTHESIZED
124+
CirFunctionOrProperty.Kind.DECLARATION -> MemberKind.DECLARATION
125+
CirFunctionOrProperty.Kind.FAKE_OVERRIDE -> MemberKind.FAKE_OVERRIDE
126+
CirFunctionOrProperty.Kind.DELEGATION -> MemberKind.DELEGATION
127+
CirFunctionOrProperty.Kind.SYNTHESIZED -> MemberKind.SYNTHESIZED
129128
}
130129

131130
private inline val CirClass.kmClassKind: KmClassKind

0 commit comments

Comments
 (0)