[IR] Specify required context updaters for each checker

So that the callee does not forget to add it when adding a checker.

Author: mcpiroman

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/IrValidator.kt

@@ -96,7 +96,7 @@ private class IrFileValidator(
     config: IrValidatorConfig,
     private val context: CheckerContext
 ) : IrTreeSymbolsVisitor() {
-    private val contextUpdaters: MutableList<ContextUpdater> = mutableListOf(ParentChainUpdater)
+    private val contextUpdaters: MutableSet<ContextUpdater> = mutableSetOf(ParentChainUpdater)
     private val elementCheckers: MutableList<IrElementChecker<*>> = mutableListOf(
         IrNoInlineUseSitesChecker, IrSetValueAssignabilityChecker,
         IrFunctionDispatchReceiverChecker, IrFunctionParametersChecker, IrConstructorReceiverChecker,
@@ -108,11 +108,9 @@ private class IrFileValidator(
 
     init {
         if (config.checkValueScopes) {
-            contextUpdaters.add(ValueScopeUpdater)
             elementCheckers.add(IrValueAccessScopeChecker)
         }
         if (config.checkTypeParameterScopes) {
-            contextUpdaters.add(TypeParameterScopeUpdater)
             typeCheckers.add(IrTypeParameterScopeChecker)
         }
         if (config.checkAllKotlinFieldsArePrivate) {
@@ -146,6 +144,10 @@ private class IrFileValidator(
         if (config.checkOverridePrivateDeclaration) {
             elementCheckers.add(IrPrivateDeclarationOverrideChecker)
         }
+
+        for (checker in elementCheckers + symbolCheckers + typeCheckers) {
+            contextUpdaters += checker.requiredContextUpdaters
+        }
     }
 
     private val checkersPerElement = object : ClassValue<List<IrElementChecker<*>>>() {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/checkers/IrChecker.kt

@@ -12,7 +12,10 @@ import org.jetbrains.kotlin.ir.symbols.IrSymbol
 import org.jetbrains.kotlin.ir.types.IrType
 import kotlin.reflect.KClass
 
-sealed interface IrChecker
+sealed interface IrChecker {
+    val requiredContextUpdaters : Set<ContextUpdater>
+        get() = emptySet()
+}
 
 abstract class IrElementChecker<in E : IrElement>(
     elementClass: KClass<in E>,

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/checkers/expression/IrValueAccessScopeChecker.kt

@@ -7,9 +7,14 @@ package org.jetbrains.kotlin.backend.common.checkers.expression
 
 import org.jetbrains.kotlin.backend.common.checkers.IrElementChecker
 import org.jetbrains.kotlin.backend.common.checkers.context.CheckerContext
+import org.jetbrains.kotlin.backend.common.checkers.context.ContextUpdater
+import org.jetbrains.kotlin.backend.common.checkers.context.ValueScopeUpdater
 import org.jetbrains.kotlin.ir.expressions.IrValueAccessExpression
 
 object IrValueAccessScopeChecker : IrElementChecker<IrValueAccessExpression>(IrValueAccessExpression::class) {
+    override val requiredContextUpdaters: Set<ContextUpdater>
+        get() = setOf(ValueScopeUpdater)
+
     override fun check(element: IrValueAccessExpression, context: CheckerContext) {
         if (!context.valueSymbolScopeStack.isVisibleInCurrentScope(element.symbol)) {
             context.error(element, "The following expression references a value that is not available in the current scope.")

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/checkers/type/IrTypeParameterScopeChecker.kt

@@ -7,6 +7,8 @@ package org.jetbrains.kotlin.backend.common.checkers.type
 
 import org.jetbrains.kotlin.backend.common.checkers.IrTypeChecker
 import org.jetbrains.kotlin.backend.common.checkers.context.CheckerContext
+import org.jetbrains.kotlin.backend.common.checkers.context.ContextUpdater
+import org.jetbrains.kotlin.backend.common.checkers.context.TypeParameterScopeUpdater
 import org.jetbrains.kotlin.ir.IrElement
 import org.jetbrains.kotlin.ir.symbols.IrTypeParameterSymbol
 import org.jetbrains.kotlin.ir.types.IrSimpleType
@@ -17,6 +19,9 @@ import org.jetbrains.kotlin.ir.util.render
  * Makes sure that all the type parameter references are within the scope of the corresponding type parameters.
  */
 object IrTypeParameterScopeChecker : IrTypeChecker {
+    override val requiredContextUpdaters: Set<ContextUpdater>
+        get() = setOf(TypeParameterScopeUpdater)
+
     override fun check(
         type: IrType,
         container: IrElement,